Issues in ParentNodeTrait.php (master) - Issues in master - Nayjest/Tree - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ParentNodeTrait.php (3 issues)

Labels

Bug 3

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Nayjest\Tree;

use Nayjest\Collection\Extended\ObjectCollection;
use Traversable;

/**
 * Trait ParentNodeTrait.
 *
 * @implements ParentNodeInterface
 * @see ParentNodeInterface
 */
trait ParentNodeTrait
{
    /**
     * Collection of child nodes (objects implementing ChildNodeInterface)
     * @var NodeCollection
     */
    protected $collection;

    /**
     * Returns array containing default child nodes.
     *
     * Override this method if you need to implement parent node class that must contain certain children by default.
     *
     * @return ChildNodeInterface[]
     */
    protected function defaultChildren()
    {
        return [];
    }

    /**
     * Initializes collection of child nodes.
     * 
     * This method is called once when accessing collection first time
     * or constructing node with children passed to constructor argument.
     * 
     * @param array $items
     */
    protected function initializeCollection(array $items)
    {
        /* @var ParentNodeInterface|ParentNodeTrait $this */
        $this->collection = new NodeCollection(
            $this,
            $items
        );
    }

    /**
     * Returns collection of child nodes.
     *
     * @return \Nayjest\Collection\CollectionInterface|ChildNodeInterface[]
     */
    public function children()
    {
        if ($this->collection === null) {
            $this->initializeCollection($this->defaultChildren());
        }

        return $this->collection;
    }

    /**
     * Returns true if collection of child nodes is writable (open for modifications), returns false otherwise.
     * 
     * @return bool
     */
    final public function isWritable()
    {
        return $this->children()->isWritable();
    }

    /**
     * Returns collection containing all descendant nodes.
     * 
     * @return CollectionInterface|ObjectCollection|ChildNodeInterface[]
     */
    public function getChildrenRecursive()
    {
        $res = new ObjectCollection();
        foreach ($this->children() as $child) {
            $res->add($child);
            if ($child instanceof ParentNodeInterface) {
                $res->addMany($child->getChildrenRecursive());
            }
        }

        return $res;
    }

    /**
     * Clears collection of child nodes and attaches new children.
     * 
     * @param Traversable|ChildNodeInterface[] $children
     *
     * @return $this
     */
    public function setChildren($children)
    {
        $this->children()->set($children);


        return $this;
    }

    /**
     * Attaches child node.
     * 
     * @param ChildNodeInterface $item
     *
     * @return $this
     */
    public function addChild(ChildNodeInterface $item)
    {
        $this->children()->add($item);


        return $this;
    }

    /**
     * Attaches list of child nodes.
     * 
     * @param array|Traversable $children
     *
     * @return $this
     */
    public function addChildren($children)
    {
        $this->children()->addMany($children);


        return $this;
    }
}


1			<?php
2
3			namespace Nayjest\Tree;
4
5			use Nayjest\Collection\Extended\ObjectCollection;
6			use Traversable;
7
8			/**
9			* Trait ParentNodeTrait.
10			*
11			* @implements ParentNodeInterface
12			* @see ParentNodeInterface
13			*/
14			trait ParentNodeTrait
15			{
16			/**
17			* Collection of child nodes (objects implementing ChildNodeInterface)
18			* @var NodeCollection
19			*/
20			protected $collection;
21
22			/**
23			* Returns array containing default child nodes.
24			*
25			* Override this method if you need to implement parent node class that must contain certain children by default.
26			*
27			* @return ChildNodeInterface[]
28			*/
29			protected function defaultChildren()
30			{
31			return [];
32			}
33
34			/**
35			* Initializes collection of child nodes.
36			*
37			* This method is called once when accessing collection first time
38			* or constructing node with children passed to constructor argument.
39			*
40			* @param array $items
41			*/
42			protected function initializeCollection(array $items)
43			{
44			/* @var ParentNodeInterface\|ParentNodeTrait $this */
45			$this->collection = new NodeCollection(
46			$this,
47			$items
48			);
49			}
50
51			/**
52			* Returns collection of child nodes.
53			*
54			* @return \Nayjest\Collection\CollectionInterface\|ChildNodeInterface[]
55			*/
56			public function children()
57			{
58			if ($this->collection === null) {
59			$this->initializeCollection($this->defaultChildren());
60			}
61
62			return $this->collection;
63			}
64
65			/**
66			* Returns true if collection of child nodes is writable (open for modifications), returns false otherwise.
67			*
68			* @return bool
69			*/
70			final public function isWritable()
71			{
72			return $this->children()->isWritable();
73			}
74
75			/**
76			* Returns collection containing all descendant nodes.
77			*
78			* @return CollectionInterface\|ObjectCollection\|ChildNodeInterface[]
79			*/
80			public function getChildrenRecursive()
81			{
82			$res = new ObjectCollection();
83			foreach ($this->children() as $child) {
84			$res->add($child);
85			if ($child instanceof ParentNodeInterface) {
86			$res->addMany($child->getChildrenRecursive());
87			}
88			}
89
90			return $res;
91			}
92
93			/**
94			* Clears collection of child nodes and attaches new children.
95			*
96			* @param Traversable\|ChildNodeInterface[] $children
97			*
98			* @return $this
99			*/
100			public function setChildren($children)
101			{
102			$this->children()->set($children);
			0 ignored issues – show Bug introduced 2016-01-20 14:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `set()` does not seem to exist on `object<Nayjest\Collectio...adonlyObjectCollection>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
103
104			return $this;
105			}
106
107			/**
108			* Attaches child node.
109			*
110			* @param ChildNodeInterface $item
111			*
112			* @return $this
113			*/
114			public function addChild(ChildNodeInterface $item)
115			{
116			$this->children()->add($item);
			0 ignored issues – show Bug introduced 2016-01-20 14:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `add()` does not seem to exist on `object<Nayjest\Collectio...adonlyObjectCollection>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
117
118			return $this;
119			}
120
121			/**
122			* Attaches list of child nodes.
123			*
124			* @param array\|Traversable $children
125			*
126			* @return $this
127			*/
128			public function addChildren($children)
129			{
130			$this->children()->addMany($children);
			0 ignored issues – show Bug introduced 2016-01-20 14:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `addMany()` does not seem to exist on `object<Nayjest\Collectio...adonlyObjectCollection>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
131
132			return $this;
133			}
134			}
135

Nayjest / Tree

Issues (15)

Security Analysis no request data

src/ParentNodeTrait.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like