Update::update() - Code Metrics - Inspection of "WIP v2" - NavJobs/transmit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Josh

created 2017-03-06 05:23 UTC

Update::update() A

↳ Parent: Update

Complexity

Conditions	2
Paths	1

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
dl	0
loc	14
rs	9.4285
c	2
b	0
f	1
cc	2
eloc	8
nc	1
nop	2

<?php

namespace NavJobs\Transmit\Transmitters;

use NavJobs\Transmit\Controller;
use Illuminate\Http\Request;

trait Update
{
    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update($id, Request $request)
    {
        return $this->respondWithItem($this->model, function ($model) use ($id, $request) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $item = $model->findOrFail($id);

            if ($this->shouldAuthorize) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->authorize('update', $item);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }

            $item->fill($request->all());
            $item->save();
            return $item;
        });
    }
}


1			<?php
2
3			namespace NavJobs\Transmit\Transmitters;
4
5			use NavJobs\Transmit\Controller;
6			use Illuminate\Http\Request;
7
8			trait Update
9			{
10			/**
11			* Update the specified resource in storage.
12			*
13			* @param \Illuminate\Http\Request $request
14			* @param int $id
15			* @return \Illuminate\Http\Response
16			*/
17			public function update($id, Request $request)
18			{
19			return $this->respondWithItem($this->model, function ($model) use ($id, $request) {
			0 ignored issues – show Bug introduced 2017-02-22 02:06 UTC by Report Bug Copy Issue Report The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-02-22 02:06 UTC by Report Bug Copy Issue Report It seems like `respondWithItem()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20			$item = $model->findOrFail($id);
21
22			if ($this->shouldAuthorize) {
			0 ignored issues – show Bug introduced 2017-03-06 04:40 UTC by Report Bug Copy Issue Report The property `shouldAuthorize` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			$this->authorize('update', $item);
			0 ignored issues – show Bug introduced 2017-03-06 04:40 UTC by Report Bug Copy Issue Report It seems like `authorize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			$item->fill($request->all());
27			$item->save();
28			return $item;
29			});
30			}
31			}
32

NavJobs / transmit

Pull Request — master (#5)

Update::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like