NauxLiu / phphub-server

app/Http/ApiControllers/RepliesController.php

<?php

namespace PHPHub\Http\ApiControllers;

use Dingo\Api\Exception\StoreResourceFailedException;
use PHPHub\Repositories\ReplyRepositoryInterface;
use PHPHub\Transformers\ReplyTransformer;
use PHPHub\User;
use Illuminate\Http\Request;
use Prettus\Validator\Exceptions\ValidatorException;

class RepliesController extends Controller
{
    /**
     * @var ReplyRepositoryInterface
     */
    private $replies;

    /**
     * TopicController constructor.
     *
     * @param ReplyRepositoryInterface $repository
     */
    public function __construct(ReplyRepositoryInterface $repository)
    {
        $this->replies = $repository;
    }

    /**
     * 获取指定帖子的回复.
     *
     * @param $topic_id
     *
     * @return \Illuminate\Http\Response
     */
    public function indexByTopicId($topic_id)

This method seems to be duplicated in your project.

    {
        $this->replies->addAvailableInclude('user', ['name', 'avatar']);

        $data = $this->replies
            ->byTopicId($topic_id)
            ->autoWith()
            ->autoWithRootColumns(['id', 'vote_count', 'created_at'])
            ->paginate(per_page());

        return $this->response()->paginator($data, new ReplyTransformer());
    }

    /**
     * 获取指定用户的回复.
     *
     * @param $user_id
     *
     * @return \Dingo\Api\Http\Response
     */
    public function indexByUserId($user_id)

This method seems to be duplicated in your project.

    {
        $this->replies->addAvailableInclude('user', ['name', 'avatar']);

        $data = $this->replies
            ->byUserId($user_id)
            ->autoWith()
            ->autoWithRootColumns(['id', 'vote_count'])
            ->paginate(per_page());

        return $this->response()->paginator($data, new ReplyTransformer());
    }

    /**
     * 发布一条新回复.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)

This method seems to be duplicated in your project.

    {
        try {
            $reply = $this->replies->store($request->all());

            return $this->response()->item($reply, new ReplyTransformer());
        } catch (ValidatorException $e) {
            throw new StoreResourceFailedException('Could not create new topic.', $e->getMessageBag()->all());
        }
    }

    /**
     * 更新回复.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

The parameter $request is not used and could be removed.

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * 删除一条回复.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * 指定帖子下评论列表的 Web View.
     *
     * @param $topic_id
     *
     * @return \Illuminate\View\View
     */
    public function indexWebViewByTopic($topic_id)
    {
        $replies = $this->replies
            ->byTopicId($topic_id)
            ->withOnly('user', ['id', 'name', 'avatar'])
            ->all(['id', 'body', 'created_at', 'user_id']);

        // 楼层计数
        $count = 1;

        return view('api_web_views.replies_list', compact('replies', 'count'));

The expression view('api_web_views.replies_list', compact('replies', 'count')); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 129 which is incompatible with the return type documented by PHPHub\Http\ApiControllers\RepliesController::indexWebViewByTopic of type Illuminate\View\View.

    }

    /**
     * 指定帖子下评论列表的 Web View.
     *
     * @param $user_id
     *
     * @return \Illuminate\View\View
     */
    public function indexWebViewByUser($user_id)
    {
        $replies = $this->replies
            ->byUserId($user_id)
            ->withOnly('topic.user', ['avatar'])
            ->all(['id', 'body', 'created_at', 'topic_id']);

        return view('api_web_views.users_replies_list', compact('replies', 'count'));

The expression view('api_web_views.users_replies_list', compact('replies', 'count')); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 146 which is incompatible with the return type documented by PHPHub\Http\ApiControllers\RepliesController::indexWebViewByUser of type Illuminate\View\View.

    }
}