NathanGeerinck / laravel-newsletter

app/Mail/CampaignSendMail.php

<?php

namespace App\Mail;

use App\Models\Campaign;
use Illuminate\Bus\Queueable;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;

/**
 * @param $subscriptions
 * @property Campaign campaign
 */
class CampaignSendMail extends Mailable
{
    use Queueable, SerializesModels;

The trait Illuminate\Queue\SerializesModels requires some properties which are not provided by App\Mail\CampaignSendMail: $id, $class, $relations

    public $subscriptions;
    public $campaign;

    public function __construct($subscriptions, Campaign $campaign)
    {
        $this->subscriptions = $subscriptions;
        $this->campaign = $campaign;
    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        return $this->markdown('emails.campaigns.send', ['campaign' => $this->campaign->name, 'subscribers' => count($this->subscriptions)])
            ->subject(trans('emails.campaigns.send.subject'));

It seems like trans('emails.campaigns.send.subject') can also be of type array; however, parameter $subject of Illuminate\Mail\Mailable::subject() does only seem to accept string, maybe add an additional type check?

    }
}