NathanGeerinck / laravel-newsletter

app/Http/Controllers/SubscribeController.php

<?php

namespace App\Http\Controllers;

use App\Models\MailingList;
use App\Models\Subscription;
use App\Http\Requests\SubscribeRequest;

class SubscribeController extends Controller
{
    /**
     * @param MailingList $list
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function mailing_list(MailingList $list)
    {
        abort_unless($list->public, 404);

$list->public of type integer is incompatible with the type boolean expected by parameter $boolean of abort_unless().

        return view('subscribe.list', compact('list'));
    }

    /**
     * @param SubscribeRequest $request
     * @param MailingList $list
     * @return \Illuminate\Http\RedirectResponse
     */
    public function subscribe(SubscribeRequest $request, MailingList $list)
    {
        $subscription = $list->subscriptions()->create($request->all());

The assignment to $subscription is dead and can be removed.

        notify()->flash($list->name, 'success', [
            'timer' => 2000,
            'text' => trans('subscriptions.subscribe.success'),
        ]);

        return redirect()->back();
    }

    /**
     * @param $email
     * @param $unSubscribe
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function preUnSubscribe($email, $unSubscribe)
    {
        $subscription = Subscription::whereEmail($email)->whereUnsubscribe($unSubscribe)->first();

        abort_unless($subscription, 404);

It seems like $subscription can also be of type App\Models\Subscription; however, parameter $boolean of abort_unless() does only seem to accept boolean, maybe add an additional type check?

        return view('subscriptions.unsubscribe', compact('subscription'));
    }

    /**
     * @param Subscription $subscription
     * @return \Illuminate\Http\RedirectResponse
     */
    public function unSubscribe(Subscription $subscription)
    {
        $subscription->delete();

        notify()->flash(trans('general.woohoo'), 'success', [

It seems like trans('general.woohoo') can also be of type array; however, parameter $message of Codecourse\Notify\Notifier::flash() does only seem to accept string, maybe add an additional type check?

            'timer' => 3500,
            'text' => trans('subscriptions.unsubscribe.success'),
        ]);

        return redirect()->route('index');
    }
}