Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like VocabularyConfig often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use VocabularyConfig, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 6 | class VocabularyConfig extends DataObject |
||
|
|
|||
| 7 | { |
||
| 8 | private $plugins; |
||
| 9 | |||
| 10 | public function __construct($resource, $globalPlugins=array()) |
||
| 22 | |||
| 23 | /** |
||
| 24 | * Returns a boolean value based on a literal value from the vocabularies.ttl configuration. |
||
| 25 | * @param string $property the property to query |
||
| 26 | * @param boolean $default the default value if the value is not set in configuration |
||
| 27 | */ |
||
| 28 | private function getBoolean($property, $default = false) |
||
| 37 | |||
| 38 | /** |
||
| 39 | * Returns a boolean value based on a literal value from the vocabularies.ttl configuration. |
||
| 40 | * @param string $property the property to query |
||
| 41 | * @param string $lang preferred language for the literal, |
||
| 42 | */ |
||
| 43 | private function getLiteral($property, $lang=null) |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Get the default language of this vocabulary |
||
| 62 | * @return string default language, e.g. 'en' |
||
| 63 | */ |
||
| 64 | |||
| 65 | public function getDefaultLanguage() |
||
| 80 | |||
| 81 | /** |
||
| 82 | * Wether the alphabetical index is small enough to be shown all at once. |
||
| 83 | * @return boolean true if all concepts can be shown at once. |
||
| 84 | */ |
||
| 85 | public function getAlphabeticalFull() |
||
| 89 | |||
| 90 | /** |
||
| 91 | * Returns a short name for a vocabulary if configured. If that has not been set |
||
| 92 | * using vocabId as a fallback. |
||
| 93 | * @return string |
||
| 94 | */ |
||
| 95 | public function getShortName() |
||
| 104 | |||
| 105 | /** |
||
| 106 | * Get the vocabulary feedback e-mail address and return it. |
||
| 107 | * |
||
| 108 | * @return string e-mail address or null if not defined. |
||
| 109 | */ |
||
| 110 | public function getFeedbackRecipient() |
||
| 115 | |||
| 116 | /** |
||
| 117 | * Returns the human readable vocabulary title. |
||
| 118 | * @return string the title of the vocabulary |
||
| 119 | */ |
||
| 120 | public function getTitle($lang = null) |
||
| 124 | |||
| 125 | /** |
||
| 126 | * Returns a boolean value set in the vocabularies.ttl config. |
||
| 127 | * @return boolean |
||
| 128 | */ |
||
| 129 | public function sortByNotation() |
||
| 133 | |||
| 134 | /** |
||
| 135 | * Returns a boolean value set in the vocabularies.ttl config. |
||
| 136 | * @return boolean |
||
| 137 | */ |
||
| 138 | public function showChangeList() |
||
| 142 | |||
| 143 | /** |
||
| 144 | * get the URLs from which the vocabulary data can be downloaded |
||
| 145 | * @return array Array with MIME type as key, URL as value |
||
| 146 | */ |
||
| 147 | public function getDataURLs() |
||
| 174 | |||
| 175 | /** |
||
| 176 | * Returns the class URI used for concept groups in this vocabulary, |
||
| 177 | * or null if not set. |
||
| 178 | * @return string group class URI or null |
||
| 179 | */ |
||
| 180 | |||
| 181 | public function getGroupClassURI() |
||
| 190 | |||
| 191 | /** |
||
| 192 | * Returns the class URI used for thesaurus arrays in this vocabulary, |
||
| 193 | * or null if not set. |
||
| 194 | * @return string array class URI or null |
||
| 195 | */ |
||
| 196 | |||
| 197 | public function getArrayClassURI() |
||
| 206 | |||
| 207 | /** |
||
| 208 | * Returns custom properties displayed on the search page if configured. |
||
| 209 | * @return string array class URI or null |
||
| 210 | */ |
||
| 211 | |||
| 212 | View Code Duplication | public function getAdditionalSearchProperties() |
|
| 213 | { |
||
| 214 | $resources = $this->resource->allResources("skosmos:showPropertyInSearch"); |
||
| 215 | $ret = array(); |
||
| 216 | foreach ($resources as $res) { |
||
| 217 | $prop = $res->getURI(); |
||
| 218 | if (EasyRdf_Namespace::shorten($prop) !== null) // shortening property labels if possible |
||
| 219 | { |
||
| 220 | $prop = EasyRdf_Namespace::shorten($prop); |
||
| 221 | } |
||
| 222 | |||
| 223 | $ret[] = $prop; |
||
| 224 | } |
||
| 225 | return $ret; |
||
| 226 | } |
||
| 227 | |||
| 228 | /** |
||
| 229 | * Queries whether the property should be shown with all the label language variations. |
||
| 230 | * @param string $property |
||
| 231 | * @return boolean |
||
| 232 | */ |
||
| 233 | public function hasMultiLingualProperty($property) |
||
| 234 | { |
||
| 235 | $resources = $this->resource->allResources("skosmos:hasMultiLingualProperty"); |
||
| 236 | foreach ($resources as $res) { |
||
| 237 | $prop = $res->getURI(); |
||
| 238 | if (EasyRdf_Namespace::shorten($prop) !== null) // shortening property labels if possible |
||
| 239 | { |
||
| 240 | $prop = EasyRdf_Namespace::shorten($prop); |
||
| 241 | } |
||
| 242 | |||
| 243 | if ($prop === $property) { |
||
| 244 | return true; |
||
| 245 | } |
||
| 246 | |||
| 247 | } |
||
| 248 | return false; |
||
| 249 | } |
||
| 250 | |||
| 251 | /** |
||
| 252 | * Returns a boolean value set in the vocabularies.ttl config. |
||
| 253 | * @return boolean |
||
| 254 | */ |
||
| 255 | public function getShowHierarchy() |
||
| 259 | |||
| 260 | /** |
||
| 261 | * Returns a boolean value set in the vocabularies.ttl config. |
||
| 262 | * @return boolean |
||
| 263 | */ |
||
| 264 | public function showConceptSchemesInHierarchy() |
||
| 268 | |||
| 269 | /** |
||
| 270 | * Returns a boolean value set in the vocabularies.ttl config. |
||
| 271 | * @return boolean defaults to true if fetching hasn't been explicitly denied. |
||
| 272 | */ |
||
| 273 | public function getExternalResourcesLoading() |
||
| 277 | |||
| 278 | /** |
||
| 279 | * Returns a boolean value set in the vocabularies.ttl config. |
||
| 280 | * @return boolean |
||
| 281 | */ |
||
| 282 | public function getShowLangCodes() |
||
| 286 | |||
| 287 | /** |
||
| 288 | * Returns a boolean value set in the vocabularies.ttl config. |
||
| 289 | * @return array array of concept class URIs (can be empty) |
||
| 290 | */ |
||
| 291 | public function getIndexClasses() |
||
| 300 | |||
| 301 | /** |
||
| 302 | * Get the languages supported by this vocabulary |
||
| 303 | * @return array languages supported by this vocabulary (as language tag strings) |
||
| 304 | */ |
||
| 305 | public function getLanguages() |
||
| 317 | |||
| 318 | /** |
||
| 319 | * Returns the vocabulary default sidebar view. |
||
| 320 | * @return string name of the view |
||
| 321 | */ |
||
| 322 | public function getDefaultSidebarView() |
||
| 334 | |||
| 335 | /** |
||
| 336 | * Extracts the vocabulary id string from the baseuri of the vocabulary. |
||
| 337 | * @return string identifier eg. 'mesh'. |
||
| 338 | */ |
||
| 339 | public function getId() |
||
| 353 | |||
| 354 | public function getShowStatistics() { |
||
| 357 | |||
| 358 | public function getPlugins() |
||
| 362 | |||
| 363 | /** |
||
| 364 | * Returns the property/properties used for visualizing concept hierarchies. |
||
| 365 | * @return string array class URI or null |
||
| 366 | */ |
||
| 367 | |||
| 368 | View Code Duplication | public function getHierarchyProperty() |
|
| 383 | } |
||
| 384 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.