Completed
Pull Request — master (#748)
by Dan Michael O.
02:49
created
model/ConceptProperty.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      * @param string $prop property type eg. 'rdf:type'.
22 22
      * @param string $label
23 23
      */
24
-    public function __construct($prop, $label, $super=null)
24
+    public function __construct($prop, $label, $super = null)
25 25
     {
26 26
         $this->prop = $prop;
27 27
         $this->label = $label;
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
      */
60 60
     public function getDescription()
61 61
     {
62
-        $helpprop = $this->prop . "_help";
62
+        $helpprop = $this->prop."_help";
63 63
 
64 64
         return gettext($helpprop); // can't use string constant, it'd be picked up by xgettext
65 65
     }
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
     public function addValue($value)
80 80
     {
81
-        $this->values[$value->getNotation() . $value->getLabel() . $value->getUri()] = $value;
81
+        $this->values[$value->getNotation().$value->getLabel().$value->getUri()] = $value;
82 82
         $this->is_sorted = false;
83 83
     }
84 84
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     {
87 87
         if (!empty($this->values)) {
88 88
             uksort($this->values, function($a, $b) {
89
-                return strcoll(strtolower($a),strtolower($b));
89
+                return strcoll(strtolower($a), strtolower($b));
90 90
             });
91 91
         }
92 92
         $this->is_sorted = true;
Please login to merge, or discard this patch.
model/VocabularyConfig.php 3 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
 {
8 8
     private $plugins;
9 9
 
10
-    public function __construct($resource, $globalPlugins=array())
10
+    public function __construct($resource, $globalPlugins = array())
11 11
     {
12 12
         $this->resource = $resource;
13 13
         $plugins = $this->resource->allLiterals('skosmos:usePlugin');
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
      * @param string $property the property to query
41 41
      * @param string $lang preferred language for the literal,
42 42
      */
43
-    private function getLiteral($property, $lang=null)
43
+    private function getLiteral($property, $lang = null)
44 44
     {
45 45
         if (!isset($lang)) {;
46 46
             $lang = $this->getEnvLang();
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $langs = $this->getLanguages();
73 73
         $deflang = reset($langs); // picking the first one from the list with reset since the keys are not numeric
74 74
         if (sizeof($langs) > 1) {
75
-            trigger_error("Default language for vocabulary '" . $this->getShortName() . "' unknown, choosing '$deflang'.", E_USER_WARNING);
75
+            trigger_error("Default language for vocabulary '".$this->getShortName()."' unknown, choosing '$deflang'.", E_USER_WARNING);
76 76
         }
77 77
 
78 78
         return $deflang;
Please login to merge, or discard this patch.
Braces   +18 added lines, -9 removed lines patch added patch discarded remove patch
@@ -53,8 +53,9 @@  discard block
 block discarded – undo
53 53
 
54 54
         // not found with selected language, try any language
55 55
         $literal = $this->resource->getLiteral($property);
56
-        if ($literal)
57
-          return $literal->getValue();
56
+        if ($literal) {
57
+                  return $literal->getValue();
58
+        }
58 59
     }
59 60
 
60 61
     /**
@@ -95,8 +96,9 @@  discard block
 block discarded – undo
95 96
     public function getShortName()
96 97
     {
97 98
         $shortname = $this->getLiteral('skosmos:shortName');
98
-        if ($shortname)
99
-          return $shortname;
99
+        if ($shortname) {
100
+                  return $shortname;
101
+        }
100 102
 
101 103
         // if no shortname exists fall back to the id
102 104
         return $this->getId();
@@ -231,10 +233,12 @@  discard block
 block discarded – undo
231 233
         $ret = array();
232 234
         foreach ($resources as $res) {
233 235
             $prop = $res->getURI();
234
-            if (EasyRdf\RdfNamespace::shorten($prop) !== null) // shortening property labels if possible
236
+            if (EasyRdf\RdfNamespace::shorten($prop) !== null) {
237
+              // shortening property labels if possible
235 238
             {
236 239
                 $prop = EasyRdf\RdfNamespace::shorten($prop);
237 240
             }
241
+            }
238 242
 
239 243
             $ret[] = $prop;
240 244
         }
@@ -251,10 +255,12 @@  discard block
 block discarded – undo
251 255
         $resources = $this->resource->allResources("skosmos:hasMultiLingualProperty");
252 256
         foreach ($resources as $res) {
253 257
             $prop = $res->getURI();
254
-            if (EasyRdf\RdfNamespace::shorten($prop) !== null) // shortening property labels if possible
258
+            if (EasyRdf\RdfNamespace::shorten($prop) !== null) {
259
+              // shortening property labels if possible
255 260
             {
256 261
                 $prop = EasyRdf\RdfNamespace::shorten($prop);
257 262
             }
263
+            }
258 264
 
259 265
             if ($prop === $property) {
260 266
                 return true;
@@ -362,11 +368,12 @@  discard block
 block discarded – undo
362 368
     public function getId()
363 369
     {
364 370
         $uriparts = explode("#", $this->resource->getURI());
365
-        if (count($uriparts) != 1)
366
-        // hash namespace
371
+        if (count($uriparts) != 1) {
372
+                // hash namespace
367 373
         {
368 374
             return $uriparts[1];
369 375
         }
376
+        }
370 377
 
371 378
         // slash namespace
372 379
         $uriparts = explode("/", $this->resource->getURI());
@@ -394,10 +401,12 @@  discard block
 block discarded – undo
394 401
         $ret = array();
395 402
         foreach ($resources as $res) {
396 403
             $prop = $res->getURI();
397
-            if (EasyRdf\RdfNamespace::shorten($prop) !== null) // prefixing if possible
404
+            if (EasyRdf\RdfNamespace::shorten($prop) !== null) {
405
+              // prefixing if possible
398 406
             {
399 407
                 $prop = EasyRdf\RdfNamespace::shorten($prop);
400 408
             }
409
+            }
401 410
 
402 411
             $ret[] = $prop;
403 412
         }
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
 
319 319
     /**
320 320
      * Returns a boolean value set in the vocabularies.ttl config.
321
-     * @return array array of concept class URIs (can be empty)
321
+     * @return string[] array of concept class URIs (can be empty)
322 322
      */
323 323
     public function getIndexClasses()
324 324
     {
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
 
328 328
     /**
329 329
      * Returns skosmos:externalProperty values set in the vocabularies.ttl config.
330
-     * @return array array of external property URIs (can be empty)
330
+     * @return string[] array of external property URIs (can be empty)
331 331
      */
332 332
     public function getExtProperties()
333 333
     {
@@ -473,7 +473,7 @@  discard block
 block discarded – undo
473 473
      * Additionally, the chosen content language is inserted with the highest priority
474 474
      * and the vocab default language is inserted with the lowest priority.
475 475
      * @param string $clang
476
-     * @return array of language code strings
476
+     * @return string[] of language code strings
477 477
      */
478 478
     public function getLanguageOrder($clang)
479 479
     {
Please login to merge, or discard this patch.
model/ConceptSearchParameters.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
         if ($this->rest) {
76 76
             return $term;
77 77
         }
78
-        return strpos($term, "*") === false ? $term . "*" : $term; // default to prefix search
78
+        return strpos($term, "*") === false ? $term."*" : $term; // default to prefix search
79 79
     }
80 80
 
81 81
     public function getContentLang()
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,8 +69,9 @@
 block discarded – undo
69 69
     public function getSearchTerm()
70 70
     {
71 71
         $term = $this->request->getQueryParamRaw('q') ? $this->request->getQueryParamRaw('q') : $this->request->getQueryParamRaw('query');
72
-        if (!$term && $this->rest)
73
-            $term = $this->request->getQueryParamRaw('label');
72
+        if (!$term && $this->rest) {
73
+                    $term = $this->request->getQueryParamRaw('label');
74
+        }
74 75
         $term = trim($term); // surrounding whitespace is not considered significant
75 76
         if ($this->rest) {
76 77
             return $term;
Please login to merge, or discard this patch.
controller/RestController.php 2 patches
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -400,7 +400,9 @@  discard block
 block discarded – undo
400 400
                 $hits[] = $res;
401 401
             }
402 402
         }
403
-        if (sizeof($hits) > 0) return $hits;
403
+        if (sizeof($hits) > 0) {
404
+          return $hits;
405
+        }
404 406
 
405 407
         // case 2: case-insensitive match on preferred label
406 408
         foreach ($results as $res) {
@@ -408,7 +410,9 @@  discard block
 block discarded – undo
408 410
                 $hits[] = $res;
409 411
             }
410 412
         }
411
-        if (sizeof($hits) > 0) return $hits;
413
+        if (sizeof($hits) > 0) {
414
+          return $hits;
415
+        }
412 416
 
413 417
         if ($lang === null) {
414 418
             // case 1A: exact match on preferred label in any language
@@ -419,7 +423,9 @@  discard block
 block discarded – undo
419 423
                     $hits[] = $res;
420 424
                 }
421 425
             }
422
-            if (sizeof($hits) > 0) return $hits;
426
+            if (sizeof($hits) > 0) {
427
+              return $hits;
428
+            }
423 429
 
424 430
             // case 2A: case-insensitive match on preferred label in any language
425 431
             foreach ($results as $res) {
@@ -429,7 +435,9 @@  discard block
 block discarded – undo
429 435
                     $hits[] = $res;
430 436
                 }
431 437
             }
432
-            if (sizeof($hits) > 0) return $hits;
438
+            if (sizeof($hits) > 0) {
439
+              return $hits;
440
+            }
433 441
         }
434 442
 
435 443
         // case 3: exact match on alternate label
@@ -438,7 +446,9 @@  discard block
 block discarded – undo
438 446
                 $hits[] = $res;
439 447
             }
440 448
         }
441
-        if (sizeof($hits) > 0) return $hits;
449
+        if (sizeof($hits) > 0) {
450
+          return $hits;
451
+        }
442 452
 
443 453
 
444 454
         // case 4: case-insensitive match on alternate label
@@ -447,7 +457,9 @@  discard block
 block discarded – undo
447 457
                 $hits[] = $res;
448 458
             }
449 459
         }
450
-        if (sizeof($hits) > 0) return $hits;
460
+        if (sizeof($hits) > 0) {
461
+          return $hits;
462
+        }
451 463
 
452 464
         return $hits;
453 465
     }
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         // wrap with JSONP callback if requested
26 26
         if (filter_input(INPUT_GET, 'callback', FILTER_SANITIZE_STRING)) {
27 27
             header("Content-type: application/javascript; charset=utf-8");
28
-            echo filter_input(INPUT_GET, 'callback', FILTER_UNSAFE_RAW) . "(" . json_encode($data) . ");";
28
+            echo filter_input(INPUT_GET, 'callback', FILTER_UNSAFE_RAW)."(".json_encode($data).");";
29 29
             return;
30 30
         }
31 31
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                 'vocabularies' => 'onki:hasVocabulary',
89 89
                 'id' => 'onki:vocabularyIdentifier',
90 90
                 'uri' => '@id',
91
-                '@base' => $this->getBaseHref() . "rest/v1/vocabularies",
91
+                '@base' => $this->getBaseHref()."rest/v1/vocabularies",
92 92
             ),
93 93
             'uri' => '',
94 94
             'vocabularies' => $results,
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
         // convert to vocids array to support multi-vocabulary search
106 106
         $vocids = ($vocabs !== null && $vocabs !== '') ? explode(' ', $vocabs) : array();
107 107
         $vocabObjects = array();
108
-        foreach($vocids as $vocid) {
108
+        foreach ($vocids as $vocid) {
109 109
             $vocabObjects[] = $this->model->getVocabulary($vocid);
110 110
         }
111 111
         $parameters->setVocabularies($vocabObjects);
@@ -136,12 +136,12 @@  discard block
 block discarded – undo
136 136
         foreach ($parameters->getAdditionalFields() as $field) {
137 137
 
138 138
             // Quick-and-dirty compactification
139
-            $context[$field] = 'skos:' . $field;
139
+            $context[$field] = 'skos:'.$field;
140 140
             foreach ($results as &$result) {
141 141
                 foreach ($result as $k => $v) {
142
-                    if ($k == 'skos:' . $field) {
142
+                    if ($k == 'skos:'.$field) {
143 143
                         $result[$field] = $v;
144
-                        unset($result['skos:' . $field]);
144
+                        unset($result['skos:'.$field]);
145 145
                     }
146 146
                 }
147 147
             }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
         if ($request->getQueryParam('labellang')) {
161 161
             $ret['@context']['@language'] = $request->getQueryParam('labellang');
162 162
         } elseif ($request->getQueryParam('lang')) {
163
-            $ret['@context']['@language'] = $request->getQueryParam('lang');;
163
+            $ret['@context']['@language'] = $request->getQueryParam('lang'); ;
164 164
         }
165 165
         return $ret;
166 166
     }
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
                 'prefLabel' => 'skos:prefLabel',
228 228
                 'title' => 'dct:title',
229 229
                 '@language' => $request->getLang(),
230
-                '@base' => $this->getBaseHref() . "rest/v1/" . $vocab->getId() . "/",
230
+                '@base' => $this->getBaseHref()."rest/v1/".$vocab->getId()."/",
231 231
             ),
232 232
             'uri' => '',
233 233
             'id' => $vocab->getId(),
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
                 'subTypes' => array('@id' => 'void:class', '@type' => '@id'),
278 278
                 'count' => 'void:entities',
279 279
                 '@language' => $request->getLang(),
280
-                '@base' => $this->getBaseHref() . "rest/v1/" . $request->getVocab()->getId() . "/",
280
+                '@base' => $this->getBaseHref()."rest/v1/".$request->getVocab()->getId()."/",
281 281
             ),
282 282
             'uri' => '',
283 283
             'id' => $request->getVocab()->getId(),
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
                 'language' => 'void-ext:language',
352 352
                 'properties' => 'void:propertyPartition',
353 353
                 'labels' => 'void:triples',
354
-                '@base' => $this->getBaseHref() . "rest/v1/" . $request->getVocab()->getId() . "/",
354
+                '@base' => $this->getBaseHref()."rest/v1/".$request->getVocab()->getId()."/",
355 355
             ),
356 356
             'uri' => '',
357 357
             'id' => $request->getVocab()->getId(),
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
             $types[] = $type;
389 389
         }
390 390
 
391
-        $base = $request->getVocab() ? $this->getBaseHref() . "rest/v1/" . $request->getVocab()->getId() . "/" : $this->getBaseHref() . "rest/v1/";
391
+        $base = $request->getVocab() ? $this->getBaseHref()."rest/v1/".$request->getVocab()->getId()."/" : $this->getBaseHref()."rest/v1/";
392 392
 
393 393
         $ret = array_merge_recursive($this->context, array(
394 394
             '@context' => array(
@@ -548,10 +548,10 @@  discard block
 block discarded – undo
548 548
 
549 549
         $format = $this->negotiateFormat(array_keys($urls), $request->getServerConstant('HTTP_ACCEPT'), $request->getQueryParam('format'));
550 550
         if (!$format) {
551
-            return $this->returnError(406, 'Not Acceptable', "Unsupported format. Supported MIME types are: " . implode(' ', array_keys($urls)));
551
+            return $this->returnError(406, 'Not Acceptable', "Unsupported format. Supported MIME types are: ".implode(' ', array_keys($urls)));
552 552
         }
553 553
 
554
-        header("Location: " . $urls[$format]);
554
+        header("Location: ".$urls[$format]);
555 555
     }
556 556
 
557 557
     private function returnDataResults($results, $format) {
@@ -610,7 +610,7 @@  discard block
 block discarded – undo
610 610
 
611 611
         $format = $this->negotiateFormat(explode(' ', self::SUPPORTED_FORMATS), $request->getServerConstant('HTTP_ACCEPT'), $request->getQueryParam('format'));
612 612
         if (!$format) {
613
-            return $this->returnError(406, 'Not Acceptable', "Unsupported format. Supported MIME types are: " . self::SUPPORTED_FORMATS);
613
+            return $this->returnError(406, 'Not Acceptable', "Unsupported format. Supported MIME types are: ".self::SUPPORTED_FORMATS);
614 614
         }
615 615
 
616 616
         $vocid = $vocab ? $vocab->getId() : null;
@@ -770,7 +770,7 @@  discard block
 block discarded – undo
770 770
                         }
771 771
                     }
772 772
                     // if the main concept scheme was not found, set 'top' to the first 'tops' (sorted alphabetically on the URIs)
773
-                    if (! isset($results[$uri]['top'])) {
773
+                    if (!isset($results[$uri]['top'])) {
774 774
                         $results[$uri]['top'] = $results[$uri]['tops'][0];
775 775
                     }
776 776
                 } else {
Please login to merge, or discard this patch.
model/PluginRegister.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 class PluginRegister {
4 4
     private $requestedPlugins;
5 5
 
6
-    public function __construct($requestedPlugins=array()) {
6
+    public function __construct($requestedPlugins = array()) {
7 7
         $this->requestedPlugins = $requestedPlugins;
8 8
     }
9 9
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
      * @param boolean $raw interpret $type values as raw text instead of files
32 32
      * @return array
33 33
      */
34
-    private function filterPlugins($type, $raw=false) {
34
+    private function filterPlugins($type, $raw = false) {
35 35
         $plugins = $this->getPlugins();
36 36
         $ret = array();
37 37
         if (!empty($plugins)) {
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
                     }
44 44
                     else {
45 45
                         foreach ($files[$type] as $file) {
46
-                            array_push($ret[$name], 'plugins/' . $name . '/' . $file);
46
+                            array_push($ret[$name], 'plugins/'.$name.'/'.$file);
47 47
                         }
48 48
                     }
49 49
                 }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      * @param array $names the plugin name strings (foldernames) in an array
75 75
      * @return array
76 76
      */
77
-    public function getPluginsJS($names=null) {
77
+    public function getPluginsJS($names = null) {
78 78
         if ($names) {
79 79
             $names = array_merge($this->requestedPlugins, $names);
80 80
             return $this->filterPluginsByName('js', $names);
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      * @param array $names the plugin name strings (foldernames) in an array
88 88
      * @return array
89 89
      */
90
-    public function getPluginsCSS($names=null) {
90
+    public function getPluginsCSS($names = null) {
91 91
         if ($names) {
92 92
             $names = array_merge($this->requestedPlugins, $names);
93 93
             return $this->filterPluginsByName('css', $names);
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      * @param array $names the plugin name strings (foldernames) in an array
101 101
      * @return array
102 102
      */
103
-    public function getPluginsTemplates($names=null) {
103
+    public function getPluginsTemplates($names = null) {
104 104
         if ($names) {
105 105
             $names = array_merge($this->requestedPlugins, $names);
106 106
             return $this->filterPluginsByName('templates', $names);
@@ -113,15 +113,15 @@  discard block
 block discarded – undo
113 113
      * @param array $names the plugin name strings (foldernames) in an array
114 114
      * @return array
115 115
      */
116
-    public function getTemplates($names=null) {
116
+    public function getTemplates($names = null) {
117 117
         $templateStrings = array();
118 118
         $plugins = $this->getPluginsTemplates($names);
119 119
         foreach ($plugins as $folder => $templates) {
120 120
             foreach ($templates as $path) {
121 121
                 if (file_exists($path)) {
122 122
                     $filename = explode('/', $path);
123
-                    $filename = $filename[sizeof($filename)-1];
124
-                    $id = $folder . '-' . substr($filename, 0 , (strrpos($filename, ".")));
123
+                    $filename = $filename[sizeof($filename) - 1];
124
+                    $id = $folder.'-'.substr($filename, 0, (strrpos($filename, ".")));
125 125
                     $templateStrings[$id] = file_get_contents($path);
126 126
                 }
127 127
             }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,8 +40,7 @@
 block discarded – undo
40 40
                     $ret[$name] = array();
41 41
                     if ($raw) {
42 42
                         $ret[$name] = $files[$type];
43
-                    }
44
-                    else {
43
+                    } else {
45 44
                         foreach ($files[$type] as $file) {
46 45
                             array_push($ret[$name], 'plugins/' . $name . '/' . $file);
47 46
                         }
Please login to merge, or discard this patch.
model/Cache.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     /**
20 20
      * Wraps apc_store() and apcu_store()
21 21
      */
22
-    public function store($key, $value, $ttl=3600) {
22
+    public function store($key, $value, $ttl = 3600) {
23 23
         if (function_exists('apcu_store')) {
24 24
             return apcu_store($key, $value, $ttl);
25 25
         }
Please login to merge, or discard this patch.