Completed
Pull Request — master (#992)
by Osma
01:52
created
model/ConceptSearchParameters.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
         if ($this->rest) {
76 76
             return $term;
77 77
         }
78
-        return strpos($term, "*") === false ? $term . "*" : $term; // default to prefix search
78
+        return strpos($term, "*") === false ? $term."*" : $term; // default to prefix search
79 79
     }
80 80
 
81 81
     public function getContentLang()
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,8 +69,9 @@
 block discarded – undo
69 69
     public function getSearchTerm()
70 70
     {
71 71
         $term = $this->request->getQueryParamRaw('q') ? $this->request->getQueryParamRaw('q') : $this->request->getQueryParamRaw('query');
72
-        if (!$term && $this->rest)
73
-            $term = $this->request->getQueryParamRaw('label');
72
+        if (!$term && $this->rest) {
73
+                    $term = $this->request->getQueryParamRaw('label');
74
+        }
74 75
         $term = trim($term); // surrounding whitespace is not considered significant
75 76
         if ($this->rest) {
76 77
             return $term;
Please login to merge, or discard this patch.
controller/RestController.php 4 patches
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -400,7 +400,9 @@  discard block
 block discarded – undo
400 400
                 $hits[] = $res;
401 401
             }
402 402
         }
403
-        if (sizeof($hits) > 0) return $hits;
403
+        if (sizeof($hits) > 0) {
404
+          return $hits;
405
+        }
404 406
 
405 407
         // case 2: case-insensitive match on preferred label
406 408
         foreach ($results as $res) {
@@ -408,7 +410,9 @@  discard block
 block discarded – undo
408 410
                 $hits[] = $res;
409 411
             }
410 412
         }
411
-        if (sizeof($hits) > 0) return $hits;
413
+        if (sizeof($hits) > 0) {
414
+          return $hits;
415
+        }
412 416
 
413 417
         if ($lang === null) {
414 418
             // case 1A: exact match on preferred label in any language
@@ -419,7 +423,9 @@  discard block
 block discarded – undo
419 423
                     $hits[] = $res;
420 424
                 }
421 425
             }
422
-            if (sizeof($hits) > 0) return $hits;
426
+            if (sizeof($hits) > 0) {
427
+              return $hits;
428
+            }
423 429
 
424 430
             // case 2A: case-insensitive match on preferred label in any language
425 431
             foreach ($results as $res) {
@@ -429,7 +435,9 @@  discard block
 block discarded – undo
429 435
                     $hits[] = $res;
430 436
                 }
431 437
             }
432
-            if (sizeof($hits) > 0) return $hits;
438
+            if (sizeof($hits) > 0) {
439
+              return $hits;
440
+            }
433 441
         }
434 442
 
435 443
         // case 3: exact match on alternate label
@@ -438,7 +446,9 @@  discard block
 block discarded – undo
438 446
                 $hits[] = $res;
439 447
             }
440 448
         }
441
-        if (sizeof($hits) > 0) return $hits;
449
+        if (sizeof($hits) > 0) {
450
+          return $hits;
451
+        }
442 452
 
443 453
 
444 454
         // case 4: case-insensitive match on alternate label
@@ -447,7 +457,9 @@  discard block
 block discarded – undo
447 457
                 $hits[] = $res;
448 458
             }
449 459
         }
450
-        if (sizeof($hits) > 0) return $hits;
460
+        if (sizeof($hits) > 0) {
461
+          return $hits;
462
+        }
451 463
 
452 464
         return $hits;
453 465
     }
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -559,9 +559,9 @@
 block discarded – undo
559 559
                 $vocid = $request->getVocab()->getId();
560 560
                 return $this->returnError('404', 'Not Found', "No download source URL known for vocabulary $vocid in language $dataLang");
561 561
             }
562
-		} else {
562
+    } else {
563 563
             header("Location: " . $urls[$format]);
564
-		}
564
+    }
565 565
     }
566 566
 
567 567
     private function returnDataResults($results, $format) {
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         // wrap with JSONP callback if requested
26 26
         if (filter_input(INPUT_GET, 'callback', FILTER_SANITIZE_STRING)) {
27 27
             header("Content-type: application/javascript; charset=utf-8");
28
-            echo filter_input(INPUT_GET, 'callback', FILTER_UNSAFE_RAW) . "(" . json_encode($data) . ");";
28
+            echo filter_input(INPUT_GET, 'callback', FILTER_UNSAFE_RAW)."(".json_encode($data).");";
29 29
             return;
30 30
         }
31 31
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                 'vocabularies' => 'onki:hasVocabulary',
89 89
                 'id' => 'onki:vocabularyIdentifier',
90 90
                 'uri' => '@id',
91
-                '@base' => $this->getBaseHref() . "rest/v1/vocabularies",
91
+                '@base' => $this->getBaseHref()."rest/v1/vocabularies",
92 92
             ),
93 93
             'uri' => '',
94 94
             'vocabularies' => $results,
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
         // convert to vocids array to support multi-vocabulary search
106 106
         $vocids = ($vocabs !== null && $vocabs !== '') ? explode(' ', $vocabs) : array();
107 107
         $vocabObjects = array();
108
-        foreach($vocids as $vocid) {
108
+        foreach ($vocids as $vocid) {
109 109
             $vocabObjects[] = $this->model->getVocabulary($vocid);
110 110
         }
111 111
         $parameters->setVocabularies($vocabObjects);
@@ -136,12 +136,12 @@  discard block
 block discarded – undo
136 136
         foreach ($parameters->getAdditionalFields() as $field) {
137 137
 
138 138
             // Quick-and-dirty compactification
139
-            $context[$field] = 'skos:' . $field;
139
+            $context[$field] = 'skos:'.$field;
140 140
             foreach ($results as &$result) {
141 141
                 foreach ($result as $k => $v) {
142
-                    if ($k == 'skos:' . $field) {
142
+                    if ($k == 'skos:'.$field) {
143 143
                         $result[$field] = $v;
144
-                        unset($result['skos:' . $field]);
144
+                        unset($result['skos:'.$field]);
145 145
                     }
146 146
                 }
147 147
             }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
         if ($request->getQueryParam('labellang')) {
161 161
             $ret['@context']['@language'] = $request->getQueryParam('labellang');
162 162
         } elseif ($request->getQueryParam('lang')) {
163
-            $ret['@context']['@language'] = $request->getQueryParam('lang');;
163
+            $ret['@context']['@language'] = $request->getQueryParam('lang'); ;
164 164
         }
165 165
         return $ret;
166 166
     }
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
                 'prefLabel' => 'skos:prefLabel',
227 227
                 'title' => 'dct:title',
228 228
                 '@language' => $request->getLang(),
229
-                '@base' => $this->getBaseHref() . "rest/v1/" . $vocab->getId() . "/",
229
+                '@base' => $this->getBaseHref()."rest/v1/".$vocab->getId()."/",
230 230
             ),
231 231
             'uri' => '',
232 232
             'id' => $vocab->getId(),
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
                 'subTypes' => array('@id' => 'void:class', '@type' => '@id'),
278 278
                 'count' => 'void:entities',
279 279
                 '@language' => $request->getLang(),
280
-                '@base' => $this->getBaseHref() . "rest/v1/" . $request->getVocab()->getId() . "/",
280
+                '@base' => $this->getBaseHref()."rest/v1/".$request->getVocab()->getId()."/",
281 281
             ),
282 282
             'uri' => '',
283 283
             'id' => $request->getVocab()->getId(),
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
                 'language' => 'void-ext:language',
352 352
                 'properties' => 'void:propertyPartition',
353 353
                 'labels' => 'void:triples',
354
-                '@base' => $this->getBaseHref() . "rest/v1/" . $request->getVocab()->getId() . "/",
354
+                '@base' => $this->getBaseHref()."rest/v1/".$request->getVocab()->getId()."/",
355 355
             ),
356 356
             'uri' => '',
357 357
             'id' => $request->getVocab()->getId(),
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
             $types[] = $type;
389 389
         }
390 390
 
391
-        $base = $request->getVocab() ? $this->getBaseHref() . "rest/v1/" . $request->getVocab()->getId() . "/" : $this->getBaseHref() . "rest/v1/";
391
+        $base = $request->getVocab() ? $this->getBaseHref()."rest/v1/".$request->getVocab()->getId()."/" : $this->getBaseHref()."rest/v1/";
392 392
 
393 393
         $ret = array_merge_recursive($this->context, array(
394 394
             '@context' => array(
@@ -548,19 +548,19 @@  discard block
 block discarded – undo
548 548
 
549 549
         $format = $this->negotiateFormat(array_keys($urls), $request->getServerConstant('HTTP_ACCEPT'), $request->getQueryParam('format'));
550 550
         if (!$format) {
551
-            return $this->returnError(406, 'Not Acceptable', "Unsupported format. Supported MIME types are: " . implode(' ', array_keys($urls)));
551
+            return $this->returnError(406, 'Not Acceptable', "Unsupported format. Supported MIME types are: ".implode(' ', array_keys($urls)));
552 552
         }
553 553
         if (is_array($urls[$format])) {
554 554
             $arr = $urls[$format];
555 555
             $dataLang = $request->getLang();
556 556
             if (isset($arr[$dataLang])) {
557
-                header("Location: " . $arr[$dataLang]);
557
+                header("Location: ".$arr[$dataLang]);
558 558
             } else {
559 559
                 $vocid = $request->getVocab()->getId();
560 560
                 return $this->returnError('404', 'Not Found', "No download source URL known for vocabulary $vocid in language $dataLang");
561 561
             }
562 562
 		} else {
563
-            header("Location: " . $urls[$format]);
563
+            header("Location: ".$urls[$format]);
564 564
 		}
565 565
     }
566 566
 
@@ -620,7 +620,7 @@  discard block
 block discarded – undo
620 620
 
621 621
         $format = $this->negotiateFormat(explode(' ', self::SUPPORTED_FORMATS), $request->getServerConstant('HTTP_ACCEPT'), $request->getQueryParam('format'));
622 622
         if (!$format) {
623
-            return $this->returnError(406, 'Not Acceptable', "Unsupported format. Supported MIME types are: " . self::SUPPORTED_FORMATS);
623
+            return $this->returnError(406, 'Not Acceptable', "Unsupported format. Supported MIME types are: ".self::SUPPORTED_FORMATS);
624 624
         }
625 625
 
626 626
         $vocid = $vocab ? $vocab->getId() : null;
@@ -814,7 +814,7 @@  discard block
 block discarded – undo
814 814
                         }
815 815
                     }
816 816
                     // if the main concept scheme was not found, set 'top' to the first 'tops' (sorted alphabetically on the URIs)
817
-                    if (! isset($results[$uri]['top'])) {
817
+                    if (!isset($results[$uri]['top'])) {
818 818
                         $results[$uri]['top'] = $results[$uri]['tops'][0];
819 819
                     }
820 820
                 } else {
Please login to merge, or discard this patch.
Doc Comments   +35 added lines patch added patch discarded remove patch
@@ -97,6 +97,9 @@  discard block
 block discarded – undo
97 97
         return $this->returnJson($ret);
98 98
     }
99 99
 
100
+    /**
101
+     * @param Request $request
102
+     */
100 103
     private function constructSearchParameters($request)
101 104
     {
102 105
         $parameters = new ConceptSearchParameters($request, $this->model->getConfig(), true);
@@ -112,6 +115,10 @@  discard block
 block discarded – undo
112 115
         return $parameters;
113 116
     }
114 117
 
118
+    /**
119
+     * @param Request $request
120
+     * @param ConceptSearchParameters $parameters
121
+     */
115 122
     private function transformSearchResults($request, $results, $parameters)
116 123
     {
117 124
         // before serializing to JSON, get rid of the Vocabulary object that came with each resource
@@ -407,6 +414,10 @@  discard block
 block discarded – undo
407 414
         return $this->returnJson($ret);
408 415
     }
409 416
 
417
+    /**
418
+     * @param string $label
419
+     * @param string $lang
420
+     */
410 421
     private function findLookupHits($results, $label, $lang)
411 422
     {
412 423
         $hits = array();
@@ -468,6 +479,9 @@  discard block
 block discarded – undo
468 479
         return $hits;
469 480
     }
470 481
 
482
+    /**
483
+     * @param string $lang
484
+     */
471 485
     private function transformLookupResults($lang, $hits)
472 486
     {
473 487
         if (sizeof($hits) == 0) {
@@ -539,6 +553,9 @@  discard block
 block discarded – undo
539 553
         return $this->returnJson($ret);
540 554
     }
541 555
 
556
+    /**
557
+     * @param Request $request
558
+     */
542 559
     private function redirectToVocabData($request) {
543 560
         $urls = $request->getVocab()->getConfig()->getDataURLs();
544 561
         if (sizeof($urls) == 0) {
@@ -564,6 +581,10 @@  discard block
 block discarded – undo
564 581
 		}
565 582
     }
566 583
 
584
+    /**
585
+     * @param string $results
586
+     * @param string $format
587
+     */
567 588
     private function returnDataResults($results, $format) {
568 589
         if ($format == 'application/ld+json' || $format == 'application/json') {
569 590
             // further compact JSON-LD document using a context
@@ -700,6 +721,12 @@  discard block
 block discarded – undo
700 721
         return $this->returnJson($ret);
701 722
     }
702 723
 
724
+    /**
725
+     * @param string $uri
726
+     * @param string $lang
727
+     * @param string $propname
728
+     * @param string $propuri
729
+     */
703 730
     private function transformPropertyResults($uri, $lang, $objects, $propname, $propuri)
704 731
     {
705 732
         $results = array();
@@ -714,6 +741,14 @@  discard block
 block discarded – undo
714 741
         );
715 742
     }
716 743
 
744
+    /**
745
+     * @param string $uri
746
+     * @param string $lang
747
+     * @param string $tpropname
748
+     * @param string $tpropuri
749
+     * @param string $dpropname
750
+     * @param string $dpropuri
751
+     */
717 752
     private function transformTransitivePropertyResults($uri, $lang, $objects, $tpropname, $tpropuri, $dpropname, $dpropuri)
718 753
     {
719 754
         $results = array();
Please login to merge, or discard this patch.
model/PluginRegister.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 class PluginRegister {
4 4
     private $requestedPlugins;
5 5
 
6
-    public function __construct($requestedPlugins=array()) {
6
+    public function __construct($requestedPlugins = array()) {
7 7
         $this->requestedPlugins = $requestedPlugins;
8 8
     }
9 9
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
      * @param boolean $raw interpret $type values as raw text instead of files
32 32
      * @return array
33 33
      */
34
-    private function filterPlugins($type, $raw=false) {
34
+    private function filterPlugins($type, $raw = false) {
35 35
         $plugins = $this->getPlugins();
36 36
         $ret = array();
37 37
         if (!empty($plugins)) {
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
                     }
44 44
                     else {
45 45
                         foreach ($files[$type] as $file) {
46
-                            array_push($ret[$name], 'plugins/' . $name . '/' . $file);
46
+                            array_push($ret[$name], 'plugins/'.$name.'/'.$file);
47 47
                         }
48 48
                     }
49 49
                 }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      * @param array $names the plugin name strings (foldernames) in an array
75 75
      * @return array
76 76
      */
77
-    public function getPluginsJS($names=null) {
77
+    public function getPluginsJS($names = null) {
78 78
         if ($names) {
79 79
             $names = array_merge($this->requestedPlugins, $names);
80 80
             return $this->filterPluginsByName('js', $names);
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      * @param array $names the plugin name strings (foldernames) in an array
88 88
      * @return array
89 89
      */
90
-    public function getPluginsCSS($names=null) {
90
+    public function getPluginsCSS($names = null) {
91 91
         if ($names) {
92 92
             $names = array_merge($this->requestedPlugins, $names);
93 93
             return $this->filterPluginsByName('css', $names);
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      * @param array $names the plugin name strings (foldernames) in an array
101 101
      * @return array
102 102
      */
103
-    public function getPluginsTemplates($names=null) {
103
+    public function getPluginsTemplates($names = null) {
104 104
         if ($names) {
105 105
             $names = array_merge($this->requestedPlugins, $names);
106 106
             return $this->filterPluginsByName('templates', $names);
@@ -113,15 +113,15 @@  discard block
 block discarded – undo
113 113
      * @param array $names the plugin name strings (foldernames) in an array
114 114
      * @return array
115 115
      */
116
-    public function getTemplates($names=null) {
116
+    public function getTemplates($names = null) {
117 117
         $templateStrings = array();
118 118
         $plugins = $this->getPluginsTemplates($names);
119 119
         foreach ($plugins as $folder => $templates) {
120 120
             foreach ($templates as $path) {
121 121
                 if (file_exists($path)) {
122 122
                     $filename = explode('/', $path);
123
-                    $filename = $filename[sizeof($filename)-1];
124
-                    $id = $folder . '-' . substr($filename, 0 , (strrpos($filename, ".")));
123
+                    $filename = $filename[sizeof($filename) - 1];
124
+                    $id = $folder.'-'.substr($filename, 0, (strrpos($filename, ".")));
125 125
                     $templateStrings[$id] = file_get_contents($path);
126 126
                 }
127 127
             }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,8 +40,7 @@
 block discarded – undo
40 40
                     $ret[$name] = array();
41 41
                     if ($raw) {
42 42
                         $ret[$name] = $files[$type];
43
-                    }
44
-                    else {
43
+                    } else {
45 44
                         foreach ($files[$type] as $file) {
46 45
                             array_push($ret[$name], 'plugins/' . $name . '/' . $file);
47 46
                         }
Please login to merge, or discard this patch.
model/Cache.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     /**
20 20
      * Wraps apc_store() and apcu_store()
21 21
      */
22
-    public function store($key, $value, $ttl=3600) {
22
+    public function store($key, $value, $ttl = 3600) {
23 23
         if (function_exists('apcu_store')) {
24 24
             return apcu_store($key, $value, $ttl);
25 25
         }
Please login to merge, or discard this patch.
controller/WebController.php 3 patches
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -307,11 +307,17 @@
 block discarded – undo
307 307
         $subject = $this->model->getConfig()->getServiceName() . " feedback";
308 308
         // determine the sender address of the message
309 309
         $sender = $this->model->getConfig()->getFeedbackSender();
310
-        if (empty($sender)) $sender = $envelopeSender;
311
-        if (empty($sender)) $sender = $this->model->getConfig()->getFeedbackAddress();
310
+        if (empty($sender)) {
311
+          $sender = $envelopeSender;
312
+        }
313
+        if (empty($sender)) {
314
+          $sender = $this->model->getConfig()->getFeedbackAddress();
315
+        }
312 316
 
313 317
         // determine sender name - default to "anonymous user" if not given by user
314
-        if (empty($fromName)) $fromName = "anonymous user";
318
+        if (empty($fromName)) {
319
+          $fromName = "anonymous user";
320
+        }
315 321
 
316 322
         $headers = $this->createFeedbackHeaders($fromName, $fromEmail, $toMail, $sender);
317 323
         $params = empty($envelopeSender) ? '' : "-f $envelopeSender";
Please login to merge, or discard this patch.
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         // specify where to look for templates and cache
43 43
         $loader = new Twig_Loader_Filesystem('view');
44 44
         // initialize Twig environment
45
-        $this->twig = new Twig_Environment($loader, array('cache' => $tmpDir,'auto_reload' => true));
45
+        $this->twig = new Twig_Environment($loader, array('cache' => $tmpDir, 'auto_reload' => true));
46 46
         $this->twig->addExtension(new Twig_Extensions_Extension_I18n());
47 47
         // used for setting the base href for the relative urls
48 48
         $this->twig->addGlobal("BaseHref", $this->getBaseHref());
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $this->twig->addFilter(new Twig_SimpleFilter('link_url', array($this, 'linkUrlFilter')));
66 66
 
67 67
         // register a Twig filter for generating strings from language codes with CLDR
68
-        $langFilter = new Twig_SimpleFilter('lang_name', function ($langcode, $lang) {
68
+        $langFilter = new Twig_SimpleFilter('lang_name', function($langcode, $lang) {
69 69
             return Language::getName($langcode, $lang);
70 70
         });
71 71
         $this->twig->addFilter($langFilter);
@@ -363,17 +363,17 @@  discard block
 block discarded – undo
363 363
 
364 364
     private function createFeedbackHeaders($fromName, $fromEmail, $toMail, $sender)
365 365
     {
366
-        $headers = "MIME-Version: 1.0" . "\r\n";
367
-        $headers .= "Content-type: text/html; charset=UTF-8" . "\r\n";
366
+        $headers = "MIME-Version: 1.0"."\r\n";
367
+        $headers .= "Content-type: text/html; charset=UTF-8"."\r\n";
368 368
         if (!empty($toMail)) {
369
-            $headers .= "Cc: " . $this->model->getConfig()->getFeedbackAddress() . "\r\n";
369
+            $headers .= "Cc: ".$this->model->getConfig()->getFeedbackAddress()."\r\n";
370 370
         }
371 371
         if (!empty($fromEmail)) {
372 372
             $headers .= "Reply-To: $fromName <$fromEmail>\r\n";
373 373
         }
374 374
 
375 375
         $service = $this->model->getConfig()->getServiceName();
376
-        return $headers . "From: $fromName via $service <$sender>";
376
+        return $headers."From: $fromName via $service <$sender>";
377 377
     }
378 378
 
379 379
     /**
@@ -387,11 +387,11 @@  discard block
 block discarded – undo
387 387
     {
388 388
         $toAddress = ($toMail) ? $toMail : $this->model->getConfig()->getFeedbackAddress();
389 389
         if ($fromVocab !== null && $fromVocab !== '') {
390
-            $message = 'Feedback from vocab: ' . strtoupper($fromVocab) . "<br />" . $message;
390
+            $message = 'Feedback from vocab: '.strtoupper($fromVocab)."<br />".$message;
391 391
         }
392 392
 
393 393
         $envelopeSender = $this->model->getConfig()->getFeedbackEnvelopeSender();
394
-        $subject = $this->model->getConfig()->getServiceName() . " feedback";
394
+        $subject = $this->model->getConfig()->getServiceName()." feedback";
395 395
         // determine the sender address of the message
396 396
         $sender = $this->model->getConfig()->getFeedbackSender();
397 397
         if (empty($sender)) $sender = $envelopeSender;
@@ -404,10 +404,10 @@  discard block
 block discarded – undo
404 404
         $params = empty($envelopeSender) ? '' : "-f $envelopeSender";
405 405
 
406 406
         // adding some information about the user for debugging purposes.
407
-        $message = $message . "<br /><br /> Debugging information:"
408
-            . "<br />Timestamp: " . date(DATE_RFC2822)
409
-            . "<br />User agent: " . $request->getServerConstant('HTTP_USER_AGENT')
410
-            . "<br />Referer: " . $request->getServerConstant('HTTP_REFERER');
407
+        $message = $message."<br /><br /> Debugging information:"
408
+            . "<br />Timestamp: ".date(DATE_RFC2822)
409
+            . "<br />User agent: ".$request->getServerConstant('HTTP_USER_AGENT')
410
+            . "<br />Referer: ".$request->getServerConstant('HTTP_REFERER');
411 411
 
412 412
         try {
413 413
             mail($toAddress, $subject, $message, $headers, $params);
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
             header("HTTP/1.0 404 Not Found");
416 416
             $template = $this->twig->loadTemplate('error-page.twig');
417 417
             if ($this->model->getConfig()->getLogCaughtExceptions()) {
418
-                error_log('Caught exception: ' . $e->getMessage());
418
+                error_log('Caught exception: '.$e->getMessage());
419 419
             }
420 420
 
421 421
             echo $template->render(
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
         $vocids = ($vocabs !== null && $vocabs !== '') ? explode(' ', $vocabs) : null;
463 463
         $vocabObjects = array();
464 464
         if ($vocids) {
465
-            foreach($vocids as $vocid) {
465
+            foreach ($vocids as $vocid) {
466 466
                 $vocabObjects[] = $this->model->getVocabulary($vocid);
467 467
             }
468 468
         }
@@ -473,7 +473,7 @@  discard block
 block discarded – undo
473 473
         } catch (Exception $e) {
474 474
             header("HTTP/1.0 404 Not Found");
475 475
             if ($this->model->getConfig()->getLogCaughtExceptions()) {
476
-                error_log('Caught exception: ' . $e->getMessage());
476
+                error_log('Caught exception: '.$e->getMessage());
477 477
             }
478 478
             $this->invokeGenericErrorPage($request, $e->getMessage());
479 479
             return;
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
                 'search_count' => $counts,
490 490
                 'languages' => $this->languages,
491 491
                 'search_results' => $searchResults,
492
-                'rest' => $parameters->getOffset()>0,
492
+                'rest' => $parameters->getOffset() > 0,
493 493
                 'global_search' => true,
494 494
                 'term' => $request->getQueryParamRaw('q'),
495 495
                 'lang_list' => $langList,
@@ -514,7 +514,7 @@  discard block
 block discarded – undo
514 514
         } catch (Exception $e) {
515 515
             header("HTTP/1.0 404 Not Found");
516 516
             if ($this->model->getConfig()->getLogCaughtExceptions()) {
517
-                error_log('Caught exception: ' . $e->getMessage());
517
+                error_log('Caught exception: '.$e->getMessage());
518 518
             }
519 519
 
520 520
             echo $template->render(
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
535 535
         } catch (Exception $e) {
536 536
             header("HTTP/1.0 404 Not Found");
537 537
             if ($this->model->getConfig()->getLogCaughtExceptions()) {
538
-                error_log('Caught exception: ' . $e->getMessage());
538
+                error_log('Caught exception: '.$e->getMessage());
539 539
             }
540 540
 
541 541
             echo $template->render(
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
                 'vocab' => $vocab,
553 553
                 'search_results' => $searchResults,
554 554
                 'search_count' => $counts,
555
-                'rest' => $parameters->getOffset()>0,
555
+                'rest' => $parameters->getOffset() > 0,
556 556
                 'limit_parent' => $parameters->getParentLimit(),
557 557
                 'limit_type' =>  $request->getQueryParam('type') ? explode('+', $request->getQueryParam('type')) : null,
558 558
                 'limit_group' => $parameters->getGroupLimit(),
@@ -681,7 +681,7 @@  discard block
 block discarded – undo
681 681
      * Loads and renders the view containing a list of recent changes in the vocabulary.
682 682
      * @param Request $request
683 683
      */
684
-    public function invokeChangeList($request, $prop='dc:created')
684
+    public function invokeChangeList($request, $prop = 'dc:created')
685 685
     {
686 686
         // set language parameters for gettext
687 687
         $this->setLanguageProperties($request->getLang());
Please login to merge, or discard this patch.
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -235,6 +235,11 @@  discard block
 block discarded – undo
235 235
             ));
236 236
     }
237 237
 
238
+    /**
239
+     * @param string $fromName
240
+     * @param string|null $fromEmail
241
+     * @param string $sender
242
+     */
238 243
     private function createFeedbackHeaders($fromName, $fromEmail, $toMail, $sender)
239 244
     {
240 245
         $headers = "MIME-Version: 1.0" . "\r\n";
@@ -256,6 +261,7 @@  discard block
 block discarded – undo
256 261
      * @param string $fromName senders own name.
257 262
      * @param string $fromEmail senders email address.
258 263
      * @param string $fromVocab which vocabulary is the feedback related to.
264
+     * @param string $toMail
259 265
      */
260 266
     public function sendFeedback($request, $message, $fromName = null, $fromEmail = null, $fromVocab = null, $toMail = null)
261 267
     {
@@ -538,6 +544,7 @@  discard block
 block discarded – undo
538 544
 
539 545
     /**
540 546
      * Invokes a very generic errorpage.
547
+     * @param string $message
541 548
      */
542 549
     public function invokeGenericErrorPage($request, $message = null)
543 550
     {
Please login to merge, or discard this patch.
model/GlobalConfig.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,10 +109,12 @@
 block discarded – undo
109 109
      */
110 110
     private function initializeNamespaces() {
111 111
         foreach ($this->namespaces as $prefix => $fullUri) {
112
-            if ($prefix != '' && EasyRdf\RdfNamespace::get($prefix) === null) // if not already defined
112
+            if ($prefix != '' && EasyRdf\RdfNamespace::get($prefix) === null) {
113
+              // if not already defined
113 114
             {
114 115
                 EasyRdf\RdfNamespace::set($prefix, $fullUri);
115 116
             }
117
+            }
116 118
         }
117 119
     }
118 120
 
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -28,17 +28,17 @@  discard block
 block discarded – undo
28 28
      */
29 29
     private $configModifiedTime = null;
30 30
 
31
-    public function __construct($config_name='/../config.ttl')
31
+    public function __construct($config_name = '/../config.ttl')
32 32
     {
33 33
         $this->cache = new Cache();
34 34
         try {
35
-            $this->filePath = realpath( dirname(__FILE__) . $config_name );
35
+            $this->filePath = realpath(dirname(__FILE__).$config_name);
36 36
             if (!file_exists($this->filePath)) {
37 37
                 throw new Exception('config.ttl file is missing, please provide one.');
38 38
             }
39 39
             $this->initializeConfig();
40 40
         } catch (Exception $e) {
41
-            echo "Error: " . $e->getMessage();
41
+            echo "Error: ".$e->getMessage();
42 42
             return;
43 43
         }
44 44
     }
@@ -72,8 +72,8 @@  discard block
 block discarded – undo
72 72
             // use APC user cache to store parsed config.ttl configuration
73 73
             if ($this->cache->isAvailable() && !is_null($this->configModifiedTime)) {
74 74
                 // @codeCoverageIgnoreStart
75
-                $key = realpath($this->filePath) . ", " . $this->configModifiedTime;
76
-                $nskey = "namespaces of " . $key;
75
+                $key = realpath($this->filePath).", ".$this->configModifiedTime;
76
+                $nskey = "namespaces of ".$key;
77 77
                 $this->graph = $this->cache->fetch($key);
78 78
                 $this->namespaces = $this->cache->fetch($nskey);
79 79
                 if ($this->graph === false || $this->namespaces === false) { // was not found in cache
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
             $this->resource = $configResources[0];
95 95
             $this->initializeNamespaces();
96 96
         } catch (Exception $e) {
97
-            echo "Error: " . $e->getMessage();
97
+            echo "Error: ".$e->getMessage();
98 98
         }      
99 99
     }
100 100
 
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
     public function getGlobalPlugins()
325 325
     {
326 326
         $globalPlugins = array();
327
-        $globalPluginsResource =  $this->getResource()->getResource("skosmos:globalPlugins");
327
+        $globalPluginsResource = $this->getResource()->getResource("skosmos:globalPlugins");
328 328
         if ($globalPluginsResource) {
329 329
             foreach ($globalPluginsResource as $resource) {
330 330
                 $globalPlugins[] = $resource->getValue();
Please login to merge, or discard this patch.
model/Model.php 2 patches
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -350,10 +350,12 @@  discard block
 block discarded – undo
350 350
                 // register vocabulary ids as RDF namespace prefixes
351 351
                 $prefix = preg_replace('/\W+/', '', $voc->getId()); // strip non-word characters
352 352
                 try {
353
-                    if ($prefix != '' && EasyRdf\RdfNamespace::get($prefix) === null) // if not already defined
353
+                    if ($prefix != '' && EasyRdf\RdfNamespace::get($prefix) === null) {
354
+                      // if not already defined
354 355
                     {
355 356
                         EasyRdf\RdfNamespace::set($prefix, $voc->getUriSpace());
356 357
                     }
358
+                    }
357 359
 
358 360
                 } catch (Exception $e) {
359 361
                     // not valid as namespace identifier, ignore
@@ -475,8 +477,9 @@  discard block
 block discarded – undo
475 477
 
476 478
         // no preferred vocabulary, or it was not found, search in which vocabulary the concept has a label
477 479
         foreach ($vocabs as $vocab) {
478
-            if ($vocab->getConceptLabel($uri, null) !== null)
479
-                return $vocab;
480
+            if ($vocab->getConceptLabel($uri, null) !== null) {
481
+                            return $vocab;
482
+            }
480 483
         }
481 484
 
482 485
         // if the URI couldn't be found, fall back to the first vocabulary
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -220,18 +220,18 @@  discard block
 block discarded – undo
220 220
         }
221 221
 
222 222
         $vocabs = $params->getVocabs();
223
-        $showDeprecated=false;
223
+        $showDeprecated = false;
224 224
         if (sizeof($vocabs) === 1) { // search within vocabulary
225 225
             $voc = $vocabs[0];
226 226
             $sparql = $voc->getSparql();
227
-            $showDeprecated=$voc->getConfig()->getShowDeprecated();
227
+            $showDeprecated = $voc->getConfig()->getShowDeprecated();
228 228
         } else { // multi-vocabulary or global search
229 229
             $voc = null;
230 230
             $sparql = $this->getDefaultSparql();
231 231
             // @TODO : in a global search showDeprecated will always be false and cannot be set globally
232 232
         }
233 233
 
234
-        $results = $sparql->queryConcepts($vocabs, $params->getAdditionalFields(), $params->getUnique(), $params,$showDeprecated);
234
+        $results = $sparql->queryConcepts($vocabs, $params->getAdditionalFields(), $params->getUnique(), $params, $showDeprecated);
235 235
         if ($params->getRest() && $results && $params->getSearchLimit() !== 0) {
236 236
           $results = array_slice($results, $params->getOffset(), $params->getSearchLimit());
237 237
         }
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
     public function getVocabularyCategories()
387 387
     {
388 388
         $cats = $this->globalConfig->getGraph()->allOfType('skos:Concept');
389
-        if(empty($cats)) {
389
+        if (empty($cats)) {
390 390
             return array(new VocabularyCategory($this, null));
391 391
         }
392 392
 
@@ -469,9 +469,9 @@  discard block
 block discarded – undo
469 469
         }
470 470
 
471 471
         // if there are multiple vocabularies and one is the preferred vocabulary, return it
472
-        if($preferredVocabId != null) {
472
+        if ($preferredVocabId != null) {
473 473
             foreach ($vocabs as $vocab) {
474
-                if($vocab->getId() == $preferredVocabId) {
474
+                if ($vocab->getId() == $preferredVocabId) {
475 475
                     // double check that a label exists in the preferred vocabulary
476 476
                     if ($vocab->getConceptLabel($uri, null) !== null) {
477 477
                         return $vocab;
@@ -553,7 +553,7 @@  discard block
 block discarded – undo
553 553
         // using apc cache for the resource if available
554 554
         if ($this->globalConfig->getCache()->isAvailable()) {
555 555
             // @codeCoverageIgnoreStart
556
-            $key = 'fetch: ' . $uri;
556
+            $key = 'fetch: '.$uri;
557 557
             $resource = $this->globalConfig->getCache()->fetch($key);
558 558
             if ($resource === null || $resource === false) { // was not found in cache, or previous request failed
559 559
                 $resource = $this->resolver->resolve($uri, $this->getConfig()->getHttpTimeout());
@@ -574,7 +574,7 @@  discard block
 block discarded – undo
574 574
      */
575 575
     public function getSparqlImplementation($dialect, $endpoint, $graph)
576 576
     {
577
-        $classname = $dialect . "Sparql";
577
+        $classname = $dialect."Sparql";
578 578
 
579 579
         return new $classname($endpoint, $graph, $this);
580 580
     }
Please login to merge, or discard this patch.
model/BaseConfig.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
      * @param string $default default value
43 43
      * @param string $lang preferred language for the literal
44 44
      */
45
-    protected function getLiteral($property, $default=null, $lang=null)
45
+    protected function getLiteral($property, $default = null, $lang = null)
46 46
     {
47 47
         if (!isset($lang)) {;
48 48
             $lang = $this->getEnvLang();
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,8 +55,9 @@
 block discarded – undo
55 55
 
56 56
         // not found with selected language, try any language
57 57
         $literal = $this->getResource()->getLiteral($property);
58
-        if ($literal)
59
-          return $literal->getValue();
58
+        if ($literal) {
59
+                  return $literal->getValue();
60
+        }
60 61
 
61 62
         return $default;
62 63
     }
Please login to merge, or discard this patch.
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -7,11 +7,11 @@
 block discarded – undo
7 7
 abstract class BaseConfig extends DataObject
8 8
 {
9 9
 
10
-	/**
11
-     * Returns a boolean value based on a literal value from the config.ttl configuration.
12
-     * @param string $property the property to query
13
-     * @param boolean $default the default value if the value is not set in configuration
14
-     */
10
+  /**
11
+   * Returns a boolean value based on a literal value from the config.ttl configuration.
12
+   * @param string $property the property to query
13
+   * @param boolean $default the default value if the value is not set in configuration
14
+   */
15 15
     protected function getBoolean($property, $default = false)
16 16
     {
17 17
         $val = $this->getResource()->getLiteral($property);
Please login to merge, or discard this patch.
model/VocabularyConfig.php 3 patches
Braces   +15 added lines, -7 removed lines patch added patch discarded remove patch
@@ -58,8 +58,9 @@  discard block
 block discarded – undo
58 58
     public function getShortName()
59 59
     {
60 60
         $shortname = $this->getLiteral('skosmos:shortName');
61
-        if ($shortname)
62
-          return $shortname;
61
+        if ($shortname) {
62
+                  return $shortname;
63
+        }
63 64
 
64 65
         // if no shortname exists fall back to the id
65 66
         return $this->getId();
@@ -194,10 +195,12 @@  discard block
 block discarded – undo
194 195
         $ret = array();
195 196
         foreach ($resources as $res) {
196 197
             $prop = $res->getURI();
197
-            if (EasyRdf\RdfNamespace::shorten($prop) !== null) // shortening property labels if possible
198
+            if (EasyRdf\RdfNamespace::shorten($prop) !== null) {
199
+              // shortening property labels if possible
198 200
             {
199 201
                 $prop = EasyRdf\RdfNamespace::shorten($prop);
200 202
             }
203
+            }
201 204
 
202 205
             $ret[] = $prop;
203 206
         }
@@ -214,10 +217,12 @@  discard block
 block discarded – undo
214 217
         $resources = $this->resource->allResources("skosmos:hasMultiLingualProperty");
215 218
         foreach ($resources as $res) {
216 219
             $prop = $res->getURI();
217
-            if (EasyRdf\RdfNamespace::shorten($prop) !== null) // shortening property labels if possible
220
+            if (EasyRdf\RdfNamespace::shorten($prop) !== null) {
221
+              // shortening property labels if possible
218 222
             {
219 223
                 $prop = EasyRdf\RdfNamespace::shorten($prop);
220 224
             }
225
+            }
221 226
 
222 227
             if ($prop === $property) {
223 228
                 return true;
@@ -329,11 +334,12 @@  discard block
 block discarded – undo
329 334
     public function getId()
330 335
     {
331 336
         $uriparts = explode("#", $this->resource->getURI());
332
-        if (count($uriparts) != 1)
333
-        // hash namespace
337
+        if (count($uriparts) != 1) {
338
+                // hash namespace
334 339
         {
335 340
             return $uriparts[1];
336 341
         }
342
+        }
337 343
 
338 344
         // slash namespace
339 345
         $uriparts = explode("/", $this->resource->getURI());
@@ -361,10 +367,12 @@  discard block
 block discarded – undo
361 367
         $ret = array();
362 368
         foreach ($resources as $res) {
363 369
             $prop = $res->getURI();
364
-            if (EasyRdf\RdfNamespace::shorten($prop) !== null) // prefixing if possible
370
+            if (EasyRdf\RdfNamespace::shorten($prop) !== null) {
371
+              // prefixing if possible
365 372
             {
366 373
                 $prop = EasyRdf\RdfNamespace::shorten($prop);
367 374
             }
375
+            }
368 376
 
369 377
             $ret[] = $prop;
370 378
         }
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -266,6 +266,7 @@  discard block
 block discarded – undo
266 266
 
267 267
     /**
268 268
      * Returns skosmos:marcSourcecode value set in config.ttl.
269
+     * @param string $lang
269 270
      * @return string marcsource name
270 271
      */
271 272
     public function getMarcSourceCode($lang = null)
@@ -275,7 +276,7 @@  discard block
 block discarded – undo
275 276
 
276 277
     /**
277 278
      * Returns a boolean value set in the config.ttl config.
278
-     * @return array array of concept class URIs (can be empty)
279
+     * @return string[] array of concept class URIs (can be empty)
279 280
      */
280 281
     public function getIndexClasses()
281 282
     {
@@ -284,7 +285,7 @@  discard block
 block discarded – undo
284 285
 
285 286
     /**
286 287
      * Returns skosmos:externalProperty values set in the config.ttl config.
287
-     * @return array array of external property URIs (can be empty)
288
+     * @return string[] array of external property URIs (can be empty)
288 289
      */
289 290
     public function getExtProperties()
290 291
     {
@@ -410,6 +411,7 @@  discard block
 block discarded – undo
410 411
 
411 412
     /**
412 413
      * Returns the vocabulary dc:type value(s) with their labels and uris, if set in the vocabulary configuration.
414
+     * @param string $lang
413 415
      * @return array of objects or an empty array
414 416
      */
415 417
     public function getTypes($lang = null)
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
     "skos:related", "skos:historyNote", "skosmos:memberOf",
29 29
     "skosmos:memberOfArray");
30 30
 
31
-    public function __construct($resource, $globalPlugins=array())
31
+    public function __construct($resource, $globalPlugins = array())
32 32
     {
33 33
         $this->resource = $resource;
34 34
         $plugins = $this->resource->allLiterals('skosmos:usePlugin');
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
                         $paramValue = $paramLiteral->getValue();
57 57
                         $paramLang = $paramLiteral->getLang();
58 58
                         if ($paramLang) {
59
-                            $paramName .= '_' . $paramLang;
59
+                            $paramName .= '_'.$paramLang;
60 60
                         }
61 61
                         $this->pluginParameters[$pluginName][$paramName] = $paramValue;
62 62
                     }
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         $langs = $this->getLanguages();
84 84
         $deflang = reset($langs); // picking the first one from the list with reset since the keys are not numeric
85 85
         if (sizeof($langs) > 1) {
86
-            trigger_error("Default language for vocabulary '" . $this->getShortName() . "' unknown, choosing '$deflang'.", E_USER_WARNING);
86
+            trigger_error("Default language for vocabulary '".$this->getShortName()."' unknown, choosing '$deflang'.", E_USER_WARNING);
87 87
         }
88 88
 
89 89
         return $deflang;
Please login to merge, or discard this patch.