SubjectDirectory.__iter__() - Code Metrics - Inspection of "Merge pull request #58 from NatLibFi/subject-corpu..." - NatLibFi/Annif - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (ea367e)

by Osma

created 2018-03-19 13:08 UTC

SubjectDirectory.iter() A

↳ Parent: SubjectDirectory

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
dl	0
loc	8
rs	9.4285

"""A directory of files as a subject corpus"""


import glob
import os.path
import re



class Subject:
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self, uri, label, text):
        self.uri = uri
        self.label = label
        self.text = text


class SubjectDirectory:
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self, path):
        self.path = path

    def __iter__(self):
        """Iterate through the directory, yielding Subject objects."""

        for filename in glob.glob(os.path.join(self.path, '*.txt')):
            with open(filename) as subjfile:
                uri, label = subjfile.readline().strip().split(' ', 1)
                text = ' '.join(subjfile.readlines())
                yield Subject(uri, label, text)


1			"""A directory of files as a subject corpus"""
2
3
4			import glob
5			import os.path
6			import re
			0 ignored issues – show Unused Code introduced 2018-03-19 11:48 UTC by Report Bug Copy Issue Report The import `re` seems to be unused. Loading history...
7
8
9			class Subject:
			1 ignored issue – show Coding Style introduced 2018-03-19 11:48 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-03-19 11:48 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
10			def __init__(self, uri, label, text):
11			self.uri = uri
12			self.label = label
13			self.text = text
14
15
16			class SubjectDirectory:
			1 ignored issue – show Coding Style introduced 2018-03-19 11:48 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-03-19 11:48 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
17			def __init__(self, path):
18			self.path = path
19
20			def __iter__(self):
21			"""Iterate through the directory, yielding Subject objects."""
22
23			for filename in glob.glob(os.path.join(self.path, '*.txt')):
24			with open(filename) as subjfile:
25			uri, label = subjfile.readline().strip().split(' ', 1)
26			text = ' '.join(subjfile.readlines())
27			yield Subject(uri, label, text)
28

NatLibFi / Annif

Branch — master (ea367e)

SubjectDirectory.__iter__() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SubjectDirectory.iter() A