Authorize::handle() - Code Metrics - Napp/aclcore - Measure and Improve Code Quality continuously with Scrutinizer

Authorize::handle() A
last analyzed 2020-10-29 21:35 UTC

↳ Parent: Authorize

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
nc	3
nop	3
dl	0
loc	14
ccs	7
cts	7
cp	1
crap	3
rs	9.7998
c	0
b	0
f	0

<?php

namespace Napp\Core\Acl\Middleware;

use Closure;
use Illuminate\Auth\AuthenticationException;
use Napp\Core\Api\Exceptions\Exceptions\AuthorizationException;

/**
 * Class Authorize.
 */
class Authorize
{
    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure                 $next
     * @param string|array             $ability
     *
     * @throws \Illuminate\Auth\AuthenticationException
     * @throws \Napp\Core\Api\Exceptions\Exceptions\AuthorizationException
     *
     * @return mixed
     */
    public function handle($request, Closure $next, ...$ability)
    {
        $user = auth(config('acl.guard'))->user();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        if (null === $user) {
            throw new AuthenticationException();
        }

        if (false === acl($ability)) {
            throw new AuthorizationException();
        }

        return $next($request);
    }
}


1		<?php
2
3		namespace Napp\Core\Acl\Middleware;
4
5		use Closure;
6		use Illuminate\Auth\AuthenticationException;
7		use Napp\Core\Api\Exceptions\Exceptions\AuthorizationException;
8
9		/**
10		* Class Authorize.
11		*/
12		class Authorize
13		{
14		/**
15		* Handle an incoming request.
16		*
17		* @param \Illuminate\Http\Request $request
18		* @param \Closure $next
19		* @param string\|array $ability
20		*
21		* @throws \Illuminate\Auth\AuthenticationException
22		* @throws \Napp\Core\Api\Exceptions\Exceptions\AuthorizationException
23		*
24		* @return mixed
25		*/
26	6	public function handle($request, Closure $next, ...$ability)
27		{
28	6	$user = auth(config('acl.guard'))->user();
		0 ignored issues – show Bug introduced 2018-09-04 21:21 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
29
30	6	if (null === $user) {
31	2	throw new AuthenticationException();
32		}
33
34	4	if (false === acl($ability)) {
35	2	throw new AuthorizationException();
36		}
37
38	2	return $next($request);
39		}
40		}
41

Napp / aclcore

Authorize::handle() A last analyzed 2020-10-29 21:35 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

Authorize::handle() A
last analyzed 2020-10-29 21:35 UTC