App\Http\Controllers\RssController::categoryFeedRss()

Complexity

Conditions	13
Paths	641

Size

Total Lines	23
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function categoryFeedRss(Request $request)
    {
        $this->setPrefs();
        $rss = new RSS(['Settings' => $this->settings]);
        $offset = 0;
        if (! $request->has('id')) {
            return response()->json(['error' => 'Category ID is missing'], '403');
        }

        $user = $this->userCheck($request->all());

$request->all() of type array is incompatible with the type Illuminate\Http\Request expected by parameter $request of App\Http\Controllers\RssController::userCheck().

        $categoryId = (int) $request->input('id');
        $userAirDate = $request->has('airdate') && is_numeric($request->input('airdate')) ? abs($request->input('airdate')) : -1;
        $userNum = ($request->has('num') && is_numeric($request->input('num')) ? abs($request->input('num')) : 0);
        $userLimit = $request->has('limit') && is_numeric($request->input('limit')) ? $request->input('limit') : 100;
        $userShow = $userAnidb = -1;
        if ($request->has('show')) {
            $userShow = ((int) $request->input('show') === 0 ? -1 : $request->input('show') + 0);
        } elseif ($request->has('anidb')) {
            $userAnidb = ((int) $request->input('anidb') === 0 ? -1 : $request->input('anidb') + 0);
        }
        $outputXML = (! ($request->has('o') && $request->input('o') === 'json'));
        $relData = $rss->getRss($categoryId, $userShow, $userAnidb, $user['user_id'], $userAirDate, $userLimit, $userNum);

It seems like $userAirDate can also be of type double; however, parameter $airDate of Blacklight\http\RSS::getRss() does only seem to accept integer, maybe add an additional type check?

It seems like $userNum can also be of type double; however, parameter $offset of Blacklight\http\RSS::getRss() does only seem to accept integer, maybe add an additional type check?

        $rss->output($relData, $user['params'], $outputXML, $offset, 'rss');
    }