App\Http\Controllers\CoverController::show()

Complexity

Conditions	7
Paths	18

Size

Total Lines	48
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function show(string $type, string $filename)
    {
        // Validate cover type
        $validTypes = ['anime', 'audio', 'audiosample', 'book', 'console', 'games', 'movies', 'music', 'preview', 'sample', 'tvrage', 'video', 'xxx', 'tvshows'];

        if (! in_array($type, $validTypes)) {
            abort(404);
        }

        // Build the file path
        $filePath = storage_path("covers/{$type}/{$filename}");

        // For preview and sample images, try with _thumb suffix if original doesn't exist
        if (! file_exists($filePath) && in_array($type, ['preview', 'sample'])) {
            // Try with _thumb suffix
            $pathInfo = pathinfo($filename);
            $thumbFilename = $pathInfo['filename'].'_thumb.'.($pathInfo['extension'] ?? 'jpg');
            $thumbPath = storage_path("covers/{$type}/{$thumbFilename}");

            if (file_exists($thumbPath)) {
                $filePath = $thumbPath;
            }
        }

        // Check if file exists
        if (! file_exists($filePath)) {
            // Return placeholder image
            $placeholderPath = public_path('assets/images/no-cover.png');
            if (file_exists($placeholderPath)) {
                return response()->file($placeholderPath);
            }
            abort(404);
        }

        // Determine content type
        $extension = strtolower(pathinfo($filePath, PATHINFO_EXTENSION));

It seems like pathinfo($filePath, App\Http\Controllers\PATHINFO_EXTENSION) can also be of type array; however, parameter $string of strtolower() does only seem to accept string, maybe add an additional type check?

        $contentType = match ($extension) {
            'jpg', 'jpeg' => 'image/jpeg',
            'png' => 'image/png',
            'gif' => 'image/gif',
            'webp' => 'image/webp',
            default => 'image/jpeg',
        };

        // Serve the file with proper headers
        return response()->file($filePath, [
            'Content-Type' => $contentType,
            'Cache-Control' => 'public, max-age=31536000', // Cache for 1 year
        ]);