App\Http\Controllers\Api\FileListApiController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getFileList()	0	28	3

<?php

namespace App\Http\Controllers\Api;

use App\Http\Controllers\Controller;
use App\Models\Release;
use Blacklight\NZB;
use Illuminate\Http\JsonResponse;

class FileListApiController extends Controller
{
    /**
     * Get file list for a release
     */
    public function getFileList(string $guid): JsonResponse
    {
        $nzb = new NZB;

        $rel = Release::getByGuid($guid);
        if (! $rel) {
            return response()->json(['error' => 'Release not found'], 404);
        }

        $nzbpath = $nzb->NZBPath($guid);

        if (! file_exists($nzbpath)) {

It seems like $nzbpath can also be of type false; however, parameter $filename of file_exists() does only seem to accept string, maybe add an additional type check?

            return response()->json(['error' => 'NZB file not found'], 404);
        }

        ob_start();
        @readgzfile($nzbpath);

It seems like you do not handle an error condition for readgzfile(). This can introduce security issues, and is generally not recommended.

It seems like $nzbpath can also be of type false; however, parameter $filename of readgzfile() does only seem to accept string, maybe add an additional type check?

        $nzbfile = ob_get_clean();

        $files = $nzb->nzbFileList($nzbfile);

        return response()->json([
            'release' => [
                'guid' => $rel['guid'],
                'searchname' => $rel['searchname'],
            ],
            'files' => $files,
            'total' => count($files),
        ]);
    }
}