Passed
Pull Request — master (#1501)
by
unknown
15:20 queued 09:41
created
Blacklight/NZBExport.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -49,19 +49,19 @@  discard block
 block discarded – undo
49 49
         $path = $params[0];
50 50
 
51 51
         // Check if the path ends with dir separator.
52
-        if (! Str::endsWith($path, '/')) {
52
+        if (!Str::endsWith($path, '/')) {
53 53
             $path .= '/';
54 54
         }
55 55
 
56 56
         // Check if it's a directory.
57
-        if (! File::isDirectory($path)) {
57
+        if (!File::isDirectory($path)) {
58 58
             $this->echoOut('Folder does not exist: '.$path);
59 59
 
60 60
             return $this->returnValue();
61 61
         }
62 62
 
63 63
         // Check if we can write to it.
64
-        if (! is_writable($path)) {
64
+        if (!is_writable($path)) {
65 65
             $this->echoOut('Folder is not writable: '.$path);
66 66
 
67 67
             return $this->returnValue();
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
         // Check if the from date is the proper format.
71 71
         if (isset($params[1]) && $params[1] !== '') {
72
-            if (! $this->checkDate($params[1])) {
72
+            if (!$this->checkDate($params[1])) {
73 73
                 return $this->returnValue();
74 74
             }
75 75
             $fromDate = $params[1];
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         // Check if the to date is the proper format.
79 79
         if (isset($params[2]) && $params[2] !== '') {
80
-            if (! $this->checkDate($params[2])) {
80
+            if (!$this->checkDate($params[2])) {
81 81
                 return $this->returnValue();
82 82
             }
83 83
             $toDate = $params[2];
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
         // Check if the group_id exists.
87 87
         if (isset($params[3]) && $params[3] !== 0) {
88
-            if (! is_numeric($params[3])) {
88
+            if (!is_numeric($params[3])) {
89 89
                 $this->echoOut('The group ID is not a number: '.$params[3]);
90 90
 
91 91
                 return $this->returnValue();
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 
121 121
             // Create a path to store the new NZB files.
122 122
             $currentPath = $path.$this->safeFilename($group['name']).'/';
123
-            if (! File::isDirectory($currentPath) && ! File::makeDirectory($currentPath) && ! File::isDirectory($currentPath)) {
123
+            if (!File::isDirectory($currentPath) && !File::makeDirectory($currentPath) && !File::isDirectory($currentPath)) {
124 124
                 throw new \RuntimeException(sprintf('Directory "%s" was not created', $currentPath));
125 125
             }
126 126
             foreach ($releases as $release) {
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
                 // Check if the user wants them in gzip, copy it if so.
142 142
                 if ($gzip) {
143
-                    if (! copy($nzbFile, $currentFile.'.nzb.gz')) {
143
+                    if (!copy($nzbFile, $currentFile.'.nzb.gz')) {
144 144
                         if ($this->echoCLI) {
145 145
                             echo 'Unable to export NZB with GUID: '.$release['guid'];
146 146
                         }
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
                     // If not, decompress it and create a file to store it in.
151 151
                 } else {
152 152
                     $nzbContents = Utility::unzipGzipFile($nzbFile);
153
-                    if (! $nzbContents) {
153
+                    if (!$nzbContents) {
154 154
                         if ($this->echoCLI) {
155 155
                             echo 'Unable to export NZB with GUID: '.$release['guid'];
156 156
                         }
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
     protected function checkDate($date): bool
192 192
     {
193
-        if (! preg_match('/^(\d{2}\/){2}\d{4}$/', $date)) {
193
+        if (!preg_match('/^(\d{2}\/){2}\d{4}$/', $date)) {
194 194
             $this->echoOut('Wrong date format: '.$date);
195 195
 
196 196
             return false;
Please login to merge, or discard this patch.
Blacklight/TmuxRun.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -687,7 +687,7 @@
 block discarded – undo
687 687
     {
688 688
         $sharing = (array) Arr::first(DB::select('SELECT enabled, posting, fetching FROM sharing'));
689 689
 
690
-        if (! empty($sharing) && (int) $sharing['enabled'] === 1 && (int) $runVar['settings']['run_sharing'] === 1 && ((int) $sharing['posting'] === 1 || (int) $sharing['fetching'] === 1) && shell_exec("tmux list-panes -t{$runVar['constants']['tmux_session']}:{$pane} | grep ^0 | grep -c dead") == 1) {
690
+        if (!empty($sharing) && (int) $sharing['enabled'] === 1 && (int) $runVar['settings']['run_sharing'] === 1 && ((int) $sharing['posting'] === 1 || (int) $sharing['fetching'] === 1) && shell_exec("tmux list-panes -t{$runVar['constants']['tmux_session']}:{$pane} | grep ^0 | grep -c dead") == 1) {
691 691
             shell_exec(
692 692
                 "tmux respawnp -t{$runVar['constants']['tmux_session']}:{$pane}.0 ' \
693 693
                     {$runVar['commands']['_php']} {$runVar['paths']['misc']}/update/multiprocessing/postprocess.php sha; \
Please login to merge, or discard this patch.
Blacklight/CollectionsCleaning.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
     protected function generic(): array
108 108
     {
109 109
         // For non music groups.
110
-        if (! preg_match('/\.(flac|lossless|mp3|music|sounds)/', $this->groupName)) {
110
+        if (!preg_match('/\.(flac|lossless|mp3|music|sounds)/', $this->groupName)) {
111 111
             // File/part count.
112 112
             // File extensions.
113 113
             // File extensions - If it was not in quotes.
Please login to merge, or discard this patch.
Blacklight/Console.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
     {
276 276
         $browseBy = ' ';
277 277
         foreach ($this->getBrowseByOptions() as $bbk => $bbv) {
278
-            if (! empty($_REQUEST[$bbk])) {
278
+            if (!empty($_REQUEST[$bbk])) {
279 279
                 $bbs = stripslashes($_REQUEST[$bbk]);
280 280
                 $browseBy .= ' AND con.'.$bbv.' LIKE '.escapeString('%'.$bbs.'%');
281 281
             }
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
         $con['esrb'] = (string) $amaz->ItemAttributes->ESRBAgeRating;
401 401
         $con['releasedate'] = (string) $amaz->ItemAttributes->ReleaseDate;
402 402
 
403
-        if (! isset($con['releasedate'])) {
403
+        if (!isset($con['releasedate'])) {
404 404
             $con['releasedate'] = '';
405 405
         }
406 406
 
@@ -628,7 +628,7 @@  discard block
 block discarded – undo
628 628
         if (config('config.credentials.client_id') !== '' && config('config.credentials.client_secret') !== '') {
629 629
             try {
630 630
                 $result = Game::where('name', $gameInfo)->get();
631
-                if (! empty($result)) {
631
+                if (!empty($result)) {
632 632
                     $bestMatchPct = 0;
633 633
                     foreach ($result as $res) {
634 634
                         similar_text(strtolower($gameInfo), strtolower($res->name), $percent);
@@ -646,7 +646,7 @@  discard block
 block discarded – undo
646 646
                         ])->where('id', $bestMatch)->first();
647 647
 
648 648
                         $publishers = [];
649
-                        if (! empty($game->involved_companies)) {
649
+                        if (!empty($game->involved_companies)) {
650 650
                             foreach ($game->involved_companies as $publisher) {
651 651
                                 if ($publisher['publisher'] === true) {
652 652
                                     $company = Company::find($publisher['company']);
@@ -657,7 +657,7 @@  discard block
 block discarded – undo
657 657
 
658 658
                         $genres = [];
659 659
 
660
-                        if (! empty($game->themes)) {
660
+                        if (!empty($game->themes)) {
661 661
                             foreach ($game->themes as $theme) {
662 662
                                 $genres[] = $theme['name'];
663 663
                             }
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
 
668 668
                         $platform = '';
669 669
 
670
-                        if (! empty($game->platforms)) {
670
+                        if (!empty($game->platforms)) {
671 671
                             foreach ($game->platforms as $platforms) {
672 672
                                 $percentCurrent = 0;
673 673
                                 $gamePlatforms = Platform::where('id', $platforms)->get();
@@ -686,13 +686,13 @@  discard block
 block discarded – undo
686 686
                             'title' => $game->name,
687 687
                             'asin' => $game->id,
688 688
                             'review' => $game->summary ?? '',
689
-                            'coverurl' => ! empty($game->cover->url) ? 'https:'.$game->cover->url : '',
690
-                            'releasedate' => ! empty($game->first_release_date) ? $game->first_release_date->format('Y-m-d') : now()->format('Y-m-d'),
691
-                            'esrb' => ! empty($game->aggregated_rating) ? round($game->aggregated_rating).'%' : 'Not Rated',
689
+                            'coverurl' => !empty($game->cover->url) ? 'https:'.$game->cover->url : '',
690
+                            'releasedate' => !empty($game->first_release_date) ? $game->first_release_date->format('Y-m-d') : now()->format('Y-m-d'),
691
+                            'esrb' => !empty($game->aggregated_rating) ? round($game->aggregated_rating).'%' : 'Not Rated',
692 692
                             'url' => $game->url ?? '',
693
-                            'publisher' => ! empty($publishers) ? implode(',', $publishers) : 'Unknown',
693
+                            'publisher' => !empty($publishers) ? implode(',', $publishers) : 'Unknown',
694 694
                             'platform' => $platform ?? '',
695
-                            'consolegenre' => ! empty($genres) ? implode(',', $genres) : 'Unknown',
695
+                            'consolegenre' => !empty($genres) ? implode(',', $genres) : 'Unknown',
696 696
                             'consolegenreid' => $genreKey ?? '',
697 697
                             'salesrank' => '',
698 698
                         ];
@@ -835,7 +835,7 @@  discard block
 block discarded – undo
835 835
                 $platform = 'PSX';
836 836
             }
837 837
 
838
-            if (! empty($title) && stripos('XBLA', $platform) === 0 && stripos('dlc', $title) !== false) {
838
+            if (!empty($title) && stripos('XBLA', $platform) === 0 && stripos('dlc', $title) !== false) {
839 839
                 $platform = 'XBOX360';
840 840
             }
841 841
 
@@ -850,7 +850,7 @@  discard block
 block discarded – undo
850 850
            Other option is to pass the $release->categories_id here if we don't find a platform but that
851 851
            would require an extra lookup to determine the name. In either case we should have a title at the minimum. */
852 852
 
853
-        return (isset($result['title'], $result['platform']) && ! empty($result['title'])) ? $result : false;
853
+        return (isset($result['title'], $result['platform']) && !empty($result['title'])) ? $result : false;
854 854
     }
855 855
 
856 856
     public function getBrowseNode($platform): string
Please login to merge, or discard this patch.
Blacklight/ReleaseExtra.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -106,8 +106,8 @@  discard block
 block discarded – undo
106 106
         $audios = $arrXml->getAudios();
107 107
         $videos = $arrXml->getVideos();
108 108
         $subtitles = $arrXml->getSubtitles();
109
-        if (! empty($general)) {
110
-            if (! empty($general->get('unique_id')) && (int) $general->get('unique_id')->getShortName() !== 1) {
109
+        if (!empty($general)) {
110
+            if (!empty($general->get('unique_id')) && (int) $general->get('unique_id')->getShortName() !== 1) {
111 111
                 $uniqueId = $general->get('unique_id')->getShortName();
112 112
                 $this->addUID($releaseID, $uniqueId);
113 113
             }
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 
123 123
             $videoDuration = $videoFormat = $videoCodec = $videoWidth = $videoHeight = $videoAspect = $videoFrameRate = $videoLibrary = $videoBitRate = '';
124 124
 
125
-            if (! empty($videos)) {
125
+            if (!empty($videos)) {
126 126
                 foreach ($videos as $video) {
127 127
                     if ($video->get('duration') !== null) {
128 128
                         $videoDuration = $video->get('duration')->getMilliseconds();
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
                         $videoBitRate = $video->get('nominal_bit_rate')->getTextValue();
169 169
                     }
170 170
 
171
-                    if (! empty($videoBitRate)) {
171
+                    if (!empty($videoBitRate)) {
172 172
                         $overallBitRate = $videoBitRate;
173 173
                     }
174 174
 
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
             $audioID = 1;
180 180
             $audioFormat = $audioMode = $audioBitRateMode = $audioBitRate = $audioChannels = $audioSampleRate = $audioLibrary = $audioLanguage = $audioTitle = '';
181 181
 
182
-            if (! empty($audios)) {
182
+            if (!empty($audios)) {
183 183
                 foreach ($audios as $audio) {
184 184
                     if ($audio->get('id') !== null) {
185 185
                         $audioID = $audio->get('id')->getFullName();
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
                 }
226 226
             }
227 227
 
228
-            if (! empty($subtitles)) {
228
+            if (!empty($subtitles)) {
229 229
                 foreach ($subtitles as $subtitle) {
230 230
                     $subsID = 1;
231 231
                     $subsLanguage = 'Unknown';
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
                 'audiochannels' => \is_array($audioChannels) ? implode($audioChannels) : $audioChannels,
290 290
                 'audiosamplerate' => \is_array($audioSampleRate) ? implode($audioSampleRate) : $audioSampleRate,
291 291
                 'audiolibrary' => \is_array($audioLibrary) ? implode($audioLibrary) : $audioLibrary,
292
-                'audiolanguage' => ! empty($audioLanguage) ? $audioLanguage[1] : '',
292
+                'audiolanguage' => !empty($audioLanguage) ? $audioLanguage[1] : '',
293 293
                 'audiotitle' => \is_array($audioTitle) ? implode($audioTitle) : $audioTitle,
294 294
             ]);
295 295
         }
@@ -299,10 +299,10 @@  discard block
 block discarded – undo
299 299
     {
300 300
         $ckid = ReleaseSubtitle::query()->where('releases_id', $releaseID)->first(['releases_id']);
301 301
         $subs = '';
302
-        if (! empty($subsLanguage)) {
303
-            if (! empty($subsLanguage[1])) {
302
+        if (!empty($subsLanguage)) {
303
+            if (!empty($subsLanguage[1])) {
304 304
                 $subs = $subsLanguage[1];
305
-            } elseif (! empty($subsLanguage[0])) {
305
+            } elseif (!empty($subsLanguage[0])) {
306 306
                 $subs = $subsLanguage[0];
307 307
             }
308 308
         }
Please login to merge, or discard this patch.
Blacklight/Regexes.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      */
150 150
     public function deleteRegex(int $id): void
151 151
     {
152
-        DB::transaction(function () use ($id) {
152
+        DB::transaction(function() use ($id) {
153 153
             DB::delete(sprintf('DELETE FROM %s WHERE id = %d', $this->tableName, $id));
154 154
         }, 3);
155 155
     }
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
     {
167 167
         $groupID = UsenetGroup::getIDByName($groupName);
168 168
 
169
-        if (! $groupID) {
169
+        if (!$groupID) {
170 170
             return [];
171 171
         }
172 172
 
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
                     ksort($hits);
189 189
                     $string = $string2 = '';
190 190
                     foreach ($hits as $key => $hit) {
191
-                        if (! \is_int($key)) {
191
+                        if (!\is_int($key)) {
192 192
                             $string .= $hit;
193 193
                             $string2 .= '<br/>'.$key.': '.$hit;
194 194
                         }
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
     {
228 228
         $groupID = UsenetGroup::getIDByName($groupName);
229 229
 
230
-        if (! $groupID) {
230
+        if (!$groupID) {
231 231
             return [];
232 232
         }
233 233
 
Please login to merge, or discard this patch.
Blacklight/NZBImport.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     public function beginImport($filesToProcess, $useNzbName = false, $delete = true, $deleteFailed = true)
108 108
     {
109 109
         // Get all the groups in the DB.
110
-        if (! $this->getAllGroups()) {
110
+        if (!$this->getAllGroups()) {
111 111
             if ($this->browser) {
112 112
                 return $this->retVal;
113 113
             }
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
                     gzwrite($fp, $nzbString);
168 168
                     gzclose($fp);
169 169
 
170
-                    if (! File::isFile($path)) {
170
+                    if (!File::isFile($path)) {
171 171
                         $this->echoOut('ERROR: Problem compressing NZB file to: '.$path);
172 172
 
173 173
                         // Remove the release.
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
                 if ($groupID === -1) {
256 256
                     if (array_key_exists($group, $this->allGroups)) {
257 257
                         $groupID = $this->allGroups[$group];
258
-                        if (! $groupName) {
258
+                        if (!$groupName) {
259 259
                             $groupName = $group;
260 260
                         }
261 261
                     } else {
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
             }
290 290
 
291 291
             // If we found a group and it's not blacklisted.
292
-            if ($groupID !== -1 && ! $isBlackListed) {
292
+            if ($groupID !== -1 && !$isBlackListed) {
293 293
                 // Get the size of the release.
294 294
                 if (\count($file->segments->segment) > 0) {
295 295
                     foreach ($file->segments->segment as $segment) {
Please login to merge, or discard this patch.
Blacklight/ReleaseImage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
             return 0;
135 135
         }
136 136
         // Check if it's on the drive.
137
-        if (! File::isReadable($coverPath)) {
137
+        if (!File::isReadable($coverPath)) {
138 138
             return 0;
139 139
         }
140 140
 
Please login to merge, or discard this patch.
Blacklight/processing/post/AniDB.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
             $this->status = self::PROC_EXTFAIL;
182 182
         }
183 183
 
184
-        if (! empty($hits['title'])) {
184
+        if (!empty($hits['title'])) {
185 185
             $hits['title'] = trim(str_replace(['_', '.'], ' ', $hits['title']));
186 186
         }
187 187
 
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
                 $anidbId = $this->getAnidbByName($tmpName);
237 237
             }
238 238
 
239
-            if (! empty($anidbId) && is_numeric($anidbId->anidbid) && $anidbId->anidbid > 0) {
239
+            if (!empty($anidbId) && is_numeric($anidbId->anidbid) && $anidbId->anidbid > 0) {
240 240
                 $updatedAni = $this->checkAniDBInfo($anidbId->anidbid, $cleanArr['epno']);
241 241
 
242 242
                 if ($updatedAni === null) {
Please login to merge, or discard this patch.