populate_indexes()

Complexity

Conditions	13
Paths	28

Size

Total Lines	109
Code Lines	65

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function populate_indexes($table, $max)
{
    $allowedIndexes = ['releases', 'predb'];
    if (\in_array($table, $allowedIndexes, true)) {
        if ($table === 'releases') {
            DB::statement('SET SESSION group_concat_max_len=16384;');
            $query = 'SELECT r.id, r.name, r.searchname, r.fromname, IFNULL(GROUP_CONCAT(rf.name SEPARATOR " "),"") filename
				FROM releases r
				LEFT JOIN release_files rf ON r.id = rf.releases_id
				WHERE r.id > %d
				GROUP BY r.id
				ORDER BY r.id ASC
				LIMIT %d';

            $totals = Release::fromQuery('SELECT COUNT(id) AS c, MIN(id) AS min FROM releases')->first();
            if (! $totals) {
                exit("Could not get database information for releases table.\n");

Using exit here is not recommended.

            }
            $total = $totals->c;

The property c does not seem to exist on App\Models\Release. Are you sure there is no database migration missing?

            $minId = $totals->min;

The property min does not seem to exist on App\Models\Release. Are you sure there is no database migration missing?

        }

        if ($table === 'predb') {
            DB::statement('SET SESSION group_concat_max_len=16384;');
            $query = 'SELECT id, title, filename, source
				FROM predb
				WHERE id > %d
				GROUP BY id
				ORDER BY id ASC
				LIMIT %d';

            $totals = Predb::fromQuery('SELECT COUNT(id) AS c, MIN(id) AS min FROM predb')->first();
            if (! $totals) {
                exit("Could not get database information for predb table.\n");

Using exit here is not recommended.

            }
            $total = $totals->c;

The property c does not seem to exist on App\Models\Predb. Are you sure there is no database migration missing?

            $minId = $totals->min;

The property min does not seem to exist on App\Models\Predb. Are you sure there is no database migration missing?

        }

        $lastId = $minId - 1;

The variable $minId does not seem to be defined for all execution paths leading up to this point.

        echo "[Starting to populate ElasticSearch index $table with $total releases.]".PHP_EOL;

The variable $total does not seem to be defined for all execution paths leading up to this point.

        $data = ['body' => []];
        for ($i = $minId; $i <= ($total + $max + $minId); $i += $max) {
            $rows = DB::select(sprintf($query, $lastId, $max));

The variable $query does not seem to be defined for all execution paths leading up to this point.

            if ($rows === 0) {
                continue;
            }

            foreach ($rows as $row) {
                if ($row->id > $lastId) {
                    $lastId = $row->id;
                }
                switch ($table) {
                    case 'releases':
                        $data['body'][] = [
                            'index' => [
                                '_index' => 'releases',
                                '_type' => 'releases',
                                '_id' => $row->id
                            ]
                        ];

                        $data['body'][] = [
                            'id' => $row->id,
                            'name' => $row->name,
                            'searchname' => $row->searchname,
                            'fromname' => $row->fromname,
                            'filename' => $row->filename,
                        ];
                        break;

                    case 'predb':
                        $data['body'][] = [
                            'index' => [
                                '_index' => 'predb',
                                '_type' => 'predb',
                                '_id' => $row->id
                            ]
                        ];
                        $data['body'][] = [
                                'id' => $row->id,
                                'title' => $row->title,
                                'filename' => $row->filename,
                                'source' => $row->source,
                            ];
                        break;
                }
            }
            // Stop and send the bulk request
            $responses = Elasticsearch::bulk($data);

            // erase the old bulk request
            $data = ['body' => []];

            // unset the bulk response when you are done to save memory
            unset($responses);

            echo '.';
        }

        // Send the last batch if it exists
        if (! empty($data['body'])) {
            $responses = Elasticsearch::bulk($data);

The assignment to $responses is dead and can be removed.

        }
        echo "\n[Done]\n";
    } else {
        exit(

Using exit here is not recommended.

            "Argument 1 is the index name, releases and predb are the only supported ones currently.\n".
            "Argument 2 is optional, max number of rows to send to ES at a time, 10,000 is the default if not set.\n"
        );