App\Services\TvProcessing\Pipes\ParseInfoPipe

Complexity

Total Complexity

9

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	26	4
A	getLocalDb()	0	6	2
A	getName()	0	3	1
A	process()	0	4	1
A	getStatusCode()	0	3	1

<?php

namespace App\Services\TvProcessing\Pipes;

use App\Services\TvProcessing\TvProcessingPassable;
use App\Services\TvProcessing\TvProcessingResult;
use Blacklight\processing\tv\LocalDB;
use Closure;

/**
 * Initial pipe that parses the release name into structured info.
 * This must run before any provider pipes.
 */
class ParseInfoPipe extends AbstractTvProviderPipe
{
    protected int $priority = 1;
    private ?LocalDB $localDb = null;

    public function getName(): string
    {
        return 'ParseInfo';
    }

    public function getStatusCode(): int
    {
        return 0;
    }

    /**
     * Get or create the LocalDB instance for parsing.
     */
    private function getLocalDb(): LocalDB
    {
        if ($this->localDb === null) {
            $this->localDb = new LocalDB();
        }
        return $this->localDb;

The expression return $this->localDb could return the type null which is incompatible with the type-hinted return Blacklight\processing\tv\LocalDB. Consider adding an additional type-check to rule them out.

    }

    /**
     * Override handle to perform parsing before the standard processing flow.
     */
    public function handle(TvProcessingPassable $passable, Closure $next): TvProcessingPassable
    {
        $parsedInfo = $this->getLocalDb()->parseInfo($passable->context->searchName);

        if ($parsedInfo === false || empty($parsedInfo['name'])) {
            // Mark as parse failed
            $passable->setParsedInfo(null);
            $passable->updateResult(
                TvProcessingResult::parseFailed(['search_name' => $passable->context->searchName]),
                $this->getName()
            );

            if ($this->echoOutput) {
                $this->colorCli->error(sprintf(
                    '  ✗ Parse failed: %s',
                    mb_substr($passable->context->searchName, 0, 50)
                ));
            }

            // Don't continue to other pipes - can't process without parsed info
            return $passable;
        }

        $passable->setParsedInfo($parsedInfo);

It seems like $parsedInfo can also be of type true; however, parameter $info of App\Services\TvProcessing\TvProcessingPassable::setParsedInfo() does only seem to accept array|null, maybe add an additional type check?

        return $next($passable);
    }

    protected function process(TvProcessingPassable $passable): TvProcessingResult
    {
        // Not used - we override handle() instead
        return TvProcessingResult::pending();
    }
}