CreateManticoreIndexes::handle() - Code Metrics - Inspection of "CS fixes" - NNTmux/newznab-tmux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 564e06...aaf712 )

by Darko

created 2025-04-30 15:11 UTC

CreateManticoreIndexes::handle() B

↳ Parent: CreateManticoreIndexes

Complexity

Conditions	5
Paths	7

Size

Total Lines	80
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
eloc	43
c	2
b	1
f	0
dl	0
loc	80
rs	8.9208
cc	5
nc	7
nop	0

How to fix Long Method

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;
use Manticoresearch\Client;
use Manticoresearch\Exceptions\ResponseException;
use Manticoresearch\Index;
filter:
    dependency_paths: ["lib/*"]

class CreateManticoreIndexes extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'manticore:create-indexes
                                        {--drop : Drop existing indexes before creating}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create Manticore Search indexes based on configuration';

    protected Client $client;

    /**
     * Execute the console command.
     */
    public function handle(): int
    {
        $this->info('Creating Manticore Search indexes...');

        $dropExisting = $this->option('drop');

        // Get connection details from config
        $host = config('sphinxsearch.host', '127.0.0.1');
        $port = config('sphinxsearch.port', 9308);

        // Create client
        $this->client = new Client([
            'host' => $host,
            'port' => $port,
        ]);

        // We'll skip checking for data_dir this way since it may not be accessible via API
        // but instead provide better error handling during index creation

        // If you encounter data_dir errors, ensure it's properly set in manticore.conf:
        // data_dir = /path/to/data
        // And make sure the path exists and has proper permissions

        try {
            $this->client->nodes()->status();
        } catch (\Exception $e) {
            $this->error('Failed to connect to Manticore Search: '.$e->getMessage());
            $this->info('Please check if Manticore Search is running and properly configured.');

            return 1;
        }

        // Define indexes and their schema
        $indexes = [
            'releases_rt' => [
                'settings' => [
                    'min_prefix_len' => 0,
                    'min_infix_len' => 2,
                ],
                'columns' => [
                    'name' => ['type' => 'text'],
                    'searchname' => ['type' => 'text'],
                    'fromname' => ['type' => 'text'],
                    'filename' => ['type' => 'text'],
                    'categories_id' => ['type' => 'text'],
                    'dummy' => ['type' => 'integer', 'attribute' => true],
                ],
            ],
            'predb_rt' => [
                'settings' => [
                    'min_prefix_len' => 0,
                    'min_infix_len' => 2,
                ],
                'columns' => [
                    'title' => ['type' => 'text', 'attribute' => true],
                    'filename' => ['type' => 'text', 'attribute' => true],
                    'dummy' => ['type' => 'integer', 'attribute' => true],
                    'source' => ['type' => 'string', 'attribute' => true],
                ],
            ],
        ];

        $hasErrors = false;

        // Create each index
        foreach ($indexes as $indexName => $schema) {
            if (! $this->createIndex($indexName, $schema, $dropExisting)) {
            if (! $this->createIndex($indexName, $schema, /** @scrutinizer ignore-type */ $dropExisting)) {
                $hasErrors = true;
            }
        }

        if ($hasErrors) {
            $this->error('Some errors occurred during index creation.');

            return 1;
        }

        $this->info('All Manticore Search indexes created successfully!');

        return 0;
    }

    /**
     * Create a single index with error handling.
     */
    protected function createIndex(string $indexName, array $schema, bool $dropExisting): bool
    {
        $this->info("Creating {$indexName} index...");
        $indices = $this->client->tables();

        try {
            // Optionally drop existing index
            if ($dropExisting) {
                try {
                    $this->info("Dropping existing {$indexName} index...");
                    $indices->drop(['index' => $indexName, 'body' => ['silent' => true]]);
                    $this->info("Successfully dropped {$indexName} index.");
                } catch (ResponseException $e) {
                    if (! str_contains($e->getMessage(), 'unknown index')) {
                        $this->warn("Warning when dropping {$indexName} index: ".$e->getMessage());
                    }
                }
            }

            // Instead of checking if index exists (which doesn't work),
            // try to create it directly and handle any errors
            // that might occur if it already exists
            $response = $indices->create([
                'index' => $indexName,
                'body' => $schema,
            ]);

            $this->info("Successfully created {$indexName} index.");
            $this->line('Response: '.json_encode($response, JSON_PRETTY_PRINT));

            return true;
        } catch (ResponseException $e) {
            // Check if the error is because the index already exists
            if (str_contains($e->getMessage(), 'already exists')) {
                $this->warn("Index {$indexName} already exists. Use --drop option to recreate it.");

                return true;
            }

            $this->error("Failed to create {$indexName} index: ".$e->getMessage());

            return false;
        } catch (\Exception $e) {
            $this->error("Failed to create {$indexName} index: ".$e->getMessage());

            return false;
        }
    }
}


NNTmux / newznab-tmux

Push — master ( 564e06...aaf712 )

CreateManticoreIndexes::handle() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like