NNTmux /
newznab-tmux
| Total Complexity | 60 |
| Total Lines | 216 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like RssController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RssController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 12 | class RssController extends BasePageController |
||
| 13 | { |
||
| 14 | /** |
||
| 15 | * @param \Illuminate\Http\Request $request |
||
| 16 | * @return void |
||
| 17 | * @throws \Exception |
||
| 18 | * @throws \Throwable |
||
| 19 | */ |
||
| 20 | public function myMoviesRss(Request $request) |
||
| 21 | { |
||
| 22 | $this->setPrefs(); |
||
| 23 | $rss = new RSS(['Settings' => $this->settings]); |
||
| 24 | $offset = 0; |
||
| 25 | |||
| 26 | $user = $this->userCheck($request->all()); |
||
|
Bug
introduced
by
|
|||
| 27 | |||
| 28 | $outputXML = (! ($request->has('o') && $request->input('o') === 'json')); |
||
| 29 | |||
| 30 | $userNum = ($request->has('num') && is_numeric($request->input('num')) ? abs($request->input('num')) : 0); |
||
| 31 | |||
| 32 | $relData = $rss->getMyMoviesRss($userNum, $user['user_id'], User::getCategoryExclusionById($user['user_id'])); |
||
| 33 | |||
| 34 | $rss->output($relData, $user['params'], $outputXML, $offset, 'rss'); |
||
| 35 | } |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @param \Illuminate\Http\Request $request |
||
| 39 | * @throws \Exception |
||
| 40 | * @throws \Throwable |
||
| 41 | */ |
||
| 42 | public function myShowsRss(Request $request) |
||
| 43 | { |
||
| 44 | $this->setPrefs(); |
||
| 45 | $rss = new RSS(['Settings' => $this->settings]); |
||
| 46 | $offset = 0; |
||
| 47 | $user = $this->userCheck($request->all()); |
||
| 48 | $userAirDate = $request->has('airdate') && is_numeric($request->input('airdate')) ? abs($request->input('airdate')) : -1; |
||
| 49 | $userNum = ($request->has('num') && is_numeric($request->input('num')) ? abs($request->input('num')) : 0); |
||
| 50 | $relData = $rss->getShowsRss($userNum, $user['user_id'], User::getCategoryExclusionById($user['user_id']), $userAirDate); |
||
| 51 | $outputXML = (! ($request->has('o') && $request->input('o') === 'json')); |
||
| 52 | |||
| 53 | $rss->output($relData, $user['params'], $outputXML, $offset, 'rss'); |
||
| 54 | } |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @param \Illuminate\Http\Request $request |
||
| 58 | * @throws \Exception |
||
| 59 | * @throws \Throwable |
||
| 60 | */ |
||
| 61 | public function fullFeedRss(Request $request) |
||
| 62 | { |
||
| 63 | $this->setPrefs(); |
||
| 64 | $rss = new RSS(['Settings' => $this->settings]); |
||
| 65 | $offset = 0; |
||
| 66 | $user = $this->userCheck($request->all()); |
||
| 67 | $userAirDate = $request->has('airdate') && is_numeric($request->input('airdate')) ? abs($request->input('airdate')) : -1; |
||
| 68 | $userNum = ($request->has('num') && is_numeric($request->input('num')) ? abs($request->input('num')) : 0); |
||
| 69 | $userLimit = $request->has('limit') && is_numeric($request->input('limit')) ? $request->input('limit') : 100; |
||
| 70 | $userShow = $userAnidb = -1; |
||
| 71 | if ($request->has('show')) { |
||
| 72 | $userShow = ((int) $request->input('show') === 0 ? -1 : $request->input('show') + 0); |
||
| 73 | } elseif ($request->has('anidb')) { |
||
| 74 | $userAnidb = ((int) $request->input('anidb') === 0 ? -1 : $request->input('anidb') + 0); |
||
| 75 | } |
||
| 76 | $outputXML = (! ($request->has('o') && $request->input('o') === 'json')); |
||
| 77 | $relData = $rss->getRss([0], $userShow, $userAnidb, $user['user_id'], $userAirDate, $userLimit, $userNum); |
||
| 78 | $rss->output($relData, $user['params'], $outputXML, $offset, 'rss'); |
||
| 79 | } |
||
| 80 | |||
| 81 | /** |
||
| 82 | * @throws \Exception |
||
| 83 | */ |
||
| 84 | public function showRssDesc() |
||
| 85 | { |
||
| 86 | $this->setPrefs(); |
||
| 87 | $rss = new RSS(['Settings' => $this->settings]); |
||
| 88 | |||
| 89 | $title = 'Rss Info'; |
||
| 90 | $meta_title = 'Rss Nzb Info'; |
||
| 91 | $meta_keywords = 'view,nzb,description,details,rss,atom'; |
||
| 92 | $meta_description = 'View information about NNTmux RSS Feeds.'; |
||
| 93 | |||
| 94 | $firstShow = $rss->getFirstInstance('videos_id', 'releases', 'id'); |
||
| 95 | $firstAni = $rss->getFirstInstance('anidbid', 'releases', 'id'); |
||
| 96 | |||
| 97 | if ($firstShow !== null) { |
||
| 98 | $this->smarty->assign('show', $firstShow->videos_id); |
||
| 99 | } else { |
||
| 100 | $this->smarty->assign('show', 1); |
||
| 101 | } |
||
| 102 | |||
| 103 | if ($firstAni !== null) { |
||
| 104 | $this->smarty->assign('anidb', $firstAni->anidbid); |
||
| 105 | } else { |
||
| 106 | $this->smarty->assign('anidb', 1); |
||
| 107 | } |
||
| 108 | |||
| 109 | $this->smarty->assign( |
||
| 110 | [ |
||
| 111 | 'categorylist' => Category::getCategories(true, $this->userdata['categoryexclusions']), |
||
| 112 | 'parentcategorylist' => Category::getForMenu($this->userdata['categoryexclusions']), |
||
| 113 | ] |
||
| 114 | ); |
||
| 115 | |||
| 116 | $content = $this->smarty->fetch('rssdesc.tpl'); |
||
| 117 | $this->smarty->assign( |
||
| 118 | [ |
||
| 119 | 'content' => $content, |
||
| 120 | 'title' => $title, |
||
| 121 | 'meta_title' => $meta_title, |
||
| 122 | 'meta_keywords' => $meta_keywords, |
||
| 123 | 'meta_description' => $meta_description, |
||
| 124 | ] |
||
| 125 | ); |
||
| 126 | $this->pagerender(); |
||
| 127 | } |
||
| 128 | |||
| 129 | public function cartRss(Request $request) |
||
| 130 | { |
||
| 131 | $this->setPrefs(); |
||
| 132 | $rss = new RSS(['Settings' => $this->settings]); |
||
| 133 | $offset = 0; |
||
| 134 | $user = $this->userCheck($request->all()); |
||
| 135 | $outputXML = (! ($request->has('o') && $request->input('o') === 'json')); |
||
| 136 | $userAirDate = $request->has('airdate') && is_numeric($request->input('airdate')) ? abs($request->input('airdate')) : -1; |
||
| 137 | $userNum = ($request->has('num') && is_numeric($request->input('num')) ? abs($request->input('num')) : 0); |
||
| 138 | $userLimit = $request->has('limit') && is_numeric($request->input('limit')) ? $request->input('limit') : 100; |
||
| 139 | $userShow = $userAnidb = -1; |
||
| 140 | if ($request->has('show')) { |
||
| 141 | $userShow = ((int) $request->input('show') === 0 ? -1 : $request->input('show') + 0); |
||
| 142 | } elseif ($request->has('anidb')) { |
||
| 143 | $userAnidb = ((int) $request->input('anidb') === 0 ? -1 : $request->input('anidb') + 0); |
||
| 144 | } |
||
| 145 | |||
| 146 | $relData = $rss->getRss([-2], $userShow, $userAnidb, $user['user_id'], $userAirDate, $userLimit, $userNum); |
||
| 147 | $rss->output($relData, $user['params'], $outputXML, $offset, 'rss'); |
||
| 148 | } |
||
| 149 | |||
| 150 | /** |
||
| 151 | * @param \Illuminate\Http\Request $request |
||
| 152 | * @return \Illuminate\Http\JsonResponse |
||
| 153 | * @throws \Exception |
||
| 154 | * @throws \Throwable |
||
| 155 | */ |
||
| 156 | public function categoryFeedRss(Request $request) |
||
| 179 | } |
||
| 180 | |||
| 181 | /** |
||
| 182 | * @param \Illuminate\Http\Request $request |
||
| 183 | * @return array|\Illuminate\Http\JsonResponse |
||
| 184 | * @throws \Throwable |
||
| 185 | */ |
||
| 186 | private function userCheck(Request $request) |
||
| 228 | } |
||
| 229 | } |
||
| 230 |
Loading history...