HeaderParser::parse() - Code Metrics - Inspection of "Refactor binaries" - NNTmux/newznab-tmux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ae3f18...b8bba4 )

by Darko

created 2025-12-12 11:34 UTC

HeaderParser::parse() B

↳ Parent: HeaderParser

Complexity

Conditions	10
Paths	17

Size

Total Lines	60
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	28
dl	0
loc	60
rs	7.6666
c	0
b	0
f	0
cc	10
nc	17
nop	4

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace App\Services\Binaries;

use App\Services\BlacklistService;
use Illuminate\Support\Facades\Log;

/**
 * Parses and filters raw NNTP headers.
 */
final class HeaderParser
{
    private BlacklistService $blacklistService;

    private int $notYEnc = 0;

    private int $blacklisted = 0;

    public function __construct(?BlacklistService $blacklistService = null)
    {
        $this->blacklistService = $blacklistService ?? new BlacklistService;
    }

    /**
     * Reset counters for a new batch.
     */
    public function reset(): void
    {
        $this->notYEnc = 0;
        $this->blacklisted = 0;
    }

    /**
     * Parse and filter raw headers from NNTP.
     *
     * @param  array  $headers  Raw headers from NNTP
     * @param  string  $groupName  The newsgroup name
     * @param  bool  $partRepair  Whether this is a part repair scan
     * @param  array|null  $missingParts  Missing part numbers if part repair
     * @return array Filtered and parsed headers with article info
     */
    public function parse(
        array $headers,
        string $groupName,
        bool $partRepair = false,
        ?array $missingParts = null
    ): array {
        $parsed = [];
        $headersRepaired = [];

        foreach ($headers as $header) {
            // Check if we got the article
            if (! isset($header['Number'])) {
                continue;
            }

            // For part repair, only process missing parts
            if ($partRepair && $missingParts !== null) {
                if (! \in_array($header['Number'], $missingParts, false)) {
                    continue;
                }
                $headersRepaired[] = $header['Number'];
            }

            // Parse subject to get base name and part/total like "(12/45)"
            if (! preg_match('/^\s*(?!"Usenet Index Post)(.+)\s+\((\d+)\/(\d+)\)/', $header['Subject'], $matches)) {
                $this->notYEnc++;

                continue;
            }

            // Normalize to include yEnc if missing
            if (stripos($header['Subject'], 'yEnc') === false) {
                $matches[1] .= ' yEnc';
            }

            $header['matches'] = $matches;

            // Filter subject based on black/white list
            if ($this->blacklistService->isBlackListed($header, $groupName)) {
                $this->blacklisted++;

                continue;
            }

            // Ensure Bytes is set
            if (empty($header['Bytes'])) {
                $header['Bytes'] = $header[':bytes'] ?? 0;
            }

            $parsed[] = [
                'header' => $header,
                'repaired' => $partRepair,
            ];
        }

        return [
            'headers' => array_column($parsed, 'header'),
            'repaired' => $headersRepaired,
            'notYEnc' => $this->notYEnc,
            'blacklisted' => $this->blacklisted,
        ];
    }

    /**
     * Update blacklist last_activity for matched rules.
     */
    public function flushBlacklistUpdates(): void
    {
        $ids = $this->blacklistService->getAndClearIdsToUpdate();
        if (! empty($ids)) {
            $this->blacklistService->updateBlacklistUsage($ids);
        }
    }

    /**
     * Get count of non-yEnc headers filtered.
     */
    public function getNotYEncCount(): int
    {
        return $this->notYEnc;
    }

    /**
     * Get count of blacklisted headers.
     */
    public function getBlacklistedCount(): int
    {
        return $this->blacklisted;
    }

    /**
     * Extract highest and lowest article info from headers.
     */
    public function getArticleRange(array $headers): array
    {
        $result = [];
        $count = \count($headers);

        if ($count === 0) {
            return $result;
        }

        // Find first valid article
        for ($i = 0; $i < $count; $i++) {
            if (isset($headers[$i]['Number'])) {
                $result['firstArticleNumber'] = $headers[$i]['Number'];
                $result['firstArticleDate'] = $headers[$i]['Date'] ?? null;
                break;
            }
        }

        // Find last valid article
        for ($i = $count - 1; $i >= 0; $i--) {
            if (isset($headers[$i]['Number'])) {
                $result['lastArticleNumber'] = $headers[$i]['Number'];
                $result['lastArticleDate'] = $headers[$i]['Date'] ?? null;
                break;
            }
        }

        return $result;
    }
}



1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Services\Binaries;
6
7			use App\Services\BlacklistService;
8			use Illuminate\Support\Facades\Log;
9
10			/**
11			* Parses and filters raw NNTP headers.
12			*/
13			final class HeaderParser
14			{
15			private BlacklistService $blacklistService;
16
17			private int $notYEnc = 0;
18
19			private int $blacklisted = 0;
20
21			public function __construct(?BlacklistService $blacklistService = null)
22			{
23			$this->blacklistService = $blacklistService ?? new BlacklistService;
24			}
25
26			/**
27			* Reset counters for a new batch.
28			*/
29			public function reset(): void
30			{
31			$this->notYEnc = 0;
32			$this->blacklisted = 0;
33			}
34
35			/**
36			* Parse and filter raw headers from NNTP.
37			*
38			* @param array $headers Raw headers from NNTP
39			* @param string $groupName The newsgroup name
40			* @param bool $partRepair Whether this is a part repair scan
41			* @param array\|null $missingParts Missing part numbers if part repair
42			* @return array Filtered and parsed headers with article info
43			*/
44			public function parse(
45			array $headers,
46			string $groupName,
47			bool $partRepair = false,
48			?array $missingParts = null
49			): array {
50			$parsed = [];
51			$headersRepaired = [];
52
53			foreach ($headers as $header) {
54			// Check if we got the article
55			if (! isset($header['Number'])) {
56			continue;
57			}
58
59			// For part repair, only process missing parts
60			if ($partRepair && $missingParts !== null) {
61			if (! \in_array($header['Number'], $missingParts, false)) {
62			continue;
63			}
64			$headersRepaired[] = $header['Number'];
65			}
66
67			// Parse subject to get base name and part/total like "(12/45)"
68			if (! preg_match('/^\s*(?!"Usenet Index Post)(.+)\s+\((\d+)\/(\d+)\)/', $header['Subject'], $matches)) {
69			$this->notYEnc++;
70
71			continue;
72			}
73
74			// Normalize to include yEnc if missing
75			if (stripos($header['Subject'], 'yEnc') === false) {
76			$matches[1] .= ' yEnc';
77			}
78
79			$header['matches'] = $matches;
80
81			// Filter subject based on black/white list
82			if ($this->blacklistService->isBlackListed($header, $groupName)) {
83			$this->blacklisted++;
84
85			continue;
86			}
87
88			// Ensure Bytes is set
89			if (empty($header['Bytes'])) {
90			$header['Bytes'] = $header[':bytes'] ?? 0;
91			}
92
93			$parsed[] = [
94			'header' => $header,
95			'repaired' => $partRepair,
96			];
97			}
98
99			return [
100			'headers' => array_column($parsed, 'header'),
101			'repaired' => $headersRepaired,
102			'notYEnc' => $this->notYEnc,
103			'blacklisted' => $this->blacklisted,
104			];
105			}
106
107			/**
108			* Update blacklist last_activity for matched rules.
109			*/
110			public function flushBlacklistUpdates(): void
111			{
112			$ids = $this->blacklistService->getAndClearIdsToUpdate();
113			if (! empty($ids)) {
114			$this->blacklistService->updateBlacklistUsage($ids);
115			}
116			}
117
118			/**
119			* Get count of non-yEnc headers filtered.
120			*/
121			public function getNotYEncCount(): int
122			{
123			return $this->notYEnc;
124			}
125
126			/**
127			* Get count of blacklisted headers.
128			*/
129			public function getBlacklistedCount(): int
130			{
131			return $this->blacklisted;
132			}
133
134			/**
135			* Extract highest and lowest article info from headers.
136			*/
137			public function getArticleRange(array $headers): array
138			{
139			$result = [];
140			$count = \count($headers);
141
142			if ($count === 0) {
143			return $result;
144			}
145
146			// Find first valid article
147			for ($i = 0; $i < $count; $i++) {
148			if (isset($headers[$i]['Number'])) {
149			$result['firstArticleNumber'] = $headers[$i]['Number'];
150			$result['firstArticleDate'] = $headers[$i]['Date'] ?? null;
151			break;
152			}
153			}
154
155			// Find last valid article
156			for ($i = $count - 1; $i >= 0; $i--) {
157			if (isset($headers[$i]['Number'])) {
158			$result['lastArticleNumber'] = $headers[$i]['Number'];
159			$result['lastArticleDate'] = $headers[$i]['Date'] ?? null;
160			break;
161			}
162			}
163
164			return $result;
165			}
166			}
167
168

NNTmux / newznab-tmux

Push — master ( ae3f18...b8bba4 )

HeaderParser::parse() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like