Blacklight\NZBImport::scanNZBFile()

Complexity

Conditions	21
Paths	1236

Size

Total Lines	111
Code Lines	67

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function scanNZBFile(&$nzbXML, $useNzbName = false): bool
    {
        $binary_names = [];
        $totalFiles = $totalSize = $groupID = 0;
        $isBlackListed = $groupName = $firstName = $posterName = $postDate = false;

        // Go through the NZB, get the details, look if it's blacklisted, look if we have the groups.
        foreach ($nzbXML->file as $file) {
            $binary_names[] = $file['subject'];
            $totalFiles++;
            $groupID = -1;

            // Get the nzb info.
            if ($firstName === false) {
                $firstName = (string) $file->attributes()->subject;
            }
            if ($posterName === false) {
                $posterName = (string) $file->attributes()->poster;
            }
            if ($postDate === false) {
                $postDate = date('Y-m-d H:i:s', (string) $file->attributes()->date);

(string)$file->attributes()->date of type string is incompatible with the type integer expected by parameter $timestamp of date().

            }

            // Make a fake message array to use to check the blacklist.
            $msg = ['Subject' => (string) $file->attributes()->subject, 'From' => (string) $file->attributes()->poster, 'Message-ID' => ''];

            // Get the group names, group_id, check if it's blacklisted.
            $groupArr = [];
            foreach ($file->groups->group as $group) {
                $group = (string) $group;

                // If group_id is -1 try to get a group_id.
                if ($groupID === -1) {
                    if (array_key_exists($group, $this->allGroups)) {
                        $groupID = $this->allGroups[$group];
                        if (! $groupName) {
                            $groupName = $group;
                        }
                    } else {
                        $group = Group::isValidGroup($group);
                        if ($group !== false) {
                            $groupID = Group::addGroup([
                                'name' => $group,
                                'description' => 'Added by NZBimport script.',
                                'backfill_target' => 1,
                                'minfilestoformrelease' => '',
                                'minsizetoformrelease' => '',
                                'first_record' => 0,
                                'last_record' => 0,
                                'active' => 0,
                                'backfill' => 0,
                            ]);
                            $this->allGroups[$group] = $groupID;

                            $this->echoOut("Adding missing group: ($group)");
                        }
                    }
                }
                // Add all the found groups to an array.
                $groupArr[] = $group;

                // Check if this NZB is blacklisted.
                if ($this->binaries->isBlackListed($msg, $group)) {

It seems like $group can also be of type false; however, parameter $groupName of Blacklight\Binaries::isBlackListed() does only seem to accept string, maybe add an additional type check?

                    $isBlackListed = true;
                    break;
                }
            }

            // If we found a group and it's not blacklisted.
            if ($groupID !== -1 && ! $isBlackListed) {

                // Get the size of the release.
                if (count($file->segments->segment) > 0) {
                    foreach ($file->segments->segment as $segment) {
                        $totalSize += (int) $segment->attributes()->bytes;
                    }
                }
            } else {
                if ($isBlackListed) {
                    $errorMessage = 'Subject is blacklisted: '.utf8_encode(trim($firstName));

It seems like $firstName can also be of type false; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

                } else {
                    $errorMessage = 'No group found for '.$firstName.' (one of '.implode(', ', $groupArr).' are missing';

Are you sure $firstName of type false|string can be used in concatenation?

                }
                $this->echoOut($errorMessage);

                return false;
            }
        }

        // Sort values alphabetically but keep the keys intact
        if (count($binary_names) > 0) {
            asort($binary_names);
            foreach ($nzbXML->file as $file) {
                if ($file['subject'] == $binary_names[0]) {
                    $this->nzbGuid = md5($file->segments->segment);
                    break;
                }
            }
        }

        // Try to insert the NZB details into the DB.
        return $this->insertNZB(
            [
                'subject'    => $firstName,
                'useFName'   => $useNzbName,
                'postDate'   => empty($postDate) ? date('Y-m-d H:i:s') : $postDate,
                'from'       => empty($posterName) ? '' : $posterName,
                'groups_id'   => $groupID,
                'groupName'  => $groupName,
                'totalFiles' => $totalFiles,
                'totalSize'  => $totalSize,
            ]