Blacklight\NNTP::doConnect()

Complexity

Conditions	35
Paths	5409

Size

Total Lines	142
Code Lines	75

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function doConnect($compression = true, $alternate = false)
    {
        if (// (Alternate is wanted, AND current server is alt,  OR  Alternate is not wanted AND current is main.)         AND
        (($alternate && $this->_currentServer === env('NNTP_SERVER_A')) || (! $alternate && $this->_currentServer === env('NNTP_SERVER'))) &&

Consider adding parentheses for clarity. Current Interpretation: {currentAssign}, Probably Intended Meaning: {alternativeAssign}

            // Don't reconnect to usenet if:
            // We are already connected to usenet.
            parent::_isConnected()

        ) {
            return true;
        }

        $this->doQuit();

        $ret = $connected = $cError = $aError = false;

        // Set variables to connect based on if we are using the alternate provider or not.
        if (! $alternate) {
            $sslEnabled = env('NNTP_SSLENABLED') ? true : false;
            $this->_currentServer = env('NNTP_SERVER');
            $this->_currentPort = env('NNTP_PORT');
            $userName = env('NNTP_USERNAME');
            $password = env('NNTP_PASSWORD');
            $socketTimeout = ! empty(env('NNTP_SOCKET_TIMEOUT')) ? env('NNTP_SOCKET_TIMEOUT') : $this->_socketTimeout;
        } else {
            $sslEnabled = env('NNTP_SSLENABLED_A') ? true : false;
            $this->_currentServer = env('NNTP_SERVER_A');
            $this->_currentPort = env('NNTP_PORT_A');
            $userName = env('NNTP_USERNAME_A');
            $password = env('NNTP_PASSWORD_A');
            $socketTimeout = ! empty(env('NNTP_SOCKET_TIMEOUT_A')) ? env('NNTP_SOCKET_TIMEOUT_A') : $this->_socketTimeout;
        }

        $enc = ($sslEnabled ? ' (ssl)' : ' (non-ssl)');
        $sslEnabled = ($sslEnabled ? 'tls' : false);

        // Try to connect until we run of out tries.
        $retries = $this->_nntpRetries;
        while (true) {
            $retries--;
            $authenticated = false;

            // If we are not connected, try to connect.
            if (! $connected) {
                $ret = $this->connect($this->_currentServer, $sslEnabled, $this->_currentPort, 5, $socketTimeout);

It seems like $this->_currentServer can also be of type array; however, parameter $host of Net_NNTP_Client::connect() does only seem to accept string, maybe add an additional type check?

            }

            // Check if we got an error while connecting.
            $cErr = $this->isError($ret);

            // If no error, we are connected.
            if (! $cErr) {
                // Say that we are connected so we don't retry.
                $connected = true;
                // When there is no error it returns bool if we are allowed to post or not.
                $this->_postingAllowed = $ret;
            } else {
                // Only fetch the message once.
                if (! $cError) {
                    $cError = $ret->getMessage();
                }
            }

            // If error, try to connect again.
            if ($cErr && $retries > 0) {
                continue;
            }

            // If we have no more retries and could not connect, return an error.
            if ($retries === 0 && ! $connected) {
                $message =
                    'Cannot connect to server '.
                    $this->_currentServer.
                    $enc.
                    ': '.
                    $cError;

                return $this->throwError(ColorCLI::error($message));
            }

            // If we are connected, try to authenticate.
            if ($connected === true && $authenticated === false) {

                // If the username is empty it probably means the server does not require a username.
                if ($userName === '') {
                    $authenticated = true;

                // Try to authenticate to usenet.
                } else {
                    $ret2 = $this->authenticate($userName, $password);

It seems like $password can also be of type array; however, parameter $pass of Net_NNTP_Client::authenticate() does only seem to accept string, maybe add an additional type check?

                    // Check if there was an error authenticating.
                    $aErr = $this->isError($ret2);

                    // If there was no error, then we are authenticated.
                    if (! $aErr) {
                        $authenticated = true;
                    } elseif (! $aError) {
                        $aError = $ret2->getMessage();
                    }

                    // If error, try to authenticate again.
                    if ($aErr && $retries > 0) {
                        continue;
                    }

                    // If we ran out of retries, return an error.
                    if ($retries === 0 && $authenticated === false) {
                        $message =
                            'Cannot authenticate to server '.
                            $this->_currentServer.
                            $enc.
                            ' - '.
                            $userName.
                            ' ('.$aError.')';

                        return $this->throwError(ColorCLI::error($message));
                    }
                }
            }

            // If we are connected and authenticated, try enabling compression if we have it enabled.
            if ($connected === true && $authenticated === true) {
                // Check if we should use compression on the connection.
                if ($compression === false || (int) Settings::settingValue('..compressedheaders') === 0) {

'..compressedheaders' of type string is incompatible with the type boolean|array expected by parameter $setting of App\Models\Settings::settingValue().

                    $this->_compressionSupported = false;
                }

                return true;
            }
            // If we reached this point and have not connected after all retries, break out of the loop.
            if ($retries === 0) {
                break;
            }

            // Sleep .4 seconds between retries.
            usleep(400000);
        }
        // If we somehow got out of the loop, return an error.
        $message = 'Unable to connect to '.$this->_currentServer.$enc;

        return $this->throwError(ColorCLI::error($message));
    }