Backfill::backfillAllGroups() - Code Metrics - Inspection of "Update scrutinizer config" - NNTmux/newznab-tmux - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Branch — dev (4bcb34)

by Darko
created 2018-03-13 23:45 UTC
Backfill::backfillAllGroups() C

↳ Parent: Backfill
Complexity

Conditions	13
Paths	198
Size

Total Lines	58
Code Lines	36
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	13
eloc	36
nc	198
nop	3
dl	0
loc	58
rs	5.8796
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

namespace Blacklight;

use App\Models\Group;
use Blacklight\db\DB;
use App\Models\Settings;

class Backfill
{
    /**
     * @var \Blacklight\db\DB
     */
    public $pdo;

    /**
     * @var
     */
    protected $_binaries;

    /**
     * @var \Blacklight\NNTP
     */
    protected $_nntp;
    /**
     * Should we use compression for headers?
     *
     * @var bool
     */
    protected $_compressedHeaders;

    /**
     * Log and or echo debug.
     * @var bool
     */
    protected $_debug = false;

    /**
     * Echo to cli?
     * @var bool
     */
    protected $_echoCLI;

    /**
     * How far back should we go on safe back fill?
     *
     * @var string
     */
    protected $_safeBackFillDate;

    /**
     * @var string
     */
    protected $_safePartRepair;

    /**
     * Should we disable the group if we have backfilled far enough?
     * @var bool
     */
    protected $_disableBackfillGroup;

    /**
     * Constructor.
     *
     * @param array $options Class instances / Echo to cli?
     *
     * @throws \Exception
     */
    public function __construct(array $options = [])
    {
        $defaults = [
            'Echo'      => true,
            'Logger'    => null,
            'Groups'    => null,
            'NNTP'      => null,
            'Settings'  => null,
        ];
        $options += $defaults;

        $this->_echoCLI = ($options['Echo'] && config('nntmux.echocli'));

        $this->pdo = ($options['Settings'] instanceof DB ? $options['Settings'] : new DB());
        $this->_nntp = (
            $options['NNTP'] instanceof NNTP
            ? $options['NNTP'] : new NNTP(['Settings' => $this->pdo])
        );

        $this->_compressedHeaders = (int) Settings::settingValue('..compressedheaders') === 1;
        $this->_compressedHeaders = (int) Settings::settingValue(/** @scrutinizer ignore-type */ '..compressedheaders') === 1;
        $this->_safeBackFillDate = Settings::settingValue('..safebackfilldate') !== '' ? (string) Settings::settingValue('safebackfilldate') : '2008-08-14';
        $this->_safePartRepair = (int) Settings::settingValue('..safepartrepair') === 1 ? 'update' : 'backfill';
        $this->_disableBackfillGroup = (int) Settings::settingValue('..disablebackfillgroup') === 1;
    }

    /**
     * Backfill all the groups up to user specified time/date.
     *
     * @param string     $groupName
     * @param string|int $articles
     * @param string     $type
     *
     * @return void
     * @throws \Exception
     */
    public function backfillAllGroups($groupName = '', $articles = '', $type = ''): void
    {
        $res = [];
        if ($groupName !== '') {
            $grp = Group::getByName($groupName);
            if ($grp) {
                $res = [$grp];
            }
        } else {
            $res = Group::getActiveBackfill($type);
        }

        $groupCount = count($res);
        if ($groupCount > 0) {
            $counter = 1;
            $allTime = microtime(true);
            $dMessage = (
                'Backfilling: '.
                $groupCount.
                ' group(s) - Using compression? '.
                ($this->_compressedHeaders ? 'Yes' : 'No')
            );

            if ($this->_echoCLI) {
                ColorCLI::doEcho(ColorCLI::header($dMessage), true);
            }

            $this->_binaries = new Binaries(
                ['NNTP' => $this->_nntp, 'Echo' => $this->_echoCLI, 'Settings' => $this->pdo]
            );

            if ($articles !== '' && ! is_numeric($articles)) {
                $articles = 20000;
            }

            // Loop through groups.
            foreach ($res as $groupArr) {
                if ($groupName === '') {
                    $dMessage = 'Starting group '.$counter.' of '.$groupCount;

                    if ($this->_echoCLI) {
                        ColorCLI::doEcho(ColorCLI::header($dMessage), true);
                    }
                }
                $this->backfillGroup($groupArr, $groupCount - $counter, $articles);
                $counter++;
            }

            $dMessage = 'Backfilling completed in '.number_format(microtime(true) - $allTime, 2).' seconds.';

            if ($this->_echoCLI) {
                ColorCLI::doEcho(ColorCLI::primary($dMessage), true);
            }
        } else {
            $dMessage = 'No groups specified. Ensure groups are added to database for updating.';

            if ($this->_echoCLI) {
                ColorCLI::doEcho(ColorCLI::warning($dMessage), true);
            }
        }
    }

    /**
     * Backfill single group.
     *
     * @param array      $groupArr
     * @param int        $left
     * @param int|string $articles
     *
     * @return void
     * @throws \Exception
     */
    public function backfillGroup($groupArr, $left, $articles = ''): void
    {
        // Start time for this group.
        $startGroup = microtime(true);

        $this->_binaries->logIndexerStart();

        $groupName = str_replace('alt.binaries', 'a.b', $groupArr['name']);

        // If our local oldest article 0, it means we never ran update_binaries on the group.
        if ($groupArr['first_record'] <= 0) {
            $dMessage =
                'You need to run update_binaries on '.
                $groupName.
                '. Otherwise the group is dead, you must disable it.';

            if ($this->_echoCLI) {
                ColorCLI::doEcho(ColorCLI::error($dMessage), true);
            }

            return;
        }

        // Select group, here, only once
        $data = $this->_nntp->selectGroup($groupArr['name']);
        if ($this->_nntp->isError($data)) {
            $data = $this->_nntp->dataError($this->_nntp, $groupArr['name']);
            if ($this->_nntp->isError($data)) {
                return;
            }
        }

        if ($this->_echoCLI) {
            ColorCLI::doEcho(ColorCLI::primary('Processing '.$groupName), true);
        }

        // Check if this is days or post backfill.
        $postCheck = $articles !== '';

        // Get target post based on date or user specified number.
        $targetpost = (string) (
            $postCheck
            ?
            round($groupArr['first_record'] - $articles)
            :
            $this->_binaries->daytopost($groupArr['backfill_target'], $data)
        );

        // Check if target post is smaller than server's oldest, set it to oldest if so.
        if ($targetpost < $data['first']) {
            $targetpost = $data['first'];
        }

        // Check if our target post is newer than our oldest post or if our local oldest article is older than the servers oldest.
        if ($targetpost >= $groupArr['first_record'] || $groupArr['first_record'] <= $data['first']) {
            $dMessage =
                'We have hit the maximum we can backfill for '.
                $groupName.
                ($this->_disableBackfillGroup ? ', disabling backfill on it.' :
                ', skipping it, consider disabling backfill on it.');

            if ($this->_disableBackfillGroup) {
                Group::updateGroupStatus($groupArr['id'], 'backfill', 0);
            }

            if ($this->_echoCLI) {
                ColorCLI::doEcho(ColorCLI::notice($dMessage), true);
            }

            return;
        }

        if ($this->_echoCLI) {
            ColorCLI::doEcho(
                ColorCLI::primary(
                    'Group '.
                    $groupName.
                    "'s oldest article is ".
                    number_format($data['first']).
                    ', newest is '.
                    number_format($data['last']).
                    ".\nOur target article is ".
                    number_format($targetpost).
                    '. Our oldest article is article '.
                    number_format($groupArr['first_record']).
                    '.'
                ), true
            );
        }

        // Set first and last, moving the window by max messages.
        $last = ($groupArr['first_record'] - 1);
        // Set the initial "chunk".
        $first = ($last - $this->_binaries->messageBuffer + 1);

        // Just in case this is the last chunk we needed.
        if ($targetpost > $first) {
            $first = $targetpost;
        }

        $done = false;
        while ($done === false) {
            if ($this->_echoCLI) {
                ColorCLI::doEcho(
                    color('Getting '.
                    number_format($last - $first + 1).
                    ' articles from '.
                    $groupName.
                    ', '.
                    $left.
                    ' group(s) left. ('.
                    number_format($first - $targetpost).
                    ' articles in queue')->fg('yellow'), true);
            }

            flush();
            $lastMsg = $this->_binaries->scan($groupArr, $first, $last, $this->_safePartRepair);

            // Get the oldest date.
            if (isset($lastMsg['firstArticleDate'])) {
                // Try to get it from the oldest pulled article.
                $newdate = strtotime($lastMsg['firstArticleDate']);
            } else {
                // If above failed, try to get it with postdate method.
                $newdate = $this->_binaries->postdate($first, $data);
            }

            $this->pdo->queryExec(
                sprintf(
                    '
					UPDATE groups
					SET first_record_postdate = %s, first_record = %s, last_updated = NOW()
					WHERE id = %d',
                    $this->pdo->from_unixtime($newdate),
                    $this->pdo->escapeString($first),
                    $groupArr['id']
                )
            );
            if ($first === $targetpost) {
                $done = true;
            } else {
                // Keep going: set new last, new first, check for last chunk.
                $last = ($first - 1);
                $first = ($last - $this->_binaries->messageBuffer + 1);
                if ($targetpost > $first) {
                    $first = $targetpost;
                }
            }
        }

        if ($this->_echoCLI) {
            ColorCLI::doEcho(
                ColorCLI::primary(
                    PHP_EOL.
                    'Group '.
                    $groupName.
                    ' processed in '.
                    number_format(microtime(true) - $startGroup, 2).
                    ' seconds.'
                ),
                true
            );
        }
    }

    /**
     * Safe backfill using posts. Going back to a date specified by the user on the site settings.
     * This does 1 group for x amount of parts until it reaches the date.
     *
     * @param string $articles
     *
     * @return void
     * @throws \Exception
     */
    public function safeBackfill($articles = ''): void
    {
        $groupname = $this->pdo->queryOneRow(
            sprintf(
                '
				SELECT name FROM groups
				WHERE first_record_postdate BETWEEN %s AND NOW()
				AND backfill = 1
				ORDER BY name ASC',
                $this->pdo->escapeString($this->_safeBackFillDate)
            )
        );

        if (! $groupname) {
            $dMessage =
                'No groups to backfill, they are all at the target date '.
                $this->_safeBackFillDate.
                ', or you have not enabled them to be backfilled in the groups page.'.PHP_EOL;
            exit($dMessage);

        }
        $this->backfillAllGroups($groupname['name'], $articles);
    }
}

NNTmux / newznab-tmux

Branch — dev (4bcb34)

Backfill::backfillAllGroups() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
