NNTmux /
newznab-tmux
| Total Complexity | 47 |
| Total Lines | 278 |
| Duplicated Lines | 0 % |
| Changes | 4 | ||
| Bugs | 2 | Features | 0 |
Complex classes like ApiV2Controller often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ApiV2Controller, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | class ApiV2Controller extends BasePageController |
||
| 23 | { |
||
| 24 | private ApiController $api; |
||
| 25 | |||
| 26 | public function __construct() |
||
| 29 | } |
||
| 30 | |||
| 31 | public function capabilities(): JsonResponse |
||
| 60 | } |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @throws \Throwable |
||
| 64 | */ |
||
| 65 | public function movie(Request $request): JsonResponse |
||
| 66 | { |
||
| 67 | if ($request->missing('api_token') || ($request->has('api_token') && $request->isNotFilled('api_token'))) { |
||
| 68 | return response()->json(['error' => 'Missing parameter (apikey)'], 403); |
||
| 69 | } |
||
| 70 | $releases = new Releases(); |
||
| 71 | $user = User::query()->where('api_token', $request->input('api_token'))->first(); |
||
| 72 | $minSize = $request->has('minsize') && $request->input('minsize') > 0 ? $request->input('minsize') : 0; |
||
| 73 | $maxAge = $this->api->maxAge($request); |
||
| 74 | $catExclusions = User::getCategoryExclusionForApi($request); |
||
| 75 | UserRequest::addApiRequest($request->input('api_token'), $request->getRequestUri()); |
||
| 76 | event(new UserAccessedApi($user)); |
||
| 77 | |||
| 78 | $imdbId = $request->has('imdbid') && $request->filled('imdbid') ? $request->input('imdbid') : -1; |
||
| 79 | $tmdbId = $request->has('tmdbid') && $request->filled('tmdbid') ? $request->input('tmdbid') : -1; |
||
| 80 | $traktId = $request->has('traktid') && $request->filled('traktid') ? $request->input('traktid') : -1; |
||
| 81 | |||
| 82 | $relData = $releases->moviesSearch( |
||
| 83 | $imdbId, |
||
| 84 | $tmdbId, |
||
| 85 | $traktId, |
||
| 86 | $this->api->offset($request), |
||
| 87 | $this->api->limit($request), |
||
| 88 | $request->input('id') ?? '', |
||
| 89 | $this->api->categoryID($request), |
||
| 90 | $maxAge, |
||
|
Bug
introduced
by
|
|||
| 91 | $minSize, |
||
| 92 | $catExclusions |
||
| 93 | ); |
||
| 94 | |||
| 95 | $time = UserRequest::whereUsersId($user->id)->min('timestamp'); |
||
| 96 | $apiOldestTime = $time !== null ? Carbon::createFromTimeString($time)->toRfc2822String() : ''; |
||
| 97 | $grabTime = UserDownload::whereUsersId($user->id)->min('timestamp'); |
||
| 98 | $oldestGrabTime = $grabTime !== null ? Carbon::createFromTimeString($grabTime)->toRfc2822String() : ''; |
||
| 99 | |||
| 100 | $response = [ |
||
| 101 | 'Total' => $relData[0]->_totalrows ?? 0, |
||
| 102 | 'apiCurrent' => UserRequest::getApiRequests($user->id), |
||
| 103 | 'apiMax' => $user->role->apirequests, |
||
| 104 | 'grabCurrent' => UserDownload::getDownloadRequests($user->id), |
||
| 105 | 'grabMax' => $user->role->downloadrequests, |
||
| 106 | 'apiOldestTime' => $apiOldestTime, |
||
| 107 | 'grabOldestTime' => $oldestGrabTime, |
||
| 108 | 'Results' => fractal($relData, new ApiTransformer($user)), |
||
| 109 | ]; |
||
| 110 | |||
| 111 | return response()->json($response); |
||
| 112 | } |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @throws \Exception |
||
| 116 | * @throws \Throwable |
||
| 117 | */ |
||
| 118 | public function apiSearch(Request $request): JsonResponse |
||
| 177 | } |
||
| 178 | |||
| 179 | /** |
||
| 180 | * @throws \Exception |
||
| 181 | * @throws \Throwable |
||
| 182 | */ |
||
| 183 | public function tv(Request $request): JsonResponse |
||
| 184 | { |
||
| 185 | if ($request->missing('api_token') || $request->isNotFilled('api_token')) { |
||
| 186 | return response()->json(['error' => 'Missing parameter (api_token)'], 403); |
||
| 187 | } |
||
| 188 | $releases = new Releases(); |
||
| 189 | $user = User::query()->where('api_token', $request->input('api_token'))->first(); |
||
| 190 | if ($user === null) { |
||
| 191 | return response()->json(['error' => 'Invalid API Token'], 403); |
||
| 192 | } |
||
| 193 | $catExclusions = User::getCategoryExclusionForApi($request); |
||
| 194 | $minSize = $request->has('minsize') && $request->input('minsize') > 0 ? $request->input('minsize') : 0; |
||
| 195 | $this->api->verifyEmptyParameter($request, 'id'); |
||
| 196 | $this->api->verifyEmptyParameter($request, 'vid'); |
||
| 197 | $this->api->verifyEmptyParameter($request, 'tvdbid'); |
||
| 198 | $this->api->verifyEmptyParameter($request, 'traktid'); |
||
| 199 | $this->api->verifyEmptyParameter($request, 'rid'); |
||
| 200 | $this->api->verifyEmptyParameter($request, 'tvmazeid'); |
||
| 201 | $this->api->verifyEmptyParameter($request, 'imdbid'); |
||
| 202 | $this->api->verifyEmptyParameter($request, 'tmdbid'); |
||
| 203 | $this->api->verifyEmptyParameter($request, 'season'); |
||
| 204 | $this->api->verifyEmptyParameter($request, 'ep'); |
||
| 205 | $maxAge = $this->api->maxAge($request); |
||
| 206 | UserRequest::addApiRequest($request->input('api_token'), $request->getRequestUri()); |
||
| 207 | event(new UserAccessedApi($user)); |
||
| 208 | |||
| 209 | $siteIdArr = [ |
||
| 210 | 'id' => $request->input('vid') ?? null, |
||
| 211 | 'tvdb' => $request->input('tvdbid') ?? null, |
||
| 212 | 'trakt' => $request->input('traktid') ?? null, |
||
| 213 | 'tvrage' => $request->input('rid') ?? null, |
||
| 214 | 'tvmaze' => $request->input('tvmazeid') ?? null, |
||
| 215 | 'imdb' => $request->input('imdbid') ?? null, |
||
| 216 | 'tmdb' => $request->input('tmdbid') ?? null, |
||
| 217 | ]; |
||
| 218 | |||
| 219 | // Process season only queries or Season and Episode/Airdate queries |
||
| 220 | |||
| 221 | $series = $request->input('season') ?? ''; |
||
| 222 | $episode = $request->input('ep') ?? ''; |
||
| 223 | |||
| 224 | if (preg_match('#^(19|20)\d{2}$#', $series, $year) && str_contains($episode, '/')) { |
||
| 225 | $airDate = str_replace('/', '-', $year[0].'-'.$episode); |
||
| 226 | } |
||
| 227 | |||
| 228 | $relData = $releases->apiTvSearch( |
||
| 229 | $siteIdArr, |
||
| 230 | $series, |
||
| 231 | $episode, |
||
| 232 | $airDate ?? '', |
||
| 233 | $this->api->offset($request), |
||
| 234 | $this->api->limit($request), |
||
| 235 | $request->input('id') ?? '', |
||
| 236 | $this->api->categoryID($request), |
||
| 237 | $maxAge, |
||
| 238 | $minSize, |
||
| 239 | $catExclusions |
||
| 240 | ); |
||
| 241 | |||
| 242 | $time = UserRequest::whereUsersId($user->id)->min('timestamp'); |
||
| 243 | $apiOldestTime = $time !== null ? Carbon::createFromTimeString($time)->toRfc2822String() : ''; |
||
| 244 | $grabTime = UserDownload::whereUsersId($user->id)->min('timestamp'); |
||
| 245 | $oldestGrabTime = $grabTime !== null ? Carbon::createFromTimeString($grabTime)->toRfc2822String() : ''; |
||
| 246 | |||
| 247 | $response = [ |
||
| 248 | 'Total' => $relData[0]->_totalrows ?? 0, |
||
| 249 | 'apiCurrent' => UserRequest::getApiRequests($user->id), |
||
| 250 | 'apiMax' => $user->role->apirequests, |
||
| 251 | 'grabCurrent' => UserDownload::getDownloadRequests($user->id), |
||
| 252 | 'grabMax' => $user->role->downloadrequests, |
||
| 253 | 'apiOldestTime' => $apiOldestTime, |
||
| 254 | 'grabOldestTime' => $oldestGrabTime, |
||
| 255 | 'Results' => fractal($relData, new ApiTransformer($user)), |
||
| 256 | ]; |
||
| 257 | |||
| 258 | return response()->json($response); |
||
| 259 | } |
||
| 260 | |||
| 261 | public function getNzb(Request $request): \Illuminate\Foundation\Application|JsonResponse|\Illuminate\Routing\Redirector|RedirectResponse|\Illuminate\Contracts\Foundation\Application |
||
| 278 | } |
||
| 279 | |||
| 280 | public function details(Request $request): JsonResponse |
||
| 300 | } |
||
| 301 | } |
||
| 302 |
Loading history...