App\Http\Controllers\Admin\AdminNzbController::import()

Complexity

Conditions	10
Paths	35

Size

Total Lines	51
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function import(Request $request)
    {
        $this->setAdminPrefs();

        $filesToProcess = [];
        if ($this->isPostBack()) {
            $useNzbName = false;
            $deleteNZB = true;
            // Get the list of NZB files from php /tmp folder if nzb files were uploaded.
            if (isset($_FILES['uploadedfiles'])) {
                foreach ($_FILES['uploadedfiles']['error'] as $key => $error) {
                    if ($error === UPLOAD_ERR_OK) {
                        $tmp_name = $_FILES['uploadedfiles']['tmp_name'][$key];
                        $name = $_FILES['uploadedfiles']['name'][$key];

The assignment to $name is dead and can be removed.

                        $filesToProcess[] = $tmp_name;
                    }
                }
            } else {

                // Check if the user wants to use the file name as the release name.
                $useNzbName = ($request->has('usefilename') && $request->input('usefilename') === 'on');

                // Check if the user wants to delete the NZB file when done importing.
                $deleteNZB = ($request->has('deleteNZB') && $request->input('deleteNZB') === 'on');

                // Get the path the user set in the browser if he put one.
                $path = ($request->has('folder') ? $request->input('folder') : '');
                if (substr($path, \strlen($path) - 1) !== DS) {
                    $path .= DS;
                }

                // Get the files from the user specified path.
                $filesToProcess = glob($path.'*.nzb');
            }

            if (\count($filesToProcess) > 0) {

It seems like $filesToProcess can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

                // Create a new instance of NZBImport and send it the file locations.
                $NZBImport = new NZBImport(['Browser' => true, 'Settings' => null]);

                $this->smarty->assign(

The method assign() does not exist on Illuminate\Foundation\Application.

                    'output',
                    $NZBImport->beginImport($filesToProcess, $useNzbName, $deleteNZB)

It seems like $filesToProcess can also be of type false; however, parameter $filesToProcess of Blacklight\NZBImport::beginImport() does only seem to accept array, maybe add an additional type check?

                );
            }
        }

        $meta_title = $title = 'Import Nzbs';
        $content = $this->smarty->fetch('nzb-import.tpl');

The method fetch() does not exist on Illuminate\Foundation\Application.

        $this->smarty->assign(compact('title', 'meta_title', 'content'));
        $this->adminrender();
    }