AdminCollectionRegexesController::edit() - Code Metrics - Inspection of "Use Laravel framework 8" - NNTmux/newznab-tmux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( c55b95...34fb50 )

by Darko

created 2020-09-28 19:30 UTC

AdminCollectionRegexesController::edit() B

↳ Parent: AdminCollectionRegexesController

Complexity

Conditions	10
Paths	4

Size

Total Lines	59
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	39
dl	0
loc	59
rs	7.6666
c	0
b	0
f	0
cc	10
nc	4
nop	1

How to fix Long Method Complexity

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Controllers\BasePageController;
use App\Models\Category;
use Blacklight\Regexes;
use Illuminate\Http\Request;

class AdminCollectionRegexesController extends BasePageController
{
    /**
     * @param \Illuminate\Http\Request $request
     *
     * @throws \Exception
     */
    public function index(Request $request)
    {
        $this->setAdminPrefs();
        $regexes = new Regexes(['Settings' => null, 'Table_Name' => 'collection_regexes']);

        $meta_title = $title = 'Collections Regex List';

        $group = ($request->has('group') && ! empty($request->input('group')) ? $request->input('group') : '');
        $regex = $regexes->getRegex($group);
        $this->smarty->assign(compact('group', 'regex'));
                       assign(compact('group', 'regex'));

        $content = $this->smarty->fetch('collection_regexes-list.tpl');
        $content = $this->smarty->fetch('collection_regexes-list.tpl');

        $this->smarty->assign(compact('title', 'meta_title', 'content'));

        $this->adminrender();
    }

    /**
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws \Exception
     */
    public function edit(Request $request)
    {
        $this->setAdminPrefs();
        $regexes = new Regexes(['Settings' => null, 'Table_Name' => 'collection_regexes']);
        $error = '';
        $regex = ['id' => '', 'regex' => '', 'description' => '', 'group_regex' => '', 'ordinal' => '', 'status' => 1];

        switch ($request->input('action') ?? 'view') {
            case 'submit':
                if (empty($request->input('group_regex'))) {
                    $error = 'Group regex must not be empty!';
                    break;
                }

                if (empty($request->input('regex'))) {
                    $error = 'Regex cannot be empty';
                    break;
                }

                if (empty($request->input('description'))) {
                    $request->merge(['description' => '']);
                }

                if (! is_numeric($request->input('ordinal')) || $request->input('ordinal') < 0) {
                    $error = 'Ordinal must be a number, 0 or higher.';
                    break;
                }

                if (empty($request->input('id'))) {
                    $regexes->addRegex($request->all());
                } else {
                    $regexes->updateRegex($request->all());
                }

                return redirect('admin/collection_regexes-list');
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'view':
            default:
                if ($request->has('id')) {
                    $meta_title = $title = 'Collections Regex Edit';
                    $regex = $regexes->getRegexByID($request->input('id'));
                } else {
                    $meta_title = $title = 'Collections Regex Add';
                    $regex += ['status' => 1];
                }
                break;
        }

        $this->smarty->assign('regex', $regex);
        $this->smarty->assign('error', $error);
        $this->smarty->assign('status_ids', [Category::STATUS_ACTIVE, Category::STATUS_INACTIVE]);
        $this->smarty->assign('status_names', ['Yes', 'No']);

        $content = $this->smarty->fetch('collection_regexes-edit.tpl');

        $this->smarty->assign(compact('title', 'meta_title', 'content'));

        $this->adminrender();
    }

    /**
     * @param \Illuminate\Http\Request $request
     *
     * @throws \Exception
     */
    public function testRegex(Request $request)
    {
        $this->setAdminPrefs();
        $meta_title = $title = 'Collections Regex Test';

        $group = trim($request->has('group') && ! empty($request->input('group')) ? $request->input('group') : '');
        $regex = trim($request->has('regex') && ! empty($request->input('regex')) ? $request->input('regex') : '');
        $limit = ($request->has('limit') && is_numeric($request->input('limit')) ? $request->input('limit') : 50);
        $this->smarty->assign(['group' => $group, 'regex' => $regex, 'limit' => $limit]);

        if ($group && $regex) {
            $this->smarty->assign('data', (new Regexes(['Settings' => null, 'Table_Name' => 'collection_regexes']))->testCollectionRegex($group, $regex, $limit));
        }

        $content = $this->smarty->fetch('collection_regexes-test.tpl');

        $this->smarty->assign(compact('title', 'meta_title', 'content'));

        $this->adminrender();
    }
}


NNTmux / newznab-tmux

Push — dev ( c55b95...34fb50 )

AdminCollectionRegexesController::edit() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like