| Conditions | 3 |
| Paths | 3 |
| Total Lines | 57 |
| Code Lines | 49 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function transform(Release $releases): array |
||
| 26 | { |
||
| 27 | if (\in_array($releases->categories_id, Category::MOVIES_GROUP, false)) { |
||
|
|
|||
| 28 | return [ |
||
| 29 | 'title' => $releases->searchname, |
||
| 30 | 'details' => url('/').'/details/'.$releases->guid, |
||
| 31 | 'url' => url('/').'/getnzb?id='.$releases->guid.'.nzb'.'&r='.$this->user->api_token, |
||
| 32 | 'category' => $releases->categories_id, |
||
| 33 | 'category_name' => $releases->category_name, |
||
| 34 | 'added' => Carbon::parse($releases->adddate)->toRssString(), |
||
| 35 | 'size' => $releases->size, |
||
| 36 | 'files' => $releases->totalpart, |
||
| 37 | 'imdbid' => $releases->imdbid, |
||
| 38 | 'grabs' => $releases->grabs, |
||
| 39 | 'comments' => $releases->comments, |
||
| 40 | 'password' => $releases->passwordstatus, |
||
| 41 | 'usenetdate' => Carbon::parse($releases->postdate)->toRssString(), |
||
| 42 | ]; |
||
| 43 | } |
||
| 44 | |||
| 45 | if (\in_array($releases->categories_id, Category::TV_GROUP, false)) { |
||
| 46 | return [ |
||
| 47 | 'title' => $releases->searchname, |
||
| 48 | 'details' => url('/').'/details/'.$releases->guid, |
||
| 49 | 'link' => url('/').'/getnzb?id='.$releases->guid.'.nzb'.'&i='.'&r='.$this->user->api_token, |
||
| 50 | 'category' => $releases->categories_id, |
||
| 51 | 'category_name' => $releases->category_name, |
||
| 52 | 'added' => Carbon::parse($releases->adddate)->toRssString(), |
||
| 53 | 'size' => $releases->size, |
||
| 54 | 'files' => $releases->totalpart, |
||
| 55 | 'tvairdate' => $releases->firstaired, |
||
| 56 | 'tvdbid' => $releases->tvdb, |
||
| 57 | 'traktid' => $releases->trakt, |
||
| 58 | 'tvrageid' => $releases->tvrage, |
||
| 59 | 'tvmazeid' => $releases->tvmaze, |
||
| 60 | 'imdbid' => $releases->imdb, |
||
| 61 | 'tmdbid' => $releases->tmdb, |
||
| 62 | 'grabs' => $releases->grabs, |
||
| 63 | 'comments' => $releases->comments, |
||
| 64 | 'password' => $releases->passwordstatus, |
||
| 65 | 'usenetdate' => Carbon::parse($releases->postdate)->toRssString(), |
||
| 66 | ]; |
||
| 67 | } |
||
| 68 | |||
| 69 | return [ |
||
| 70 | 'title' => $releases->searchname, |
||
| 71 | 'details' => url('/').'/details/'.$releases->guid, |
||
| 72 | 'link' => url('/').'/getnzb?id='.$releases->guid.'.nzb'.'&i='.'&r='.$this->user->api_token, |
||
| 73 | 'category' => $releases->categories_id, |
||
| 74 | 'category_name' => $releases->category_name, |
||
| 75 | 'added' => Carbon::parse($releases->adddate)->toRssString(), |
||
| 76 | 'size' => $releases->size, |
||
| 77 | 'files' => $releases->totalpart, |
||
| 78 | 'grabs' => $releases->grabs, |
||
| 79 | 'comments' => $releases->comments, |
||
| 80 | 'password' => $releases->passwordstatus, |
||
| 81 | 'usenetdate' => Carbon::parse($releases->postdate)->toRssString(), |
||
| 82 | ]; |
||
| 85 |