NNTmux /
newznab-tmux
| Conditions | 49 |
| Paths | > 20000 |
| Total Lines | 122 |
| Code Lines | 81 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 133 | public function edit(Request $request): void |
||
| 134 | { |
||
| 135 | $this->setAdminPrefs(); |
||
| 136 | |||
| 137 | $title = 'User Roles'; |
||
| 138 | |||
| 139 | // Get the user roles. |
||
| 140 | $userRoles = Role::all(); |
||
| 141 | $roles = []; |
||
| 142 | foreach ($userRoles as $userRole) { |
||
| 143 | $roles[$userRole['id']] = $userRole['name']; |
||
| 144 | } |
||
| 145 | |||
| 146 | switch ($request->input('action') ?? 'view') { |
||
| 147 | case 'submit': |
||
| 148 | $title = 'Update User Role'; |
||
| 149 | $role = Role::find($request->input('id')); |
||
| 150 | $role->update([ |
||
| 151 | 'name' => $request->input('name'), |
||
| 152 | 'apirequests' => $request->input('apirequests'), |
||
| 153 | 'downloadrequests' => $request->input('downloadrequests'), |
||
| 154 | 'defaultinvites' => $request->input('defaultinvites'), |
||
| 155 | 'isdefault' => $request->input('isdefault'), |
||
| 156 | 'donation' => $request->input('donation'), |
||
| 157 | 'addyears' => $request->input('addyears'), |
||
| 158 | 'rate_limit' => $request->input('rate_limit'), |
||
| 159 | ]); |
||
| 160 | |||
| 161 | if ((int) $request->input('canpreview') === 1 && $role->hasPermissionTo('preview') === false) { |
||
| 162 | $role->givePermissionTo('preview'); |
||
| 163 | } elseif ((int) $request->input('canpreview') === 0 && $role->hasPermissionTo('preview') === true) { |
||
| 164 | $role->revokePermissionTo('preview'); |
||
| 165 | } |
||
| 166 | |||
| 167 | if ((int) $request->input('hideads') === 1 && $role->hasPermissionTo('hideads') === false) { |
||
| 168 | $role->givePermissionTo('hideads'); |
||
| 169 | } elseif ((int) $request->input('hideads') === 0 && $role->hasPermissionTo('hideads') === true) { |
||
| 170 | $role->revokePermissionTo('hideads'); |
||
| 171 | } |
||
| 172 | |||
| 173 | if ((int) $request->input('editrelease') === 1 && $role->hasPermissionTo('edit release') === false) { |
||
| 174 | $role->givePermissionTo('edit release'); |
||
| 175 | } elseif ((int) $request->input('editrelease') === 0 && $role->hasPermissionTo('edit release') === true) { |
||
| 176 | $role->revokePermissionTo('edit release'); |
||
| 177 | } |
||
| 178 | |||
| 179 | if ((int) $request->input('viewconsole') === 1 && $role->hasPermissionTo('view console') === false) { |
||
| 180 | $role->givePermissionTo('view console'); |
||
| 181 | } elseif ((int) $request->input('viewconsole') === 0 && $role->hasPermissionTo('view console') === true) { |
||
| 182 | $role->revokePermissionTo('view console'); |
||
| 183 | } |
||
| 184 | |||
| 185 | if ((int) $request->input('viewmovies') === 1 && $role->hasPermissionTo('view movies') === false) { |
||
| 186 | $role->givePermissionTo('view movies'); |
||
| 187 | } elseif ((int) $request->input('viewmovies') === 0 && $role->hasPermissionTo('view movies') === true) { |
||
| 188 | $role->revokePermissionTo('view movies'); |
||
| 189 | } |
||
| 190 | |||
| 191 | if ((int) $request->input('viewaudio') === 1 && $role->hasPermissionTo('view audio') === false) { |
||
| 192 | $role->givePermissionTo('view audio'); |
||
| 193 | } elseif ((int) $request->input('viewaudio') === 0 && $role->hasPermissionTo('view audio') === true) { |
||
| 194 | $role->revokePermissionTo('view audio'); |
||
| 195 | } |
||
| 196 | |||
| 197 | if ((int) $request->input('viewpc') === 1 && $role->hasPermissionTo('view pc') === false) { |
||
| 198 | $role->givePermissionTo('view pc'); |
||
| 199 | } elseif ((int) $request->input('viewpc') === 0 && $role->hasPermissionTo('view pc') === true) { |
||
| 200 | $role->revokePermissionTo('view pc'); |
||
| 201 | } |
||
| 202 | |||
| 203 | if ((int) $request->input('viewtv') === 1 && $role->hasPermissionTo('view tv') === false) { |
||
| 204 | $role->givePermissionTo('view tv'); |
||
| 205 | } elseif ((int) $request->input('viewtv') === 0 && $role->hasPermissionTo('view tv') === true) { |
||
| 206 | $role->revokePermissionTo('view tv'); |
||
| 207 | } |
||
| 208 | |||
| 209 | if ((int) $request->input('viewadult') === 1 && $role->hasPermissionTo('view adult') === false) { |
||
| 210 | $role->givePermissionTo('view adult'); |
||
| 211 | } elseif ((int) $request->input('viewadult') === 0 && $role->hasPermissionTo('view adult') === true) { |
||
| 212 | $role->revokePermissionTo('view adult'); |
||
| 213 | } |
||
| 214 | |||
| 215 | if ((int) $request->input('viewbooks') === 1 && $role->hasPermissionTo('view books') === false) { |
||
| 216 | $role->givePermissionTo('view books'); |
||
| 217 | } elseif ((int) $request->input('viewbooks') === 0 && $role->hasPermissionTo('view books') === true) { |
||
| 218 | $role->revokePermissionTo('view books'); |
||
| 219 | } |
||
| 220 | |||
| 221 | if ((int) $request->input('viewother') === 1 && $role->hasPermissionTo('view other') === false) { |
||
| 222 | $role->givePermissionTo('view other'); |
||
| 223 | } elseif ((int) $request->input('viewother') === 0 && $role->hasPermissionTo('view other') === true) { |
||
| 224 | $role->revokePermissionTo('view other'); |
||
| 225 | } |
||
| 226 | |||
| 227 | $this->smarty->assign('role', $role); |
||
| 228 | redirect()->to('admin/role-list')->sendHeaders(); |
||
| 229 | break; |
||
| 230 | |||
| 231 | case 'view': |
||
| 232 | default: |
||
| 233 | if ($request->has('id')) { |
||
| 234 | $title = 'User Roles Edit'; |
||
| 235 | $role = Role::findById($request->input('id')); |
||
| 236 | $this->smarty->assign('role', $role); |
||
| 237 | } |
||
| 238 | break; |
||
| 239 | } |
||
| 240 | |||
| 241 | $this->smarty->assign('yesno_ids', [1, 0]); |
||
| 242 | $this->smarty->assign('yesno_names', ['Yes', 'No']); |
||
| 243 | |||
| 244 | $content = $this->smarty->fetch('role-edit.tpl'); |
||
| 245 | |||
| 246 | $this->smarty->assign( |
||
| 247 | [ |
||
| 248 | 'title' => $title, |
||
| 249 | 'meta_title' => $title, |
||
| 250 | 'content' => $content, |
||
| 251 | ] |
||
| 252 | ); |
||
| 253 | |||
| 254 | $this->adminrender(); |
||
| 255 | } |
||
| 271 |
Loading history...
This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.
This is most likely a typographical error or the method has been renamed.