RoleController::create() - Code Metrics - Inspection of "9fd6206c432bdbc2f6b9eb8666d5c5e76c0c4ac5" - NNTmux/newznab-tmux - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Branch — dev (9fd620)

by Darko
created 2018-08-24 13:33 UTC
RoleController::create() F

↳ Parent: RoleController
Complexity

Conditions	14
Paths	2050
Size

Total Lines	85
Code Lines	50
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	14
eloc	50
nc	2050
nop	1
dl	0
loc	85
rs	2.1
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

namespace App\Http\Controllers\Admin;

use Illuminate\Http\Request;
use Spatie\Permission\Models\Role;
use App\Http\Controllers\BasePageController;

class RoleController extends BasePageController
{
    /**
     * @throws \Exception
     */
    public function index()
    {
        $this->setAdminPrefs();

        $title = 'User Role List';

        //get the user roles
        $userroles = Role::all();

        $this->smarty->assign('userroles', $userroles);
                       assign('userroles', $userroles);

        $content = $this->smarty->fetch('role-list.tpl');
        $content = $this->smarty->fetch('role-list.tpl');

        $this->smarty->assign([
                'title' => $title,
                'meta_title' => $title,
                'content' => $content,
            ]);

        $this->adminrender();
    }

    /**
     * @param \Illuminate\Http\Request $request
     *
     * @throws \Exception
     */
    public function create(Request $request): void
    {
        $this->setAdminPrefs();

        switch ($request->input('action') ?? 'view') {
            case 'submit':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                $title = 'Add User Role';
                    $role = Role::create([
                        'name' => $request->input('name'),
                        'apirequests' => $request->input('apirequests'),
                        'downloadrequests' => $request->input('downloadrequests'),
                        'defaultinvites' => $request->input('defaultinvites'),
                        'donation' => $request->input('donation') ?? 0,
                        'addyears' => $request->input('addyears') ?? 0,
                        'rate_limit' => $request->input('rate_limit'),
                    ]);
                    if ((int) $request->input('canpreview') === 1) {
                        $role->givePermissionTo('preview');
                    }

                    if ((int) $request->input('hideads') === 1) {
                        $role->givePermissionTo('hideads');
                    }

                    if ((int) $request->input('editrelease') === 1) {
                        $role->givePermissionTo('edit release');
                    }

                    if ((int) $request->input('viewconsole') === 1) {
                        $role->givePermissionTo('view console');
                    }

                    if ((int) $request->input('viewmovies') === 1) {
                        $role->givePermissionTo('view movies');
                    }

                    if ((int) $request->input('viewaudio') === 1) {
                        $role->givePermissionTo('view audio');
                    }

                    if ((int) $request->input('viewpc') === 1) {
                        $role->givePermissionTo('view pc');
                    }

                    if ((int) $request->input('viewtv') === 1) {
                        $role->givePermissionTo('view tv');
                    }

                    if ((int) $request->input('viewadult') === 1) {
                        $role->givePermissionTo('view adult');
                    }

                    if ((int) $request->input('viewbooks') === 1) {
                        $role->givePermissionTo('view books');
                    }

                    if ((int) $request->input('viewother') === 1) {
                        $role->givePermissionTo('view other');
                    }
                redirect()->to('admin/role-list')->sendHeaders();
                break;
            case 'view':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
            default:
switch ($expr) {
    default: { //wrong
        doSomething();
        break;
    }
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
            $title = 'Add User Role';
            $role = [
            ];

            break;
        }

        $this->smarty->assign('yesno_ids', [1, 0]);
        $this->smarty->assign('yesno_names', ['Yes', 'No']);

        $content = $this->smarty->fetch('role-add.tpl');

        $this->smarty->assign(
            [
                'title' => $title,
                'meta_title' => $title,
                'content' => $content,
                'role' => $role,
            ]
        );

        $this->adminrender();
    }

    /**
     * @param \Illuminate\Http\Request $request
     *
     * @throws \Exception
     */
    public function edit(Request $request): void
    {
        $this->setAdminPrefs();

        $title = 'User Roles';

        // Get the user roles.
        $userRoles = Role::all();
        $roles = [];
        foreach ($userRoles as $userRole) {
            $roles[$userRole['id']] = $userRole['name'];
        }

        switch ($request->input('action') ?? 'view') {
            case 'submit':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $title = 'Update User Role';
                    $role = Role::find($request->input('id'));
                    $role->update([
                        'name' => $request->input('name'),
                        'apirequests' => $request->input('apirequests'),
                        'downloadrequests' => $request->input('downloadrequests'),
                        'defaultinvites' => $request->input('defaultinvites'),
                        'isdefault' => $request->input('isdefault'),
                        'donation' => $request->input('donation'),
                        'addyears' => $request->input('addyears'),
                        'rate_limit' => $request->input('rate_limit'),
                    ]);

                    if ((int) $request->input('canpreview') === 1 && $role->hasPermissionTo('preview') === false) {
                        $role->givePermissionTo('preview');
                    } elseif ((int) $request->input('canpreview') === 0 && $role->hasPermissionTo('preview') === true) {
                        $role->revokePermissionTo('preview');
                    }

                    if ((int) $request->input('hideads') === 1 && $role->hasPermissionTo('hideads') === false) {
                        $role->givePermissionTo('hideads');
                    } elseif ((int) $request->input('hideads') === 0 && $role->hasPermissionTo('hideads') === true) {
                        $role->revokePermissionTo('hideads');
                    }

                    if ((int) $request->input('editrelease') === 1 && $role->hasPermissionTo('edit release') === false) {
                        $role->givePermissionTo('edit release');
                    } elseif ((int) $request->input('editrelease') === 0 && $role->hasPermissionTo('edit release') === true) {
                        $role->revokePermissionTo('edit release');
                    }

                    if ((int) $request->input('viewconsole') === 1 && $role->hasPermissionTo('view console') === false) {
                        $role->givePermissionTo('view console');
                    } elseif ((int) $request->input('viewconsole') === 0 && $role->hasPermissionTo('view console') === true) {
                        $role->revokePermissionTo('view console');
                    }

                    if ((int) $request->input('viewmovies') === 1 && $role->hasPermissionTo('view movies') === false) {
                        $role->givePermissionTo('view movies');
                    } elseif ((int) $request->input('viewmovies') === 0 && $role->hasPermissionTo('view movies') === true) {
                        $role->revokePermissionTo('view movies');
                    }

                    if ((int) $request->input('viewaudio') === 1 && $role->hasPermissionTo('view audio') === false) {
                        $role->givePermissionTo('view audio');
                    } elseif ((int) $request->input('viewaudio') === 0 && $role->hasPermissionTo('view audio') === true) {
                        $role->revokePermissionTo('view audio');
                    }

                    if ((int) $request->input('viewpc') === 1 && $role->hasPermissionTo('view pc') === false) {
                        $role->givePermissionTo('view pc');
                    } elseif ((int) $request->input('viewpc') === 0 && $role->hasPermissionTo('view pc') === true) {
                        $role->revokePermissionTo('view pc');
                    }

                    if ((int) $request->input('viewtv') === 1 && $role->hasPermissionTo('view tv') === false) {
                        $role->givePermissionTo('view tv');
                    } elseif ((int) $request->input('viewtv') === 0 && $role->hasPermissionTo('view tv') === true) {
                        $role->revokePermissionTo('view tv');
                    }

                    if ((int) $request->input('viewadult') === 1 && $role->hasPermissionTo('view adult') === false) {
                        $role->givePermissionTo('view adult');
                    } elseif ((int) $request->input('viewadult') === 0 && $role->hasPermissionTo('view adult') === true) {
                        $role->revokePermissionTo('view adult');
                    }

                    if ((int) $request->input('viewbooks') === 1 && $role->hasPermissionTo('view books') === false) {
                        $role->givePermissionTo('view books');
                    } elseif ((int) $request->input('viewbooks') === 0 && $role->hasPermissionTo('view books') === true) {
                        $role->revokePermissionTo('view books');
                    }

                    if ((int) $request->input('viewother') === 1 && $role->hasPermissionTo('view other') === false) {
                        $role->givePermissionTo('view other');
                    } elseif ((int) $request->input('viewother') === 0 && $role->hasPermissionTo('view other') === true) {
                        $role->revokePermissionTo('view other');
                    }

                $this->smarty->assign('role', $role);
                redirect()->to('admin/role-list')->sendHeaders();
                break;

            case 'view':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
            default:
switch ($expr) {
    default: { //wrong
        doSomething();
        break;
    }
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
                if ($request->has('id')) {
                    $title = 'User Roles Edit';
                    $role = Role::findById($request->input('id'));
                    $this->smarty->assign('role', $role);
                }
                break;
        }

        $this->smarty->assign('yesno_ids', [1, 0]);
        $this->smarty->assign('yesno_names', ['Yes', 'No']);

        $content = $this->smarty->fetch('role-edit.tpl');

        $this->smarty->assign(
            [
                'title' => $title,
                'meta_title' => $title,
                'content' => $content,
            ]
        );

        $this->adminrender();
    }

    /**
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     */
    public function destroy(Request $request)
    {
        if ($request->has('id')) {
            Role::query()->where('id', $request->input('id'))->delete();
        }

        return redirect($request->server('HTTP_REFERER'));
    }
}

NNTmux / newznab-tmux

Branch — dev (9fd620)

RoleController::create() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
