App\Console\Commands\UpdatePostProcess

Complexity

Total Complexity

10

Size/Duplication

Total Lines	127
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getNntp()	0	11	3
A	showHelp()	0	16	1
A	handle()	0	38	5
A	processAmazon()	0	7	1

<?php

namespace App\Console\Commands;

use Blacklight\NNTP;
use Blacklight\processing\PostProcess;
use Illuminate\Console\Command;

class UpdatePostProcess extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'update:postprocess
                            {type : Type (all, nfo, movies, tv, music, console, games, book, anime, xxx, additional, amazon)}
                            {echo? : Echo output (true/false, default: true)}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Post-process releases by type';

    /**
     * Valid types and whether they require NNTP.
     */
    private array $validTypes = [
        'additional' => false,
        'all' => true,
        'amazon' => false, // Alias for book, music, console, games, xxx
        'anime' => false,
        'book' => false,
        'console' => false,
        'games' => false,
        'movies' => false,
        'music' => false,
        'nfo' => true,
        'tv' => false,
        'xxx' => false,
    ];

    /**
     * Execute the console command.
     */
    public function handle(): int
    {
        $type = $this->argument('type');
        $echoArg = $this->argument('echo');
        $echo = ($echoArg === null || $echoArg === 'true');

The assignment to $echo is dead and can be removed.

        if (! array_key_exists($type, $this->validTypes)) {

It seems like $type can also be of type array; however, parameter $key of array_key_exists() does only seem to accept integer|string, maybe add an additional type check?

            $this->error("Invalid type: {$type}");
            $this->showHelp();

            return self::FAILURE;
        }

        try {
            $nntp = $this->validTypes[$type] ? $this->getNntp() : null;
            $postProcess = new PostProcess;

            match ($type) {
                'all' => $postProcess->processAll($nntp),

Are you sure the usage of $postProcess->processAll($nntp) targeting Blacklight\processing\PostProcess::processAll() seems to always return null.

                'amazon' => $this->processAmazon($postProcess),

Are you sure the usage of $this->processAmazon($postProcess) targeting App\Console\Commands\UpdatePostProcess::processAmazon() seems to always return null.

                'nfo' => $postProcess->processNfos($nntp),

It seems like $nntp can also be of type null; however, parameter $nntp of Blacklight\processing\PostProcess::processNfos() does only seem to accept Blacklight\NNTP, maybe add an additional type check?

Are you sure the usage of $postProcess->processNfos($nntp) targeting Blacklight\processing\PostProcess::processNfos() seems to always return null.

                'movies' => $postProcess->processMovies(),

Are you sure the usage of $postProcess->processMovies() targeting Blacklight\processing\PostProcess::processMovies() seems to always return null.

                'music' => $postProcess->processMusic(),

Are you sure the usage of $postProcess->processMusic() targeting Blacklight\processing\PostProcess::processMusic() seems to always return null.

                'console' => $postProcess->processConsoles(),

Are you sure the usage of $postProcess->processConsoles() targeting Blacklight\processing\PostProcess::processConsoles() seems to always return null.

                'games' => $postProcess->processGames(),

Are you sure the usage of $postProcess->processGames() targeting Blacklight\processing\PostProcess::processGames() seems to always return null.

                'book' => $postProcess->processBooks(),

Are you sure the usage of $postProcess->processBooks() targeting Blacklight\processing\PostProcess::processBooks() seems to always return null.

                'anime' => $postProcess->processAnime(),

Are you sure the usage of $postProcess->processAnime() targeting Blacklight\processing\PostProcess::processAnime() seems to always return null.

                'tv' => $postProcess->processTv(),

Are you sure the usage of $postProcess->processTv() targeting Blacklight\processing\PostProcess::processTv() seems to always return null.

                'xxx' => $postProcess->processXXX(),

Are you sure the usage of $postProcess->processXXX() targeting Blacklight\processing\PostProcess::processXXX() seems to always return null.

                'additional' => $postProcess->processAdditional(),

Are you sure the usage of $postProcess->processAdditional() targeting Blacklight\processing\PostProcess::processAdditional() seems to always return null.

                default => throw new \Exception("Unhandled type: {$type}"),
            };

            return self::SUCCESS;
        } catch (\Throwable $e) {
            $this->error($e->getMessage());

            return self::FAILURE;
        }
    }

    /**
     * Show help text.
     */
    private function showHelp(): void
    {
        $this->line('');
        $this->line('Available types:');
        $this->line('  all         - Does all the types of post processing');
        $this->line('  nfo         - Processes NFO files');
        $this->line('  movies      - Processes movies');
        $this->line('  music       - Processes music');
        $this->line('  console     - Processes console games');
        $this->line('  games       - Processes games');
        $this->line('  book        - Processes books');
        $this->line('  anime       - Processes anime');
        $this->line('  tv          - Processes tv');
        $this->line('  xxx         - Processes xxx');
        $this->line('  additional  - Processes previews/mediainfo/etc...');
        $this->line('  amazon      - Processes books, music, console, games, and xxx');
    }

    /**
     * Process amazon types (books, music, console, games, xxx).
     */
    private function processAmazon(PostProcess $postProcess): void
    {
        $postProcess->processBooks();
        $postProcess->processMusic();
        $postProcess->processConsoles();
        $postProcess->processGames();
        $postProcess->processXXX();
    }

    /**
     * Get NNTP connection.
     */
    private function getNntp(): NNTP
    {
        $nntp = new NNTP;

        if ((config('nntmux_nntp.use_alternate_nntp_server') === true
            ? $nntp->doConnect(false, true)
            : $nntp->doConnect()) !== true) {
            throw new \Exception('Unable to connect to usenet.');
        }

        return $nntp;
    }
}