NNTmux / newznab-tmux

app/extensions/command/Version.php

Doc Comments -2 removed lines

@@ -78,7 +78,6 @@ 
 	/**
 	 * Fetch git tag for latest version.
 	 *
-	 * @param null $path Optional path to the versions XML file.
 	 */
 	protected function git()
 	{
@@ -93,7 +92,6 @@ 
 	/**
 	 * Fetch SQL latest patch version.
 	 *
-	 * @param null $path Optional path to the versions XML file.
 	 */
 	protected function sql()
 	{

Spacing +1 added lines, -1 removed lines

@@ -150,7 +150,7 @@
 	{
 		parent::_init();
 
-		$this->request->params['args'] += ['sqlcheck' => 'all'];    // Default to all versions/
+		$this->request->params['args'] += ['sqlcheck' => 'all']; // Default to all versions/
 		$this->versions = new Versions();
 	}
 }

app/extensions/util/Versions.php

Doc Comments +7 added lines

@@ -268,6 +268,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $property
+	 */
 	protected function isChanged($property)
 	{
 		return (($this->changes & $property) == $property);
@@ -309,6 +312,10 @@ 
 		}
 	}
 
+	/**
+	 * @param string $methodOld
+	 * @param string $methodUse
+	 */
 	private function deprecated($methodOld, $methodUse)
 	{
 		trigger_error("This method ($methodOld) is deprecated. Please use '$methodUse' instead.",

Spacing +4 added lines, -4 removed lines

@@ -26,9 +26,9 @@ 
 	/**
 	 * These constants are bitwise for checking what has changed.
 	 */
-	const UPDATED_GIT_TAG		= 1;
-	const UPDATED_SQL_DB_PATCH	= 2;
-	const UPDATED_SQL_FILE_LAST	= 4;
+	const UPDATED_GIT_TAG = 1;
+	const UPDATED_SQL_DB_PATCH = 2;
+	const UPDATED_SQL_FILE_LAST = 4;
 
 	/**
 	 * @var integer Bitwise mask of elements that have been changed.
@@ -305,7 +305,7 @@ 
 		parent::_init();
 
 		if ($this->_config['git'] instanceof \app\extensions\util\Git) {
-			$this->git =& $this->_config['git'];
+			$this->git = & $this->_config['git'];
 		}
 	}
 

Braces +4 added lines, -2 removed lines

@@ -110,10 +110,12 @@
 				$this->changes |= self::UPDATED_GIT_TAG;
 
 				return $this->versions->git->tag;
-			} else { // They're NOT the same but we were told not to update.
+			} else {
+// They're NOT the same but we were told not to update.
 				return false;
 			}
-		} else { // They're the same so return true
+		} else {
+// They're the same so return true
 			return true;
 		}
 	}

misc/update/nix/tmux/run.php

Doc Comments +6 added lines

@@ -87,6 +87,9 @@ 
 }
 sleep(2);
 
+/**
+ * @param string $pane
+ */
 function writelog($pane)
 {
 	$path = dirname(__FILE__) . "/bin/logs";
@@ -100,6 +103,9 @@ 
 	}
 }
 
+/**
+ * @param string $cmd
+ */
 function command_exist($cmd)
 {
 	$returnVal = exec("which $cmd 2>/dev/null");

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -273,7 +273,7 @@ 
 }
 
 if ($seq == 1) {
-	exec("cd ${DIR}; tmux -f $tmuxconfig new-session -d -s $tmux_session -n Monitor 'printf \"\033]2;\"Monitor\"\033\"'");
+	exec("cd ${dir}; tmux -f $tmuxconfig new-session -d -s $tmux_session -n Monitor 'printf \"\033]2;\"Monitor\"\033\"'");
 	exec("tmux selectp -t $tmux_session:0.0; tmux splitw -t $tmux_session:0 -h -p 67 'printf \"\033]2;update_releases\033\"'");
 	exec("tmux selectp -t $tmux_session:0.0; tmux splitw -t $tmux_session:0 -v -p 25 'printf \"\033]2;nzb-import\033\"'");
 
@@ -290,7 +290,7 @@ 
 	start_apps($tmux_session);
 	attach($DIR, $tmux_session);
 } else if ($seq == 2) {
-	exec("cd ${DIR}; tmux -f $tmuxconfig new-session -d -s $tmux_session -n Monitor 'printf \"\033]2;\"Monitor\"\033\"'");
+	exec("cd ${dir}; tmux -f $tmuxconfig new-session -d -s $tmux_session -n Monitor 'printf \"\033]2;\"Monitor\"\033\"'");
 	exec("tmux selectp -t $tmux_session:0.0; tmux splitw -t $tmux_session:0 -h -p 67 'printf \"\033]2;sequential\033\"'");
 	exec("tmux selectp -t $tmux_session:0.0; tmux splitw -t $tmux_session:0 -v -p 25 'printf \"\033]2;nzb-import\033\"'");
 
@@ -307,7 +307,7 @@ 
 	start_apps($tmux_session);
 	attach($DIR, $tmux_session);
 } else {
-	exec("cd ${DIR}; tmux -f $tmuxconfig new-session -d -s $tmux_session -n Monitor 'printf \"\033]2;Monitor\033\"'");
+	exec("cd ${dir}; tmux -f $tmuxconfig new-session -d -s $tmux_session -n Monitor 'printf \"\033]2;Monitor\033\"'");
 	exec("tmux selectp -t $tmux_session:0.0; tmux splitw -t $tmux_session:0 -h -p 67 'printf \"\033]2;update_binaries\033\"'");
 	exec("tmux selectp -t $tmux_session:0.0; tmux splitw -t $tmux_session:0 -v -p 25 'printf \"\033]2;nzb-import\033\"'");
 	exec("tmux selectp -t $tmux_session:0.2; tmux splitw -t $tmux_session:0 -v -p 67 'printf \"\033]2;backfill\033\"'");

nntmux/Books.php

Doc Comments +10 added lines

@@ -101,6 +101,10 @@ 
 		return $this->pdo->queryOneRow(sprintf('SELECT bookinfo.* FROM bookinfo WHERE bookinfo.id = %d', $id));
 	}
 
+	/**
+	 * @param string $author
+	 * @param string|null $title
+	 */
 	public function getBookInfoByName($author, $title)
 	{
 		$pdo = $this->pdo;
@@ -332,6 +336,9 @@ 
 		return $browseby;
 	}
 
+	/**
+	 * @param string $title
+	 */
 	public function fetchAmazonProperties($title)
 	{
 		$conf = new GenericConfiguration();
@@ -472,6 +479,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $releasetype
+	 */
 	public function parseTitle($release_name, $releaseID, $releasetype)
 	{
 		$a = preg_replace('/\d{1,2} \d{1,2} \d{2,4}|(19|20)\d\d|anybody got .+?[a-z]\? |[-._ ](Novel|TIA)([-._ ]|$)|( |\.)HQ(-|\.| )|[\(\)\.\-_ ](AVI|AZW3?|DOC|EPUB|LIT|MOBI|NFO|RETAIL|(si)?PDF|RTF|TXT)[\)\]\.\-_ ](?![a-z0-9])|compleet|DAGSTiDNiNGEN|DiRFiX|\+ extra|r?e ?Books?([\.\-_ ]English|ers)?|azw3?|ePu(b|p)s?|html|mobi|^NEW[\.\-_ ]|PDF([\.\-_ ]English)?|Please post more|Post description|Proper|Repack(fix)?|[\.\-_ ](Chinese|English|French|German|Italian|Retail|Scan|Swedish)|^R4 |Repost|Skytwohigh|TIA!+|TruePDF|V413HAV|(would someone )?please (re)?post.+? "|with the authors name right/i', '', $release_name);

Spacing +3 added lines, -3 removed lines

@@ -70,7 +70,7 @@ 
 	/**
 	 * @param array $options Class instances / Echo to cli.
 	 */
-	public function __construct(array $options =[])
+	public function __construct(array $options = [])
 	{
 		$defaults = [
 			'Echo'     => false,
@@ -376,7 +376,7 @@ 
 	 */
 	public function processBookReleases()
 	{
-		$bookids =[];
+		$bookids = [];
 		if (preg_match('/^\d+$/', $this->bookreqids)) {
 			$bookids[] = $this->bookreqids;
 		} else {
@@ -523,7 +523,7 @@ 
 	{
 		$ri = new ReleaseImage($this->pdo);
 
-		$book =[];
+		$book = [];
 
 		$amaz = false;
 		if ($bookInfo != '') {

Braces +6 added lines, -11 removed lines

@@ -354,18 +354,12 @@ 
 		$apaiIo = new ApaiIO($conf);
 
 		$response = $apaiIo->runOperation($search);
-		if ($response === false)
-		{
+		if ($response === false) {
 			throw new \Exception("Could not connect to Amazon");
-		}
-		else
-		{
-			if (isset($response->Items->Item->ItemAttributes->Title))
-			{
+		} else {
+			if (isset($response->Items->Item->ItemAttributes->Title)) {
 				return $response;
-			}
-			else
-			{
+			} else {
 				return false;
 			}
 		}
@@ -455,7 +449,8 @@ 
 
 					// Update release.
 					$this->pdo->queryExec(sprintf('UPDATE releases SET bookinfo_id = %d WHERE id = %d', $bookId, $arr['id']));
-				} else { // Could not parse release title.
+				} else {
+// Could not parse release title.
 					$this->pdo->queryExec(sprintf('UPDATE releases SET bookinfo_id = %d WHERE id = %d', -2, $arr['id']));
 					if ($this->echooutput) {
 						echo '.';

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -210,7 +210,7 @@
 		$bookIDs = $releaseIDs = false;
 
 		if (is_array($books['result'])) {
-			foreach ($books['result'] AS $book => $id) {
+			foreach ($books['result'] as $book => $id) {
 				$bookIDs[] = $id['id'];
 				$releaseIDs[] = $id['grp_release_id'];
 			}

nntmux/Category.php

Doc Comments +3 added lines

@@ -177,6 +177,9 @@
 			]);
 	}
 
+	/**
+	 * @param string $category
+	 */
 	public static function getCategoryValue($category)
 	{
 		return constant('self::' . $category);

Braces +6 added lines, -4 removed lines

@@ -271,8 +271,9 @@ 
 				" from categories c left outer join categories cp on cp.id = c.parentid where c.id = %d", $id
 			)
 		);
-		if (!$res)
-			return null;
+		if (!$res) {
+					return null;
+		}
 
 		$min = intval($res['minsizetoformrelease']);
 		$max = intval($res['maxsizetoformrelease']);
@@ -427,8 +428,9 @@ 
 			$temp_array[-1] = "--Please Select--";
 		}
 
-		foreach ($categories as $category)
-			$temp_array[$category["id"]] = $category["title"];
+		foreach ($categories as $category) {
+					$temp_array[$category["id"]] = $category["title"];
+		}
 
 		return $temp_array;
 	}

nntmux/ColorCLI.php

Doc Comments +18 added lines

@@ -174,6 +174,9 @@ 
 		return $colored_string;
 	}
 
+	/**
+	 * @param string $fg
+	 */
 	public static function set256($fg, $opt = "None", $bg = "None")
 	{
 		$colored_string = "\033[38;5;" . self::$colors256[$fg];
@@ -199,6 +202,9 @@ 
 		return $infostring;
 	}
 
+	/**
+	 * @param string $str
+	 */
 	public static function notice($str)
 	{
 		$noticstring = "\033[38;5;" . self::$colors256['Blue'] . "mNotice: $str\033[0m\n";
@@ -229,12 +235,18 @@ 
 		return $str;
 	}
 
+	/**
+	 * @param string $str
+	 */
 	public static function alternate($str)
 	{
 		$str = "\033[38;5;" . self::$colors256['DeepPink1'] . "m$str\033[0m\n";
 		return $str;
 	}
 
+	/**
+	 * @param string $str
+	 */
 	public static function tmuxOrange($str)
 	{
 		$str = "\033[38;5;" . self::$colors256['Orange'] . "m$str\033[0m\n";
@@ -253,12 +265,18 @@ 
 		return $str;
 	}
 
+	/**
+	 * @param string $str
+	 */
 	public static function alternateOver($str)
 	{
 		$str = "\033[38;5;" . self::$colors256['DeepPink1'] . "m$str\033[0m";
 		return $str;
 	}
 
+	/**
+	 * @param string $str
+	 */
 	public static function warningOver($str)
 	{
 		$str = "\033[38;5;" . self::$colors256['Red'] . "m";

nntmux/Console.php

Doc Comments +6 added lines

@@ -915,6 +915,9 @@ 
 		return (isset($result['title']) && !empty($result['title']) && isset($result['platform'])) ? $result : false;
 	}
 
+	/**
+	 * @param string $platform
+	 */
 	function getBrowseNode($platform)
 	{
 		switch ($platform) {
@@ -982,6 +985,9 @@ 
 		return $nodeId;
 	}
 
+	/**
+	 * @param string $nodeName
+	 */
 	public function matchBrowseNode($nodeName)
 	{
 		$str = '';

Spacing +15 added lines, -15 removed lines

@@ -75,7 +75,7 @@ 
 	/**
 	 * @param array $options Class instances / Echo to cli.
 	 */
-	public function __construct(array $options =[])
+	public function __construct(array $options = [])
 	{
 		$defaults = [
 			'Echo'     => false,
@@ -99,7 +99,7 @@ 
 		//$this->cleanconsole = ($this->pdo->getSetting('lookupgames') == 2) ? 'AND isrenamed = 1' : '';
 		$this->catWhere = "AND categories_id BETWEEN " . Category::GAME_ROOT . " AND " . Category::GAME_OTHER;
 
-		$this->failCache =[];
+		$this->failCache = [];
 	}
 
 	public function getConsoleInfo($id)
@@ -321,7 +321,7 @@ 
 	public function makeFieldLinks($data, $field)
 	{
 		$tmpArr = explode(', ', $data[$field]);
-		$newArr =[];
+		$newArr = [];
 		$i = 0;
 		foreach ($tmpArr as $ta) {
 			if (trim($ta) == '') {
@@ -414,7 +414,7 @@ 
 		return $consoleId;
 	}
 
-	protected function _matchConToGameInfo($gameInfo =[], $con =[])
+	protected function _matchConToGameInfo($gameInfo = [], $con = [])
 	{
 		$matched = false;
 
@@ -428,7 +428,7 @@ 
 		similar_text(strtolower($gameInfo['platform']), strtolower($con['platform']), $platformpercent);
 
 		if (NN_DEBUG) {
-			echo(PHP_EOL ."Matched: Title Percentage 1: $titlepercent% between " . $gameInfo['title'] . " and " . $con['title'] . PHP_EOL);
+			echo(PHP_EOL . "Matched: Title Percentage 1: $titlepercent% between " . $gameInfo['title'] . " and " . $con['title'] . PHP_EOL);
 		}
 
 		// Since Wii Ware games and XBLA have inconsistent original platforms, as long as title is 50% its ok.
@@ -463,7 +463,7 @@ 
 
 	protected function _setConBeforeMatch($amaz, $gameInfo)
 	{
-		$con =[];
+		$con = [];
 		$con['platform'] = (string)$amaz->Items->Item->ItemAttributes->Platform;
 		if (empty($con['platform'])) {
 			$con['platform'] = $gameInfo['platform'];
@@ -486,7 +486,7 @@ 
 
 	protected function _setConAfterMatch($amaz)
 	{
-		$con =[];
+		$con = [];
 		$con['asin'] = (string)$amaz->Items->Item->ASIN;
 
 		$con['url'] = (string)$amaz->Items->Item->DetailPageURL;
@@ -501,7 +501,7 @@ 
 		$con['esrb'] = (string)$amaz->Items->Item->ItemAttributes->ESRBAgeRating;
 		$con['releasedate'] = (string)$amaz->Items->Item->ItemAttributes->ReleaseDate;
 
-		if(!isset($con['releasedate'])){
+		if (!isset($con['releasedate'])) {
 			$con['releasedate'] = "";
 		}
 
@@ -587,7 +587,7 @@ 
 		$gen = new Genres(['Settings' => $this->pdo]);
 
 		$defaultGenres = $gen->getGenres(Genres::CONSOLE_TYPE);
-		$genreassoc =[];
+		$genreassoc = [];
 		foreach ($defaultGenres as $dg) {
 			$genreassoc[$dg['id']] = strtolower($dg['title']);
 		}
@@ -663,7 +663,7 @@ 
 		return $platform;
 	}
 
-	protected function _updateConsoleTable($con =[])
+	protected function _updateConsoleTable($con = [])
 	{
 		$ri = new ReleaseImage($this->pdo);
 
@@ -694,19 +694,19 @@ 
 					$con['cover']
 				)
 			);
-			if($con['cover'] === 1){
+			if ($con['cover'] === 1) {
 				$con['cover'] = $ri->saveImage($consoleId, $con['coverurl'], $this->imgSavePath, 250, 250);
 			}
 		} else {
 			$consoleId = $check['id'];
 
-			if($con['cover'] === 1){
+			if ($con['cover'] === 1) {
 				$con['cover'] = $ri->saveImage($consoleId, $con['coverurl'], $this->imgSavePath, 250, 250);
 			}
 
 			$this->update(
 				$consoleId, $con['title'], $con['asin'], $con['url'], $con['salesrank'],
-				$con['platform'], $con['publisher'], (isset($con['releasedate']) ? $con['releasedate']: null), $con['esrb'],
+				$con['platform'], $con['publisher'], (isset($con['releasedate']) ? $con['releasedate'] : null), $con['esrb'],
 				$con['cover'], $con['consolegenreid'], (isset($con['review']) ? $con['review'] : null)
 			);
 		}
@@ -852,14 +852,14 @@ 
 	function parseTitle($releasename)
 	{
 		$releasename = preg_replace('/\sMulti\d?\s/i', '', $releasename);
-		$result =[];
+		$result = [];
 
 		// Get name of the game from name of release.
 		if (preg_match('/^(.+((abgx360EFNet|EFNet\sFULL|FULL\sabgxEFNet|abgx\sFULL|abgxbox360EFNet)\s|illuminatenboard\sorg|Place2(hom|us)e.net|united-forums? co uk|\(\d+\)))?(?P<title>.*?)[\.\-_ ](v\.?\d\.\d|PAL|NTSC|EUR|USA|JP|ASIA|JAP|JPN|AUS|MULTI(\.?\d{1,2})?|PATCHED|FULLDVD|DVD5|DVD9|DVDRIP|PROPER|REPACK|RETAIL|DEMO|DISTRIBUTION|REGIONFREE|[\. ]RF[\. ]?|READ\.?NFO|NFOFIX|PSX(2PSP)?|PS[2-4]|PSP|PSVITA|WIIU|WII|X\-?BOX|XBLA|X360|3DS|NDS|N64|NGC)/i', $releasename, $matches)) {
 			$title = $matches['title'];
 
 			// Replace dots, underscores, or brackets with spaces.
-			$result['title'] = str_replace(['.','_','%20', '[', ']'], ' ', $title);
+			$result['title'] = str_replace(['.', '_', '%20', '[', ']'], ' ', $title);
 			$result['title'] = str_replace([' RF ', '.RF.', '-RF-', '_RF_'], ' ', $result['title']);
 			//Remove format tags from release title for match
 			$result['title'] = trim(preg_replace('/PAL|MULTI(\d)?|NTSC-?J?|\(JAPAN\)/i', '', $result['title']));

Braces +7 added lines, -13 removed lines

@@ -501,7 +501,7 @@ 
 		$con['esrb'] = (string)$amaz->Items->Item->ItemAttributes->ESRBAgeRating;
 		$con['releasedate'] = (string)$amaz->Items->Item->ItemAttributes->ReleaseDate;
 
-		if(!isset($con['releasedate'])){
+		if(!isset($con['releasedate'])) {
 			$con['releasedate'] = "";
 		}
 
@@ -694,13 +694,13 @@ 
 					$con['cover']
 				)
 			);
-			if($con['cover'] === 1){
+			if($con['cover'] === 1) {
 				$con['cover'] = $ri->saveImage($consoleId, $con['coverurl'], $this->imgSavePath, 250, 250);
 			}
 		} else {
 			$consoleId = $check['id'];
 
-			if($con['cover'] === 1){
+			if($con['cover'] === 1) {
 				$con['cover'] = $ri->saveImage($consoleId, $con['coverurl'], $this->imgSavePath, 250, 250);
 			}
 
@@ -736,18 +736,12 @@ 
 		$apaiIo = new ApaiIO($conf);
 
 		$response = $apaiIo->runOperation($search);
-		if ($response === false)
-		{
+		if ($response === false) {
 			throw new \Exception("Could not connect to Amazon");
-		}
-		else
-		{
-			if (isset($response->Items->Item->ItemAttributes->Title))
-			{
+		} else {
+			if (isset($response->Items->Item->ItemAttributes->Title)) {
 				return $response;
-			}
-			else
-			{
+			} else {
 				return false;
 			}
 		}

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -207,7 +207,7 @@
 		$consoleIDs = $releaseIDs = false;
 
 		if (is_array($consoles['result'])) {
-			foreach ($consoles['result'] AS $console => $id) {
+			foreach ($consoles['result'] as $console => $id) {
 				$consoleIDs[] = $id['id'];
 				$releaseIDs[] = $id['grp_release_id'];
 			}

nntmux/Contents.php

Doc Comments +3 added lines

@@ -128,6 +128,9 @@
 		return $this->row2Object($row);
 	}
 
+	/**
+	 * @param Content $content
+	 */
 	public function validate($content)
 	{
 		if (substr($content->url, 0, 1) != '/') {

nntmux/data/source/database/MySQL.php

Doc Comments +2 added lines, -2 removed lines

@@ -269,7 +269,7 @@ 
 	 *
 	 * @param $encoding
 	 *
-	 * @return mixed If setting the encoding; returns true on success, else false.
+	 * @return string|boolean If setting the encoding; returns true on success, else false.
 	 *         When getting, returns the encoding.
 	 */
 	public function encoding($encoding = null)
@@ -337,7 +337,7 @@ 
 	 * @param string $context
 	 * @param array  $options
 	 *
-	 * @return void
+	 * @return string
 	 */
 	public function conditions($conditions, $context, array $options = [])
 	{

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 				}
 				$name    = $self->invokeMethod('_entityName',
 											   [$entity, ['quoted' => true]]);
-				$columns = $self->read("DESCRIBE {$name}",
+				$columns = $self->read("describe {$name}",
 									   [
 										   'return' => 'array', 'schema' => [
 										   'field', 'type', 'null', 'key', 'default', 'extra'