DeletedUsersController::index() - Code Metrics - Inspection of "Update site edit page" - NNTmux/newznab-tmux - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( fa5159...8fd79e )

by Darko
created 2025-08-25 20:14 UTC
DeletedUsersController::index() C

↳ Parent: DeletedUsersController
Complexity

Conditions	15
Paths	2
Size

Total Lines	87
Code Lines	63
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
eloc	63
c	1
b	0
f	0
dl	0
loc	87
rs	5.9166
cc	15
nc	2
nop	1
How to fix Long Method Complexity

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Controllers\BasePageController;
use App\Models\User;
use Carbon\Carbon;
use Illuminate\Http\Request;

class DeletedUsersController extends BasePageController
{
    /**
     * Display a listing of soft-deleted users with filtering, sorting and pagination.
     */
    public function index(Request $request)
    {
        $this->setAdminPrefs();

        // Filters
        $username = $request->input('username', '');
        $email = $request->input('email', '');
        $host = $request->input('host', '');
        $orderBy = $request->filled('ob') ? $request->input('ob') : 'deleted_at_desc';
        $createdFrom = $request->input('created_from', '');
        $createdTo = $request->input('created_to', '');
        $deletedFrom = $request->input('deleted_from', '');
        $deletedTo = $request->input('deleted_to', '');

        $deletedUsers = User::onlyTrashed()
            ->when($username !== '', fn ($q) => $q->where('username', 'like', "%$username%"))
            ->when($email !== '', fn ($q) => $q->where('email', 'like', "%$email%"))
            ->when($host !== '', fn ($q) => $q->where('host', 'like', "%$host%"))
            // Created date filters
            ->when($createdFrom !== '' || $createdTo !== '', function ($q) use ($createdFrom, $createdTo) {
                try {
                    if ($createdFrom !== '' && $createdTo !== '') {
                        $from = Carbon::createFromFormat('Y-m-d', $createdFrom)->startOfDay();
                        $from = Carbon::createFromFormat('Y-m-d', $createdFrom)->/** @scrutinizer ignore-call */ startOfDay();
                        $to = Carbon::createFromFormat('Y-m-d', $createdTo)->endOfDay();
                        $to = Carbon::createFromFormat('Y-m-d', $createdTo)->/** @scrutinizer ignore-call */ endOfDay();
                        $q->whereBetween('created_at', [$from, $to]);
                    } elseif ($createdFrom !== '') {
                        $from = Carbon::createFromFormat('Y-m-d', $createdFrom)->startOfDay();
                        $q->where('created_at', '>=', $from);
                    } elseif ($createdTo !== '') {
                        $to = Carbon::createFromFormat('Y-m-d', $createdTo)->endOfDay();
                        $q->where('created_at', '<=', $to);
                    }
                } catch (\Exception $e) {
                    // ignore invalid dates
                }
            })
            // Deleted date filters
            ->when($deletedFrom !== '' || $deletedTo !== '', function ($q) use ($deletedFrom, $deletedTo) {
                try {
                    if ($deletedFrom !== '' && $deletedTo !== '') {
                        $from = Carbon::createFromFormat('Y-m-d', $deletedFrom)->startOfDay();
                        $to = Carbon::createFromFormat('Y-m-d', $deletedTo)->endOfDay();
                        $q->whereBetween('deleted_at', [$from, $to]);
                    } elseif ($deletedFrom !== '') {
                        $from = Carbon::createFromFormat('Y-m-d', $deletedFrom)->startOfDay();
                        $q->where('deleted_at', '>=', $from);
                    } elseif ($deletedTo !== '') {
                        $to = Carbon::createFromFormat('Y-m-d', $deletedTo)->endOfDay();
                        $q->where('deleted_at', '<=', $to);
                    }
                } catch (\Exception $e) {
                    // ignore invalid dates
                }
            });

        // Sorting
        [$orderField, $orderSort] = $this->getSortOrder($orderBy);
        $deletedUsers = $deletedUsers->orderBy($orderField, $orderSort)
            ->paginate(25)
            ->appends($request->except('page'));

        // Build query string (exclude ordering + pagination) for sort links
        $qsParams = $request->except(['ob', 'page']);
        $queryString = http_build_query(array_filter($qsParams, fn ($v) => $v !== '' && $v !== null));

        $this->smarty->assign([
            'deletedusers' => $deletedUsers,
            'username' => $username,
            'email' => $email,
            'host' => $host,
            'orderby' => $orderBy,
            'created_from' => $createdFrom,
            'created_to' => $createdTo,
            'deleted_from' => $deletedFrom,
            'deleted_to' => $deletedTo,
            'csrf_token' => csrf_token(),
            'queryString' => $queryString,
        ]);

        $meta_title = 'Deleted Users';
        $meta_keywords = 'view,deleted,users,softdeleted';
        $meta_description = 'View and restore soft-deleted user accounts';

        $content = $this->smarty->fetch('deleted_users.tpl');
        $this->smarty->assign(compact('content', 'meta_title', 'meta_keywords', 'meta_description'));

        $this->adminrender();
    }

    /**
     * Bulk restore or permanent delete.
     */
    public function bulkAction(Request $request)
    {
        $action = $request->input('action');
        $userIds = $request->input('user_ids', []);

        if (! in_array($action, ['restore', 'delete'], true) || empty($userIds) || ! is_array($userIds)) {
            return redirect()->route('admin.deleted.users.index')->with('error', 'Invalid bulk action request.');
        }

        $userIds = array_filter(array_map('intval', $userIds));
        if (empty($userIds)) {
            return redirect()->route('admin.deleted.users.index')->with('error', 'No valid users selected.');
        }

        if ($action === 'restore') {
            $count = User::onlyTrashed()->whereIn('id', $userIds)->restore();

            return redirect()->route('admin.deleted.users.index')->with('success', $count.' user(s) restored successfully.');
            return redirect()->route('admin.deleted.users.index')->with('success', /** @scrutinizer ignore-type */ $count.' user(s) restored successfully.');
        }

        $count = User::onlyTrashed()->whereIn('id', $userIds)->forceDelete();

        return redirect()->route('admin.deleted.users.index')->with('success', $count.' user(s) permanently deleted.');
    }

    /**
     * Restore single user.
     */
    public function restore($id)
    {
        $user = User::onlyTrashed()->find($id);
        if ($user) {
            $user->restore();

            return redirect()->route('admin.deleted.users.index')->with('success', "User '{$user->username}' has been restored successfully.");
        }

        return redirect()->route('admin.deleted.users.index')->with('error', 'User not found.');
    }

    /**
     * Permanently delete single user.
     */
    public function permanentDelete($id)
    {
        $user = User::onlyTrashed()->find($id);
        if ($user) {
            $username = $user->username;
            $user->forceDelete();

            return redirect()->route('admin.deleted.users.index')->with('success', "User '{$username}' has been permanently deleted.");
        }

        return redirect()->route('admin.deleted.users.index')->with('error', 'User not found.');
    }

    /**
     * Parse and validate sort order.
     */
    private function getSortOrder(string $orderBy): array
    {
        $orderArr = explode('_', $orderBy);
        $fieldKey = $orderArr[0] ?? 'deletedat';
        $orderField = match ($fieldKey) {
            'email' => 'email',
            'host' => 'host',
            'createdat' => 'created_at',
            'deletedat' => 'deleted_at',
            'lastlogin' => 'lastlogin',
            'apiaccess' => 'apiaccess',
            'grabs' => 'grabs',
            'role' => 'roles_id',
            default => 'username',
        };
        $orderSort = (isset($orderArr[1]) && preg_match('/^(asc|desc)$/i', $orderArr[1])) ? strtolower($orderArr[1]) : 'desc';

        return [$orderField, $orderSort];
    }
}

NNTmux / newznab-tmux

Push — master ( fa5159...8fd79e )

DeletedUsersController::index() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
