Conditions | 27 |
Paths | 16644 |
Total Lines | 68 |
Code Lines | 60 |
Lines | 0 |
Ratio | 0 % |
Changes | 4 | ||
Bugs | 2 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
22 | public function transform(Release $releases): array |
||
23 | { |
||
24 | if (\in_array($releases->categories_id, Category::MOVIES_GROUP, false)) { |
||
|
|||
25 | return [ |
||
26 | 'title' => $releases->searchname, |
||
27 | 'details' => url('/').'/details/'.$releases->guid, |
||
28 | 'url' => url('/').'/getnzb?id='.$releases->guid.'.nzb'.'&r='.$this->user->api_token, |
||
29 | 'category' => $releases->categories_id, |
||
30 | 'category_name' => $releases->category_name, |
||
31 | 'added' => Carbon::parse($releases->adddate)->toRssString(), |
||
32 | 'size' => $releases->size, |
||
33 | 'files' => $releases->totalpart, |
||
34 | 'poster' => $releases->fromname, |
||
35 | 'imdbid' => $releases->imdbid !== null && $releases->imdbid !== 0 ? $releases->imdbid : $this->null(), |
||
36 | 'tmdbid' => $releases->tmdbid !== null && $releases->tmdbid !== 0 ? $releases->tmdbid : $this->null(), |
||
37 | 'traktid' => $releases->traktid !== null && $releases->traktid !== 0 ? $releases->traktid : $this->null(), |
||
38 | 'grabs' => $releases->grabs !== 0 ? $releases->grabs : $this->null(), |
||
39 | 'comments' => $releases->comments !== 0 ? $releases->comments : $this->null(), |
||
40 | 'password' => $releases->passwordstatus, |
||
41 | 'usenetdate' => Carbon::parse($releases->postdate)->toRssString(), |
||
42 | 'group' => $releases->group_name, |
||
43 | ]; |
||
44 | } |
||
45 | |||
46 | if (\in_array($releases->categories_id, Category::TV_GROUP, false)) { |
||
47 | return [ |
||
48 | 'title' => $releases->searchname, |
||
49 | 'details' => url('/').'/details/'.$releases->guid, |
||
50 | 'url' => url('/').'/getnzb?id='.$releases->guid.'.nzb'.'&r='.$this->user->api_token, |
||
51 | 'category' => $releases->categories_id, |
||
52 | 'category_name' => $releases->category_name, |
||
53 | 'added' => Carbon::parse($releases->adddate)->toRssString(), |
||
54 | 'size' => $releases->size, |
||
55 | 'files' => $releases->totalpart, |
||
56 | 'poster' => $releases->fromname, |
||
57 | 'episode_title' => $releases->title ?? $this->null(), |
||
58 | 'season' => $releases->series ?? $this->null(), |
||
59 | 'episode' => $releases->episode ?? $this->null(), |
||
60 | 'tvairdate' => $releases->firstaired ?? $this->null(), |
||
61 | 'tvdbid' => $releases->tvdb !== null && $releases->tvdb !== 0 ? $releases->tvdb : $this->null(), |
||
62 | 'traktid' => $releases->trakt !== null && $releases->trakt !== 0 ? $releases->trakt : $this->null(), |
||
63 | 'tvrageid' => $releases->tvrage !== null && $releases->tvrage !== 0 ? $releases->tvrage : $this->null(), |
||
64 | 'tvmazeid' => $releases->tvmaze !== null && $releases->tvmaze !== 0 ? $releases->tvmaze : $this->null(), |
||
65 | 'imdbid' => $releases->imdb !== null && $releases->imdb !== 0 ? $releases->imdb : $this->null(), |
||
66 | 'tmdbid' => $releases->tmdb !== null && $releases->tmdb !== 0 ? $releases->tmdb : $this->null(), |
||
67 | 'grabs' => $releases->grabs !== 0 ? $releases->grabs : $this->null(), |
||
68 | 'comments' => $releases->comments !== 0 ? $releases->comments : $this->null(), |
||
69 | 'password' => $releases->passwordstatus, |
||
70 | 'usenetdate' => Carbon::parse($releases->postdate)->toRssString(), |
||
71 | 'group' => $releases->group_name, |
||
72 | ]; |
||
73 | } |
||
74 | |||
75 | return [ |
||
76 | 'title' => $releases->searchname, |
||
77 | 'details' => url('/').'/details/'.$releases->guid, |
||
78 | 'url' => url('/').'/getnzb?id='.$releases->guid.'.nzb'.'&r='.$this->user->api_token, |
||
79 | 'category' => $releases->categories_id, |
||
80 | 'category_name' => $releases->category_name, |
||
81 | 'added' => Carbon::parse($releases->adddate)->toRssString(), |
||
82 | 'size' => $releases->size, |
||
83 | 'files' => $releases->totalpart, |
||
84 | 'poster' => $releases->fromname, |
||
85 | 'grabs' => $releases->grabs !== 0 ? $releases->grabs : $this->null(), |
||
86 | 'comments' => $releases->comments !== 0 ? $releases->comments : $this->null(), |
||
87 | 'password' => $releases->passwordstatus, |
||
88 | 'usenetdate' => Carbon::parse($releases->postdate)->toRssString(), |
||
89 | 'group' => $releases->group_name, |
||
90 | ]; |
||
93 |