Conditions | 31 |
Paths | 3552 |
Total Lines | 160 |
Code Lines | 110 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
16 | public function index(Request $request, string $id = '') |
||
17 | { |
||
18 | $releases = new Releases; |
||
19 | |||
20 | if ($id && ctype_digit($id)) { |
||
21 | $category = -1; |
||
22 | if ($request->has('t') && ctype_digit($request->input('t'))) { |
||
23 | $category = $request->input('t'); |
||
24 | } |
||
25 | |||
26 | $catarray = []; |
||
27 | $catarray[] = $category; |
||
28 | |||
29 | $page = $request->has('page') && is_numeric($request->input('page')) ? $request->input('page') : 1; |
||
30 | $offset = ($page - 1) * config('nntmux.items_per_page'); |
||
31 | |||
32 | $rel = $releases->tvSearch(['id' => $id], '', '', '', $offset, 1000, '', $catarray, -1); |
||
33 | |||
34 | $show = Video::getByVideoID($id); |
||
35 | |||
36 | $nodata = ''; |
||
37 | $seasons = []; |
||
38 | $myshows = null; |
||
39 | $seriestitles = ''; |
||
40 | $seriessummary = ''; |
||
41 | $seriescountry = ''; |
||
42 | |||
43 | if (! $show) { |
||
44 | $nodata = 'No video information for this series.'; |
||
45 | } elseif (! $rel) { |
||
46 | $nodata = 'No releases for this series.'; |
||
47 | } else { |
||
48 | $myshows = UserSerie::getShow($this->userdata->id, $show['id']); |
||
49 | |||
50 | // Sort releases by season, episode, date posted. |
||
51 | $series = $episode = $posted = []; |
||
52 | foreach ($rel as $rlk => $rlv) { |
||
53 | $series[$rlk] = $rlv->series; |
||
54 | $episode[$rlk] = $rlv->episode; |
||
55 | $posted[$rlk] = $rlv->postdate; |
||
56 | } |
||
57 | Arr::sort($series, [[$episode, false], [$posted, false], $rel]); |
||
58 | |||
59 | $series = []; |
||
60 | foreach ($rel as $r) { |
||
61 | $series[$r->series][$r->episode][] = $r; |
||
62 | } |
||
63 | |||
64 | $seasons = Arr::sortRecursive($series); |
||
65 | |||
66 | // get series name(s), description, country and genre |
||
67 | $seriestitlesArray = $seriessummaryArray = $seriescountryArray = []; |
||
68 | $seriestitlesArray[] = $show['title']; |
||
69 | |||
70 | if (! empty($show['summary'])) { |
||
71 | $seriessummaryArray[] = $show['summary']; |
||
72 | } |
||
73 | |||
74 | if (! empty($show['countries_id'])) { |
||
75 | $seriescountryArray[] = $show['countries_id']; |
||
76 | } |
||
77 | |||
78 | $seriestitles = implode('/', array_map('trim', $seriestitlesArray)); |
||
79 | $seriessummary = $seriessummaryArray ? array_shift($seriessummaryArray) : ''; |
||
80 | $seriescountry = $seriescountryArray ? array_shift($seriescountryArray) : ''; |
||
81 | } |
||
82 | |||
83 | // Calculate statistics |
||
84 | $episodeCount = 0; |
||
85 | $seasonCount = count($seasons); |
||
86 | $totalSeasonsAvailable = $seasonCount; |
||
87 | |||
88 | // Get first and last aired dates from TV episodes |
||
89 | $firstEpisodeAired = null; |
||
90 | $lastEpisodeAired = null; |
||
91 | $totalSeasonsAired = 0; |
||
92 | $totalEpisodesAired = 0; |
||
93 | |||
94 | if (! empty($show['id'])) { |
||
95 | $episodeStats = \App\Models\TvEpisode::query() |
||
96 | ->where('videos_id', $show['id']) |
||
97 | ->whereNotNull('firstaired') |
||
98 | ->where('firstaired', '!=', '') |
||
99 | ->selectRaw('MIN(firstaired) as first_aired, MAX(firstaired) as last_aired, COUNT(DISTINCT series) as total_seasons, COUNT(*) as total_episodes') |
||
100 | ->first(); |
||
101 | |||
102 | if ($episodeStats) { |
||
103 | if (! empty($episodeStats->first_aired) && $episodeStats->first_aired != '0000-00-00') { |
||
|
|||
104 | $firstEpisodeAired = \Carbon\Carbon::parse($episodeStats->first_aired); |
||
105 | } |
||
106 | if (! empty($episodeStats->last_aired) && $episodeStats->last_aired != '0000-00-00') { |
||
107 | $lastEpisodeAired = \Carbon\Carbon::parse($episodeStats->last_aired); |
||
108 | } |
||
109 | $totalSeasonsAired = $episodeStats->total_seasons ?? 0; |
||
110 | $totalEpisodesAired = $episodeStats->total_episodes ?? 0; |
||
111 | } |
||
112 | } |
||
113 | |||
114 | foreach ($seasons as $seasonNum => $episodes) { |
||
115 | $episodeCount += count($episodes); |
||
116 | } |
||
117 | |||
118 | $catid = $category !== -1 ? $category : ''; |
||
119 | |||
120 | $this->viewData = array_merge($this->viewData, [ |
||
121 | 'seasons' => $seasons, |
||
122 | 'show' => $show, |
||
123 | 'myshows' => $myshows, |
||
124 | 'seriestitles' => $seriestitles, |
||
125 | 'seriessummary' => $seriessummary, |
||
126 | 'seriescountry' => $seriescountry, |
||
127 | 'category' => $catid, |
||
128 | 'nodata' => $nodata, |
||
129 | 'episodeCount' => $episodeCount, |
||
130 | 'seasonCount' => $seasonCount, |
||
131 | 'firstEpisodeAired' => $firstEpisodeAired, |
||
132 | 'lastEpisodeAired' => $lastEpisodeAired, |
||
133 | 'totalSeasonsAvailable' => $totalSeasonsAvailable, |
||
134 | 'totalSeasonsAired' => $totalSeasonsAired, |
||
135 | 'totalEpisodesAired' => $totalEpisodesAired, |
||
136 | 'meta_title' => 'View TV Series', |
||
137 | 'meta_keywords' => 'view,series,tv,show,description,details', |
||
138 | 'meta_description' => 'View TV Series', |
||
139 | ]); |
||
140 | |||
141 | return view('series.viewseries', $this->viewData); |
||
142 | } else { |
||
143 | $letter = ($id && preg_match('/^(0\-9|[A-Z])$/i', $id)) ? $id : '0-9'; |
||
144 | |||
145 | $showname = ($request->has('title') && ! empty($request->input('title'))) ? $request->input('title') : ''; |
||
146 | |||
147 | if ($showname !== '' && ! $id) { |
||
148 | $letter = ''; |
||
149 | } |
||
150 | |||
151 | $masterserieslist = Video::getSeriesList($this->userdata->id, $letter, $showname); |
||
152 | |||
153 | $serieslist = []; |
||
154 | foreach ($masterserieslist as $s) { |
||
155 | if (preg_match('/^[0-9]/', $s['title'])) { |
||
156 | $thisrange = '0-9'; |
||
157 | } else { |
||
158 | preg_match('/([A-Z]).*/i', $s['title'], $hits); |
||
159 | $thisrange = strtoupper($hits[1]); |
||
160 | } |
||
161 | $serieslist[$thisrange][] = $s; |
||
162 | } |
||
163 | ksort($serieslist); |
||
164 | |||
165 | $this->viewData = array_merge($this->viewData, [ |
||
166 | 'serieslist' => $serieslist, |
||
167 | 'seriesrange' => range('A', 'Z'), |
||
168 | 'seriesletter' => $letter, |
||
169 | 'showname' => $showname, |
||
170 | 'meta_title' => 'View Series List', |
||
171 | 'meta_keywords' => 'view,series,tv,show,description,details', |
||
172 | 'meta_description' => 'View Series List', |
||
173 | ]); |
||
174 | |||
175 | return view('series.viewserieslist', $this->viewData); |
||
176 | } |
||
179 |