NNTmux /
newznab-tmux
| Conditions | 49 |
| Paths | > 20000 |
| Total Lines | 115 |
| Code Lines | 78 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 117 | public function edit(Request $request) |
||
| 118 | { |
||
| 119 | $this->setAdminPrefs(); |
||
| 120 | |||
| 121 | $meta_title = $title = 'User Roles'; |
||
| 122 | $role = null; |
||
| 123 | |||
| 124 | // Get the user roles. |
||
| 125 | $userRoles = Role::cursor()->remember(); |
||
| 126 | $roles = []; |
||
| 127 | foreach ($userRoles as $userRole) { |
||
| 128 | $roles[$userRole->id] = $userRole->name; |
||
| 129 | } |
||
| 130 | |||
| 131 | switch ($request->input('action') ?? 'view') { |
||
| 132 | case 'submit': |
||
| 133 | $meta_title = $title = 'Update User Role'; |
||
| 134 | $role = Role::find($request->input('id')); |
||
| 135 | $role->update([ |
||
| 136 | 'name' => $request->input('name'), |
||
| 137 | 'apirequests' => $request->input('apirequests'), |
||
| 138 | 'downloadrequests' => $request->input('downloadrequests'), |
||
| 139 | 'defaultinvites' => $request->input('defaultinvites'), |
||
| 140 | 'isdefault' => $request->input('isdefault'), |
||
| 141 | 'donation' => $request->input('donation'), |
||
| 142 | 'addyears' => $request->input('addyears'), |
||
| 143 | 'rate_limit' => $request->input('rate_limit'), |
||
| 144 | ]); |
||
| 145 | |||
| 146 | if ((int) $request->input('canpreview') === 1 && $role->hasPermissionTo('preview') === false) { |
||
| 147 | $role->givePermissionTo('preview'); |
||
| 148 | } elseif ((int) $request->input('canpreview') === 0 && $role->hasPermissionTo('preview') === true) { |
||
| 149 | $role->revokePermissionTo('preview'); |
||
| 150 | } |
||
| 151 | |||
| 152 | if ((int) $request->input('hideads') === 1 && $role->hasPermissionTo('hideads') === false) { |
||
| 153 | $role->givePermissionTo('hideads'); |
||
| 154 | } elseif ((int) $request->input('hideads') === 0 && $role->hasPermissionTo('hideads') === true) { |
||
| 155 | $role->revokePermissionTo('hideads'); |
||
| 156 | } |
||
| 157 | |||
| 158 | if ((int) $request->input('editrelease') === 1 && $role->hasPermissionTo('edit release') === false) { |
||
| 159 | $role->givePermissionTo('edit release'); |
||
| 160 | } elseif ((int) $request->input('editrelease') === 0 && $role->hasPermissionTo('edit release') === true) { |
||
| 161 | $role->revokePermissionTo('edit release'); |
||
| 162 | } |
||
| 163 | |||
| 164 | if ((int) $request->input('viewconsole') === 1 && $role->hasPermissionTo('view console') === false) { |
||
| 165 | $role->givePermissionTo('view console'); |
||
| 166 | } elseif ((int) $request->input('viewconsole') === 0 && $role->hasPermissionTo('view console') === true) { |
||
| 167 | $role->revokePermissionTo('view console'); |
||
| 168 | } |
||
| 169 | |||
| 170 | if ((int) $request->input('viewmovies') === 1 && $role->hasPermissionTo('view movies') === false) { |
||
| 171 | $role->givePermissionTo('view movies'); |
||
| 172 | } elseif ((int) $request->input('viewmovies') === 0 && $role->hasPermissionTo('view movies') === true) { |
||
| 173 | $role->revokePermissionTo('view movies'); |
||
| 174 | } |
||
| 175 | |||
| 176 | if ((int) $request->input('viewaudio') === 1 && $role->hasPermissionTo('view audio') === false) { |
||
| 177 | $role->givePermissionTo('view audio'); |
||
| 178 | } elseif ((int) $request->input('viewaudio') === 0 && $role->hasPermissionTo('view audio') === true) { |
||
| 179 | $role->revokePermissionTo('view audio'); |
||
| 180 | } |
||
| 181 | |||
| 182 | if ((int) $request->input('viewpc') === 1 && $role->hasPermissionTo('view pc') === false) { |
||
| 183 | $role->givePermissionTo('view pc'); |
||
| 184 | } elseif ((int) $request->input('viewpc') === 0 && $role->hasPermissionTo('view pc') === true) { |
||
| 185 | $role->revokePermissionTo('view pc'); |
||
| 186 | } |
||
| 187 | |||
| 188 | if ((int) $request->input('viewtv') === 1 && $role->hasPermissionTo('view tv') === false) { |
||
| 189 | $role->givePermissionTo('view tv'); |
||
| 190 | } elseif ((int) $request->input('viewtv') === 0 && $role->hasPermissionTo('view tv') === true) { |
||
| 191 | $role->revokePermissionTo('view tv'); |
||
| 192 | } |
||
| 193 | |||
| 194 | if ((int) $request->input('viewadult') === 1 && $role->hasPermissionTo('view adult') === false) { |
||
| 195 | $role->givePermissionTo('view adult'); |
||
| 196 | } elseif ((int) $request->input('viewadult') === 0 && $role->hasPermissionTo('view adult') === true) { |
||
| 197 | $role->revokePermissionTo('view adult'); |
||
| 198 | } |
||
| 199 | |||
| 200 | if ((int) $request->input('viewbooks') === 1 && $role->hasPermissionTo('view books') === false) { |
||
| 201 | $role->givePermissionTo('view books'); |
||
| 202 | } elseif ((int) $request->input('viewbooks') === 0 && $role->hasPermissionTo('view books') === true) { |
||
| 203 | $role->revokePermissionTo('view books'); |
||
| 204 | } |
||
| 205 | |||
| 206 | if ((int) $request->input('viewother') === 1 && $role->hasPermissionTo('view other') === false) { |
||
| 207 | $role->givePermissionTo('view other'); |
||
| 208 | } elseif ((int) $request->input('viewother') === 0 && $role->hasPermissionTo('view other') === true) { |
||
| 209 | $role->revokePermissionTo('view other'); |
||
| 210 | } |
||
| 211 | |||
| 212 | return redirect()->to('admin/role-list'); |
||
| 213 | |||
| 214 | case 'view': |
||
| 215 | default: |
||
| 216 | if ($request->has('id')) { |
||
| 217 | $meta_title = $title = 'User Roles Edit'; |
||
| 218 | $role = Role::findById($request->input('id')); |
||
| 219 | } |
||
| 220 | break; |
||
| 221 | } |
||
| 222 | |||
| 223 | $this->viewData = array_merge($this->viewData, [ |
||
| 224 | 'yesno_ids' => [1, 0], |
||
| 225 | 'yesno_names' => ['Yes', 'No'], |
||
| 226 | 'title' => $title, |
||
| 227 | 'meta_title' => $meta_title, |
||
| 228 | 'role' => $role, |
||
| 229 | ]); |
||
| 230 | |||
| 231 | return view('admin.roles.edit', $this->viewData); |
||
| 232 | } |
||
| 243 |
Loading history...
