NNTmux /
newznab-tmux
| Total Complexity | 66 |
| Total Lines | 226 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like RssController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RssController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class RssController extends BasePageController |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * @return JsonResponse|void |
||
| 19 | * |
||
| 20 | * @throws \Throwable |
||
| 21 | */ |
||
| 22 | public function myMoviesRss(Request $request) |
||
| 40 | } |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @return JsonResponse|void |
||
| 44 | * |
||
| 45 | * @throws \Throwable |
||
| 46 | */ |
||
| 47 | public function myShowsRss(Request $request) |
||
| 61 | } |
||
| 62 | |||
| 63 | /** |
||
| 64 | * @return JsonResponse|void |
||
| 65 | * |
||
| 66 | * @throws \Throwable |
||
| 67 | */ |
||
| 68 | public function fullFeedRss(Request $request) |
||
| 89 | } |
||
| 90 | |||
| 91 | /** |
||
| 92 | * @throws \Exception |
||
| 93 | */ |
||
| 94 | public function showRssDesc(): void |
||
| 95 | { |
||
| 96 | $this->setPreferences(); |
||
| 97 | $rss = new RSS; |
||
| 98 | |||
| 99 | $title = 'Rss Info'; |
||
| 100 | $meta_title = 'Rss Nzb Info'; |
||
| 101 | $meta_keywords = 'view,nzb,description,details,rss,atom'; |
||
| 102 | $meta_description = 'View information about NNTmux RSS Feeds.'; |
||
| 103 | |||
| 104 | $firstShow = $rss->getFirstInstance('videos_id', 'releases', 'id'); |
||
| 105 | $firstAni = $rss->getFirstInstance('anidbid', 'releases', 'id'); |
||
| 106 | |||
| 107 | if ($firstShow !== null) { |
||
| 108 | $this->smarty->assign('show', $firstShow->videos_id); |
||
| 109 | } else { |
||
| 110 | $this->smarty->assign('show', 1); |
||
| 111 | } |
||
| 112 | |||
| 113 | if ($firstAni !== null) { |
||
| 114 | $this->smarty->assign('anidb', $firstAni->anidbid); |
||
| 115 | } else { |
||
| 116 | $this->smarty->assign('anidb', 1); |
||
| 117 | } |
||
| 118 | |||
| 119 | $catExclusions = $this->userdata->categoryexclusions ?? []; |
||
| 120 | |||
| 121 | $this->smarty->assign( |
||
| 122 | [ |
||
| 123 | 'categorylist' => Category::getCategories(true, $catExclusions), |
||
| 124 | 'parentcategorylist' => Category::getForMenu($catExclusions), |
||
| 125 | ] |
||
| 126 | ); |
||
| 127 | |||
| 128 | $content = $this->smarty->fetch('rssdesc.tpl'); |
||
| 129 | $this->smarty->assign( |
||
| 130 | compact('content', 'title', 'meta_title', 'meta_keywords', 'meta_description') |
||
| 131 | ); |
||
| 132 | $this->pagerender(); |
||
| 133 | } |
||
| 134 | |||
| 135 | /** |
||
| 136 | * @throws \Throwable |
||
| 137 | */ |
||
| 138 | public function cartRss(Request $request): JsonResponse|array |
||
| 139 | { |
||
| 140 | $rss = new RSS; |
||
| 141 | $offset = 0; |
||
| 142 | $user = $this->userCheck($request); |
||
| 143 | if (is_object($user)) { |
||
| 144 | return $user; |
||
| 145 | } |
||
| 146 | $outputXML = (! ($request->has('o') && $request->input('o') === 'json')); |
||
| 147 | $userAirDate = $request->has('airdate') && is_numeric($request->input('airdate')) ? abs($request->input('airdate')) : -1; |
||
| 148 | $userNum = ($request->has('num') && is_numeric($request->input('num')) ? abs($request->input('num')) : 0); |
||
| 149 | $userLimit = $request->has('limit') && is_numeric($request->input('limit')) ? $request->input('limit') : 100; |
||
| 150 | $userShow = $userAnidb = -1; |
||
| 151 | if ($request->has('show')) { |
||
| 152 | $userShow = ((int) $request->input('show') === 0 ? -1 : $request->input('show') + 0); |
||
| 153 | } elseif ($request->has('anidb')) { |
||
| 154 | $userAnidb = ((int) $request->input('anidb') === 0 ? -1 : $request->input('anidb') + 0); |
||
| 155 | } |
||
| 156 | |||
| 157 | $relData = $rss->getRss([-2], $userShow, $userAnidb, $user['user_id'], $userAirDate, $userLimit, $userNum); |
||
| 158 | $rss->output($relData, $user['params'], $outputXML, $offset, 'rss'); |
||
| 159 | } |
||
| 160 | |||
| 161 | /** |
||
| 162 | * @throws \Throwable |
||
| 163 | */ |
||
| 164 | public function categoryFeedRss(Request $request): JsonResponse|array |
||
| 165 | { |
||
| 166 | $rss = new RSS; |
||
| 167 | $offset = 0; |
||
| 168 | if ($request->missing('id')) { |
||
| 169 | return response()->json(['error' => 'Category ID is missing'], '403'); |
||
| 170 | } |
||
| 171 | |||
| 172 | $user = $this->userCheck($request); |
||
| 173 | if (is_object($user)) { |
||
| 174 | return $user; |
||
| 175 | } |
||
| 176 | $categoryId = explode(',', $request->input('id')); |
||
| 177 | $userAirDate = $request->has('airdate') && is_numeric($request->input('airdate')) ? abs($request->input('airdate')) : -1; |
||
| 178 | $userNum = ($request->has('num') && is_numeric($request->input('num')) ? abs($request->input('num')) : 0); |
||
| 179 | $userLimit = $request->has('limit') && is_numeric($request->input('limit')) ? $request->input('limit') : 100; |
||
| 180 | $userShow = $userAnidb = -1; |
||
| 181 | if ($request->has('show')) { |
||
| 182 | $userShow = ((int) $request->input('show') === 0 ? -1 : $request->input('show') + 0); |
||
| 183 | } elseif ($request->has('anidb')) { |
||
| 184 | $userAnidb = ((int) $request->input('anidb') === 0 ? -1 : $request->input('anidb') + 0); |
||
| 185 | } |
||
| 186 | $outputXML = (! ($request->has('o') && $request->input('o') === 'json')); |
||
| 187 | $relData = $rss->getRss($categoryId, $userShow, $userAnidb, $user['user_id'], $userAirDate, $userLimit, $userNum); |
||
| 188 | $rss->output($relData, $user['params'], $outputXML, $offset, 'rss'); |
||
| 189 | } |
||
| 190 | |||
| 191 | /** |
||
| 192 | * @throws \Throwable |
||
| 193 | */ |
||
| 194 | private function userCheck(Request $request): JsonResponse|array |
||
| 241 | } |
||
| 242 | } |
||
| 243 |
Loading history...
This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.