Conditions | 3 |
Paths | 3 |
Total Lines | 136 |
Code Lines | 120 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
63 | public static function unaccent($string) |
||
64 | { |
||
65 | if (!preg_match('/[\x80-\xff]/', $string)) { |
||
66 | return $string; |
||
67 | } |
||
68 | |||
69 | if (self::seemsUtf8($string)) { |
||
70 | $chars = array( |
||
71 | // Decompositions for Latin-1 Supplement |
||
72 | chr(195).chr(128) => 'A', chr(195).chr(129) => 'A', |
||
73 | chr(195).chr(130) => 'A', chr(195).chr(131) => 'A', |
||
74 | chr(195).chr(132) => 'A', chr(195).chr(133) => 'A', |
||
75 | chr(195).chr(135) => 'C', chr(195).chr(136) => 'E', |
||
76 | chr(195).chr(137) => 'E', chr(195).chr(138) => 'E', |
||
77 | chr(195).chr(139) => 'E', chr(195).chr(140) => 'I', |
||
78 | chr(195).chr(141) => 'I', chr(195).chr(142) => 'I', |
||
79 | chr(195).chr(143) => 'I', chr(195).chr(145) => 'N', |
||
80 | chr(195).chr(146) => 'O', chr(195).chr(147) => 'O', |
||
81 | chr(195).chr(148) => 'O', chr(195).chr(149) => 'O', |
||
82 | chr(195).chr(150) => 'O', chr(195).chr(153) => 'U', |
||
83 | chr(195).chr(154) => 'U', chr(195).chr(155) => 'U', |
||
84 | chr(195).chr(156) => 'U', chr(195).chr(157) => 'Y', |
||
85 | chr(195).chr(159) => 's', chr(195).chr(160) => 'a', |
||
86 | chr(195).chr(161) => 'a', chr(195).chr(162) => 'a', |
||
87 | chr(195).chr(163) => 'a', chr(195).chr(164) => 'a', |
||
88 | chr(195).chr(165) => 'a', chr(195).chr(167) => 'c', |
||
89 | chr(195).chr(168) => 'e', chr(195).chr(169) => 'e', |
||
90 | chr(195).chr(170) => 'e', chr(195).chr(171) => 'e', |
||
91 | chr(195).chr(172) => 'i', chr(195).chr(173) => 'i', |
||
92 | chr(195).chr(174) => 'i', chr(195).chr(175) => 'i', |
||
93 | chr(195).chr(177) => 'n', chr(195).chr(178) => 'o', |
||
94 | chr(195).chr(179) => 'o', chr(195).chr(180) => 'o', |
||
95 | chr(195).chr(181) => 'o', chr(195).chr(182) => 'o', |
||
96 | chr(195).chr(182) => 'o', chr(195).chr(185) => 'u', |
||
97 | chr(195).chr(186) => 'u', chr(195).chr(187) => 'u', |
||
98 | chr(195).chr(188) => 'u', chr(195).chr(189) => 'y', |
||
99 | chr(195).chr(191) => 'y', |
||
100 | // Decompositions for Latin Extended-A |
||
101 | chr(196).chr(128) => 'A', chr(196).chr(129) => 'a', |
||
102 | chr(196).chr(130) => 'A', chr(196).chr(131) => 'a', |
||
103 | chr(196).chr(132) => 'A', chr(196).chr(133) => 'a', |
||
104 | chr(196).chr(134) => 'C', chr(196).chr(135) => 'c', |
||
105 | chr(196).chr(136) => 'C', chr(196).chr(137) => 'c', |
||
106 | chr(196).chr(138) => 'C', chr(196).chr(139) => 'c', |
||
107 | chr(196).chr(140) => 'C', chr(196).chr(141) => 'c', |
||
108 | chr(196).chr(142) => 'D', chr(196).chr(143) => 'd', |
||
109 | chr(196).chr(144) => 'D', chr(196).chr(145) => 'd', |
||
110 | chr(196).chr(146) => 'E', chr(196).chr(147) => 'e', |
||
111 | chr(196).chr(148) => 'E', chr(196).chr(149) => 'e', |
||
112 | chr(196).chr(150) => 'E', chr(196).chr(151) => 'e', |
||
113 | chr(196).chr(152) => 'E', chr(196).chr(153) => 'e', |
||
114 | chr(196).chr(154) => 'E', chr(196).chr(155) => 'e', |
||
115 | chr(196).chr(156) => 'G', chr(196).chr(157) => 'g', |
||
116 | chr(196).chr(158) => 'G', chr(196).chr(159) => 'g', |
||
117 | chr(196).chr(160) => 'G', chr(196).chr(161) => 'g', |
||
118 | chr(196).chr(162) => 'G', chr(196).chr(163) => 'g', |
||
119 | chr(196).chr(164) => 'H', chr(196).chr(165) => 'h', |
||
120 | chr(196).chr(166) => 'H', chr(196).chr(167) => 'h', |
||
121 | chr(196).chr(168) => 'I', chr(196).chr(169) => 'i', |
||
122 | chr(196).chr(170) => 'I', chr(196).chr(171) => 'i', |
||
123 | chr(196).chr(172) => 'I', chr(196).chr(173) => 'i', |
||
124 | chr(196).chr(174) => 'I', chr(196).chr(175) => 'i', |
||
125 | chr(196).chr(176) => 'I', chr(196).chr(177) => 'i', |
||
126 | chr(196).chr(178) => 'IJ',chr(196).chr(179) => 'ij', |
||
127 | chr(196).chr(180) => 'J', chr(196).chr(181) => 'j', |
||
128 | chr(196).chr(182) => 'K', chr(196).chr(183) => 'k', |
||
129 | chr(196).chr(184) => 'k', chr(196).chr(185) => 'L', |
||
130 | chr(196).chr(186) => 'l', chr(196).chr(187) => 'L', |
||
131 | chr(196).chr(188) => 'l', chr(196).chr(189) => 'L', |
||
132 | chr(196).chr(190) => 'l', chr(196).chr(191) => 'L', |
||
133 | chr(197).chr(128) => 'l', chr(197).chr(129) => 'L', |
||
134 | chr(197).chr(130) => 'l', chr(197).chr(131) => 'N', |
||
135 | chr(197).chr(132) => 'n', chr(197).chr(133) => 'N', |
||
136 | chr(197).chr(134) => 'n', chr(197).chr(135) => 'N', |
||
137 | chr(197).chr(136) => 'n', chr(197).chr(137) => 'N', |
||
138 | chr(197).chr(138) => 'n', chr(197).chr(139) => 'N', |
||
139 | chr(197).chr(140) => 'O', chr(197).chr(141) => 'o', |
||
140 | chr(197).chr(142) => 'O', chr(197).chr(143) => 'o', |
||
141 | chr(197).chr(144) => 'O', chr(197).chr(145) => 'o', |
||
142 | chr(197).chr(146) => 'OE',chr(197).chr(147) => 'oe', |
||
143 | chr(197).chr(148) => 'R', chr(197).chr(149) => 'r', |
||
144 | chr(197).chr(150) => 'R', chr(197).chr(151) => 'r', |
||
145 | chr(197).chr(152) => 'R', chr(197).chr(153) => 'r', |
||
146 | chr(197).chr(154) => 'S', chr(197).chr(155) => 's', |
||
147 | chr(197).chr(156) => 'S', chr(197).chr(157) => 's', |
||
148 | chr(197).chr(158) => 'S', chr(197).chr(159) => 's', |
||
149 | chr(197).chr(160) => 'S', chr(197).chr(161) => 's', |
||
150 | chr(197).chr(162) => 'T', chr(197).chr(163) => 't', |
||
151 | chr(197).chr(164) => 'T', chr(197).chr(165) => 't', |
||
152 | chr(197).chr(166) => 'T', chr(197).chr(167) => 't', |
||
153 | chr(197).chr(168) => 'U', chr(197).chr(169) => 'u', |
||
154 | chr(197).chr(170) => 'U', chr(197).chr(171) => 'u', |
||
155 | chr(197).chr(172) => 'U', chr(197).chr(173) => 'u', |
||
156 | chr(197).chr(174) => 'U', chr(197).chr(175) => 'u', |
||
157 | chr(197).chr(176) => 'U', chr(197).chr(177) => 'u', |
||
158 | chr(197).chr(178) => 'U', chr(197).chr(179) => 'u', |
||
159 | chr(197).chr(180) => 'W', chr(197).chr(181) => 'w', |
||
160 | chr(197).chr(182) => 'Y', chr(197).chr(183) => 'y', |
||
161 | chr(197).chr(184) => 'Y', chr(197).chr(185) => 'Z', |
||
162 | chr(197).chr(186) => 'z', chr(197).chr(187) => 'Z', |
||
163 | chr(197).chr(188) => 'z', chr(197).chr(189) => 'Z', |
||
164 | chr(197).chr(190) => 'z', chr(197).chr(191) => 's', |
||
165 | // Euro Sign |
||
166 | chr(226).chr(130).chr(172) => 'E', |
||
167 | // GBP (Pound) Sign |
||
168 | chr(194).chr(163) => '', |
||
169 | 'Ä' => 'Ae', 'ä' => 'ae', 'Ü' => 'Ue', 'ü' => 'ue', |
||
170 | 'Ö' => 'Oe', 'ö' => 'oe', 'ß' => 'ss', |
||
171 | // Norwegian characters |
||
172 | 'Å'=>'Aa','Æ'=>'Ae','Ø'=>'O','æ'=>'a','ø'=>'o','å'=>'aa' |
||
173 | ); |
||
174 | |||
175 | $string = strtr($string, $chars); |
||
176 | } else { |
||
177 | // Assume ISO-8859-1 if not UTF-8 |
||
178 | $chars['in'] = chr(128).chr(131).chr(138).chr(142).chr(154).chr(158) |
||
|
|||
179 | .chr(159).chr(162).chr(165).chr(181).chr(192).chr(193).chr(194) |
||
180 | .chr(195).chr(196).chr(197).chr(199).chr(200).chr(201).chr(202) |
||
181 | .chr(203).chr(204).chr(205).chr(206).chr(207).chr(209).chr(210) |
||
182 | .chr(211).chr(212).chr(213).chr(214).chr(216).chr(217).chr(218) |
||
183 | .chr(219).chr(220).chr(221).chr(224).chr(225).chr(226).chr(227) |
||
184 | .chr(228).chr(229).chr(231).chr(232).chr(233).chr(234).chr(235) |
||
185 | .chr(236).chr(237).chr(238).chr(239).chr(241).chr(242).chr(243) |
||
186 | .chr(244).chr(245).chr(246).chr(248).chr(249).chr(250).chr(251) |
||
187 | .chr(252).chr(253).chr(255); |
||
188 | |||
189 | $chars['out'] = "EfSZszYcYuAAAAAACEEEEIIIINOOOOOOUUUUYaaaaaaceeeeiiiinoooooouuuuyy"; |
||
190 | |||
191 | $string = strtr($string, $chars['in'], $chars['out']); |
||
192 | $doubleChars['in'] = array(chr(140), chr(156), chr(198), chr(208), chr(222), chr(223), chr(230), chr(240), chr(254)); |
||
193 | $doubleChars['out'] = array('OE', 'oe', 'AE', 'DH', 'TH', 'ss', 'ae', 'dh', 'th'); |
||
194 | $string = str_replace($doubleChars['in'], $doubleChars['out'], $string); |
||
195 | } |
||
196 | |||
197 | return $string; |
||
198 | } |
||
199 | |||
370 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArray
is initialized the first time when the foreach loop is entered. You can also see that the value of thebar
key is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.