Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | View Code Duplication | abstract class BaseRole extends Model |
|
|
|||
8 | { |
||
9 | public $table = 'multi_tenant_roles'; |
||
10 | |||
11 | /** |
||
12 | * The attributes that are mass assignable. |
||
13 | * |
||
14 | * @var array |
||
15 | */ |
||
16 | protected $fillable = [ |
||
17 | 'name', 'label', 'description', |
||
18 | ]; |
||
19 | |||
20 | /** |
||
21 | * The permissions relationship |
||
22 | */ |
||
23 | public function permissions() |
||
32 | |||
33 | /** |
||
34 | * Assign the given permission to the role |
||
35 | * |
||
36 | * @param BasePermission $permission |
||
37 | * |
||
38 | * @return void |
||
39 | */ |
||
40 | public function assignPermission(BasePermission $permission) |
||
46 | |||
47 | /** |
||
48 | * Check if the role has the given permission |
||
49 | * |
||
50 | * @param BasePermission $permission |
||
51 | * |
||
52 | * @return boolean |
||
53 | */ |
||
54 | public function hasPermission(BasePermission $permission) |
||
58 | } |
||
59 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.