Conditions | 43 |
Total Lines | 211 |
Code Lines | 148 |
Lines | 67 |
Ratio | 31.75 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like reports.meterrealtime.Reporting.on_get() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | import re |
||
29 | @staticmethod |
||
30 | def on_get(req, resp): |
||
31 | if 'API-KEY' not in req.headers or \ |
||
32 | not isinstance(req.headers['API-KEY'], str) or \ |
||
33 | len(str.strip(req.headers['API-KEY'])) == 0: |
||
34 | access_control(req) |
||
35 | else: |
||
36 | api_key_control(req) |
||
37 | print(req.params) |
||
38 | meter_id = req.params.get('meterid') |
||
39 | meter_uuid = req.params.get('meteruuid') |
||
40 | quick_mode = req.params.get('quickmode') |
||
41 | |||
42 | ################################################################################################################ |
||
43 | # Step 1: valid parameters |
||
44 | ################################################################################################################ |
||
45 | if meter_id is None and meter_uuid is None: |
||
46 | raise falcon.HTTPError(status=falcon.HTTP_400, title='API.BAD_REQUEST', description='API.INVALID_METER_ID') |
||
47 | |||
48 | if meter_id is not None: |
||
49 | meter_id = str.strip(meter_id) |
||
50 | if not meter_id.isdigit() or int(meter_id) <= 0: |
||
51 | raise falcon.HTTPError(status=falcon.HTTP_400, title='API.BAD_REQUEST', |
||
52 | description='API.INVALID_METER_ID') |
||
53 | |||
54 | if meter_uuid is not None: |
||
55 | regex = re.compile(r'^[a-f0-9]{8}-?[a-f0-9]{4}-?4[a-f0-9]{3}-?[89ab][a-f0-9]{3}-?[a-f0-9]{12}\Z', re.I) |
||
56 | match = regex.match(str.strip(meter_uuid)) |
||
57 | if not bool(match): |
||
58 | raise falcon.HTTPError(status=falcon.HTTP_400, title='API.BAD_REQUEST', |
||
59 | description='API.INVALID_METER_UUID') |
||
60 | |||
61 | # if turn quick mode on, do not return parameters data and excel file |
||
62 | is_quick_mode = False |
||
63 | if quick_mode is not None and \ |
||
64 | len(str.strip(quick_mode)) > 0 and \ |
||
65 | str.lower(str.strip(quick_mode)) in ('true', 't', 'on', 'yes', 'y'): |
||
66 | is_quick_mode = True |
||
67 | |||
68 | timezone_offset = int(config.utc_offset[1:3]) * 60 + int(config.utc_offset[4:6]) |
||
69 | if config.utc_offset[0] == '-': |
||
70 | timezone_offset = -timezone_offset |
||
71 | |||
72 | reporting_end_datetime_utc = datetime.utcnow() |
||
73 | reporting_start_datetime_utc = reporting_end_datetime_utc - timedelta(minutes=60) |
||
74 | ################################################################################################################ |
||
75 | # Step 2: query the meter and energy category |
||
76 | ################################################################################################################ |
||
77 | cnx_system = mysql.connector.connect(**config.myems_system_db) |
||
78 | cursor_system = cnx_system.cursor() |
||
79 | |||
80 | cnx_historical = mysql.connector.connect(**config.myems_historical_db) |
||
81 | cursor_historical = cnx_historical.cursor() |
||
82 | |||
83 | if meter_id is not None: |
||
84 | cursor_system.execute(" SELECT m.id, m.name, m.cost_center_id, m.energy_category_id, " |
||
85 | " ec.name, ec.unit_of_measure, ec.kgce, ec.kgco2e " |
||
86 | " FROM tbl_meters m, tbl_energy_categories ec " |
||
87 | " WHERE m.id = %s AND m.energy_category_id = ec.id ", (meter_id,)) |
||
88 | row_meter = cursor_system.fetchone() |
||
89 | elif meter_uuid is not None: |
||
90 | cursor_system.execute(" SELECT m.id, m.name, m.cost_center_id, m.energy_category_id, " |
||
91 | " ec.name, ec.unit_of_measure, ec.kgce, ec.kgco2e " |
||
92 | " FROM tbl_meters m, tbl_energy_categories ec " |
||
93 | " WHERE m.uuid = %s AND m.energy_category_id = ec.id ", (meter_uuid,)) |
||
94 | row_meter = cursor_system.fetchone() |
||
95 | |||
96 | if row_meter is None: |
||
|
|||
97 | if cursor_system: |
||
98 | cursor_system.close() |
||
99 | if cnx_system: |
||
100 | cnx_system.close() |
||
101 | |||
102 | if cursor_historical: |
||
103 | cursor_historical.close() |
||
104 | if cnx_historical: |
||
105 | cnx_historical.close() |
||
106 | raise falcon.HTTPError(status=falcon.HTTP_404, title='API.NOT_FOUND', description='API.METER_NOT_FOUND') |
||
107 | |||
108 | meter = dict() |
||
109 | meter['id'] = row_meter[0] |
||
110 | meter['name'] = row_meter[1] |
||
111 | meter['cost_center_id'] = row_meter[2] |
||
112 | meter['energy_category_id'] = row_meter[3] |
||
113 | meter['energy_category_name'] = row_meter[4] |
||
114 | meter['unit_of_measure'] = row_meter[5] |
||
115 | |||
116 | ################################################################################################################ |
||
117 | # Step 3: query associated points |
||
118 | ################################################################################################################ |
||
119 | point_list = list() |
||
120 | cursor_system.execute(" SELECT p.id, p.name, p.units, p.object_type " |
||
121 | " FROM tbl_meters m, tbl_meters_points mp, tbl_points p " |
||
122 | " WHERE m.id = %s AND m.id = mp.meter_id AND mp.point_id = p.id " |
||
123 | " ORDER BY p.id ", (meter['id'],)) |
||
124 | rows_points = cursor_system.fetchall() |
||
125 | if rows_points is not None and len(rows_points) > 0: |
||
126 | for row in rows_points: |
||
127 | point_list.append({"id": row[0], "name": row[1], "units": row[2], "object_type": row[3]}) |
||
128 | |||
129 | ################################################################################################################ |
||
130 | # Step 7: query associated points data |
||
131 | ################################################################################################################ |
||
132 | energy_value_data = dict() |
||
133 | energy_value_data['name'] = None |
||
134 | energy_value_data['timestamps'] = list() |
||
135 | energy_value_data['values'] = list() |
||
136 | |||
137 | parameters_data = dict() |
||
138 | parameters_data['names'] = list() |
||
139 | parameters_data['timestamps'] = list() |
||
140 | parameters_data['values'] = list() |
||
141 | |||
142 | View Code Duplication | if not is_quick_mode: |
|
143 | for point in point_list: |
||
144 | point_values = [] |
||
145 | point_timestamps = [] |
||
146 | if point['object_type'] == 'ENERGY_VALUE': |
||
147 | energy_value_data['name'] = point['name'] + ' (' + point['units'] + ')' |
||
148 | query = (" SELECT utc_date_time, actual_value " |
||
149 | " FROM tbl_energy_value " |
||
150 | " WHERE point_id = %s " |
||
151 | " AND utc_date_time BETWEEN %s AND %s " |
||
152 | " ORDER BY utc_date_time ") |
||
153 | cursor_historical.execute(query, (point['id'], |
||
154 | reporting_start_datetime_utc, |
||
155 | reporting_end_datetime_utc)) |
||
156 | rows = cursor_historical.fetchall() |
||
157 | if rows is not None and len(rows) > 0: |
||
158 | for row in rows: |
||
159 | current_datetime_local = row[0].replace(tzinfo=timezone.utc) + \ |
||
160 | timedelta(minutes=timezone_offset) |
||
161 | current_datetime = current_datetime_local.isoformat()[0:19] |
||
162 | energy_value_data['timestamps'].append(current_datetime) |
||
163 | energy_value_data['values'].append(row[1]) |
||
164 | elif point['object_type'] == 'ANALOG_VALUE': |
||
165 | |||
166 | query = (" SELECT utc_date_time, actual_value " |
||
167 | " FROM tbl_analog_value " |
||
168 | " WHERE point_id = %s " |
||
169 | " AND utc_date_time BETWEEN %s AND %s " |
||
170 | " ORDER BY utc_date_time ") |
||
171 | cursor_historical.execute(query, (point['id'], |
||
172 | reporting_start_datetime_utc, |
||
173 | reporting_end_datetime_utc)) |
||
174 | rows = cursor_historical.fetchall() |
||
175 | |||
176 | if rows is not None and len(rows) > 0: |
||
177 | for row in rows: |
||
178 | current_datetime_local = row[0].replace(tzinfo=timezone.utc) + \ |
||
179 | timedelta(minutes=timezone_offset) |
||
180 | current_datetime = current_datetime_local.isoformat()[0:19] |
||
181 | point_timestamps.append(current_datetime) |
||
182 | point_values.append(row[1]) |
||
183 | |||
184 | parameters_data['names'].append(point['name'] + ' (' + point['units'] + ')') |
||
185 | parameters_data['timestamps'].append(point_timestamps) |
||
186 | parameters_data['values'].append(point_values) |
||
187 | elif point['object_type'] == 'DIGITAL_VALUE': |
||
188 | query = (" SELECT utc_date_time, actual_value " |
||
189 | " FROM tbl_digital_value " |
||
190 | " WHERE point_id = %s " |
||
191 | " AND utc_date_time BETWEEN %s AND %s " |
||
192 | " ORDER BY utc_date_time ") |
||
193 | cursor_historical.execute(query, (point['id'], |
||
194 | reporting_start_datetime_utc, |
||
195 | reporting_end_datetime_utc)) |
||
196 | rows = cursor_historical.fetchall() |
||
197 | |||
198 | if rows is not None and len(rows) > 0: |
||
199 | for row in rows: |
||
200 | current_datetime_local = row[0].replace(tzinfo=timezone.utc) + \ |
||
201 | timedelta(minutes=timezone_offset) |
||
202 | current_datetime = current_datetime_local.isoformat()[0:19] |
||
203 | point_timestamps.append(current_datetime) |
||
204 | point_values.append(row[1]) |
||
205 | |||
206 | parameters_data['names'].append(point['name'] + ' (' + point['units'] + ')') |
||
207 | parameters_data['timestamps'].append(point_timestamps) |
||
208 | parameters_data['values'].append(point_values) |
||
209 | |||
210 | ################################################################################################################ |
||
211 | # Step 6: construct the report |
||
212 | ################################################################################################################ |
||
213 | if cursor_system: |
||
214 | cursor_system.close() |
||
215 | if cnx_system: |
||
216 | cnx_system.close() |
||
217 | |||
218 | if cursor_historical: |
||
219 | cursor_historical.close() |
||
220 | if cnx_historical: |
||
221 | cnx_historical.close() |
||
222 | |||
223 | result = { |
||
224 | "meter": { |
||
225 | "cost_center_id": meter['cost_center_id'], |
||
226 | "energy_category_id": meter['energy_category_id'], |
||
227 | "energy_category_name": meter['energy_category_name'], |
||
228 | "unit_of_measure": meter['unit_of_measure'], |
||
229 | }, |
||
230 | "energy_value": energy_value_data, |
||
231 | "parameters": { |
||
232 | "names": parameters_data['names'], |
||
233 | "timestamps": parameters_data['timestamps'], |
||
234 | "values": parameters_data['values'] |
||
235 | }, |
||
236 | |||
237 | } |
||
238 | |||
239 | resp.text = json.dumps(result) |
||
240 |