WikiDomainLookup::loadUncached() - Code Metrics - Inspection of "Merge pull request #2 from ebernhardson/meta-sitem..." - MusikAnimal/global-search - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2cb25c...1f8869 )

by MusikAnimal

created 2019-05-25 01:38 UTC

WikiDomainLookup::loadUncached() A

↳ Parent: WikiDomainLookup

Complexity

Conditions	5
Paths	6

Size

Total Lines	23
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	16
dl	0
loc	23
rs	9.4222
c	0
b	0
f	0
cc	5
nc	6
nop	0

<?php

declare(strict_types=1);

namespace App;

use GuzzleHttp\Client as GuzzleClient;
use Psr\Cache\CacheItemInterface;
use Psr\Cache\CacheItemPoolInterface;

class WikiDomainLookup
{
    /** @var GuzzleClient */
    private $guzzle;

    /** @var CacheItemPoolInterface */
    private $cache;

    private const CACHE_KEY = 'global-search-wikidomainlookup';

    /** @var string Duration of cache for lookup table, as accepted by DateInterval::createFromDateString() */
    private const CACHE_TIME = '10 hours';

    public function __construct(GuzzleClient $guzzle, CacheItemPoolInterface $cache)
    {
        $this->guzzle = $guzzle;
        $this->cache = $cache;
    }

    public function load(): array
    {
        $cacheItem = $this->cache->getItem(self::CACHE_KEY);
        $lookup = null; //$cacheItem->get();
        if ($lookup === null) {

            $lookup = $this->loadUncached();
            $cacheItem->set($lookup)
                ->expiresAfter(\DateInterval::createFromDateString(self::CACHE_TIME));
            $this->cache->save($cacheItem);
        }
        return $lookup;
    }

    public function loadUncached(): array
    {
        $res = $this->guzzle->request('GET', 'https://meta.wikimedia.org/w/api.php', [
            'query' => [
                'format' => 'json',
                'formatversion' => 2,
                'action' => 'sitematrix',
                'smlangprop' => 'site',
                'smsiteprop' => 'url|dbname',
            ]
        ]);
        $decoded = json_decode($res->getBody()->getContents(), true)['sitematrix'];
        $lookup = [];
        foreach ($decoded as $k => $v) {
            if ($k === 'count') {
                continue;
            }
            $sites = $k === 'specials' ? $v : $v['site'];
            foreach ($sites as $site) {
                $lookup[$site['dbname']] = parse_url($site['url'], PHP_URL_HOST);
            }
        }
        return $lookup;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App;
6
7			use GuzzleHttp\Client as GuzzleClient;
8			use Psr\Cache\CacheItemInterface;
9			use Psr\Cache\CacheItemPoolInterface;
10
11			class WikiDomainLookup
12			{
13			/** @var GuzzleClient */
14			private $guzzle;
15
16			/** @var CacheItemPoolInterface */
17			private $cache;
18
19			private const CACHE_KEY = 'global-search-wikidomainlookup';
20
21			/** @var string Duration of cache for lookup table, as accepted by DateInterval::createFromDateString() */
22			private const CACHE_TIME = '10 hours';
23
24			public function __construct(GuzzleClient $guzzle, CacheItemPoolInterface $cache)
25			{
26			$this->guzzle = $guzzle;
27			$this->cache = $cache;
28			}
29
30			public function load(): array
31			{
32			$cacheItem = $this->cache->getItem(self::CACHE_KEY);
33			$lookup = null; //$cacheItem->get();
34			if ($lookup === null) {
			0 ignored issues – show introduced 2019-05-24 21:28 UTC by Report Bug Copy Issue Report The condition `$lookup === null` is always `true`. Loading history...
35			$lookup = $this->loadUncached();
36			$cacheItem->set($lookup)
37			->expiresAfter(\DateInterval::createFromDateString(self::CACHE_TIME));
38			$this->cache->save($cacheItem);
39			}
40			return $lookup;
41			}
42
43			public function loadUncached(): array
44			{
45			$res = $this->guzzle->request('GET', 'https://meta.wikimedia.org/w/api.php', [
46			'query' => [
47			'format' => 'json',
48			'formatversion' => 2,
49			'action' => 'sitematrix',
50			'smlangprop' => 'site',
51			'smsiteprop' => 'url\|dbname',
52			]
53			]);
54			$decoded = json_decode($res->getBody()->getContents(), true)['sitematrix'];
55			$lookup = [];
56			foreach ($decoded as $k => $v) {
57			if ($k === 'count') {
58			continue;
59			}
60			$sites = $k === 'specials' ? $v : $v['site'];
61			foreach ($sites as $site) {
62			$lookup[$site['dbname']] = parse_url($site['url'], PHP_URL_HOST);
63			}
64			}
65			return $lookup;
66			}
67			}
68

MusikAnimal / global-search

Push — master ( 2cb25c...1f8869 )

WikiDomainLookup::loadUncached() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like