Conditions | 38 |
Paths | 38 |
Total Lines | 117 |
Code Lines | 115 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
272 | function handleStatusCode(int $statusCode): string |
||
273 | { |
||
274 | switch ($statusCode) { |
||
275 | case 100: |
||
276 | return 'Continue'; |
||
277 | break; |
||
278 | case 101: |
||
279 | return 'Switching Protocols'; |
||
280 | break; |
||
281 | case 200: |
||
282 | return 'OK'; |
||
283 | break; |
||
284 | case 201: |
||
285 | return 'Created'; |
||
286 | break; |
||
287 | case 202: |
||
288 | return 'Accepted'; |
||
289 | break; |
||
290 | case 203: |
||
291 | return 'Non-Authoritative Information'; |
||
292 | break; |
||
293 | case 204: |
||
294 | return 'No Content'; |
||
295 | break; |
||
296 | case 205: |
||
297 | return 'Reset Content'; |
||
298 | break; |
||
299 | case 206: |
||
300 | return 'Partial Content'; |
||
301 | break; |
||
302 | case 300: |
||
303 | return 'Multiple Choices'; |
||
304 | break; |
||
305 | case 301: |
||
306 | return 'Moved Permanently'; |
||
307 | break; |
||
308 | case 302: |
||
309 | return 'Moved Temporarily'; |
||
310 | break; |
||
311 | case 303: |
||
312 | return 'See Other'; |
||
313 | break; |
||
314 | case 304: |
||
315 | return 'Not Modified'; |
||
316 | break; |
||
317 | case 305: |
||
318 | return 'Use Proxy'; |
||
319 | break; |
||
320 | case 400: |
||
321 | return 'Bad Request'; |
||
322 | break; |
||
323 | case 401: |
||
324 | return 'Unauthorized'; |
||
325 | break; |
||
326 | case 402: |
||
327 | return 'Payment Required'; |
||
328 | break; |
||
329 | case 403: |
||
330 | return 'Forbidden'; |
||
331 | break; |
||
332 | case 404: |
||
333 | return 'Not Found'; |
||
334 | break; |
||
335 | case 405: |
||
336 | return 'Method Not Allowed'; |
||
337 | break; |
||
338 | case 406: |
||
339 | return 'Not Acceptable'; |
||
340 | break; |
||
341 | case 407: |
||
342 | return 'Proxy Authentication Required'; |
||
343 | break; |
||
344 | case 408: |
||
345 | return 'Request Time-out'; |
||
346 | break; |
||
347 | case 409: |
||
348 | return 'Conflict'; |
||
349 | break; |
||
350 | case 410: |
||
351 | return 'Gone'; |
||
352 | break; |
||
353 | case 411: |
||
354 | return 'Length Required'; |
||
355 | break; |
||
356 | case 412: |
||
357 | return 'Precondition Failed'; |
||
358 | break; |
||
359 | case 413: |
||
360 | return 'Request Entity Too Large'; |
||
361 | break; |
||
362 | case 414: |
||
363 | return 'Request-URI Too Large'; |
||
364 | break; |
||
365 | case 415: |
||
366 | return 'Unsupported Media Type'; |
||
367 | break; |
||
368 | case 500: |
||
369 | return 'Internal Server Error'; |
||
370 | break; |
||
371 | case 501: |
||
372 | return 'Not Implemented'; |
||
373 | break; |
||
374 | case 502: |
||
375 | return 'Bad Gateway'; |
||
376 | break; |
||
377 | case 503: |
||
378 | return 'Service Unavailable'; |
||
379 | break; |
||
380 | case 504: |
||
381 | return 'Gateway Time-out'; |
||
382 | break; |
||
383 | case 505: |
||
384 | return 'HTTP Version not supported'; |
||
385 | break; |
||
386 | default: |
||
387 | return 'unknown'; |
||
388 | break; |
||
389 | } |
||
391 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.