ProductFunctions::validateOrderAndDirection() - Code Metrics - Inspection of "Extracting product functions to trait" - MuriloChianfa/Redstore-Microservice-Based - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 073ade...83c67c )

by Murilo

created 2021-12-19 18:30 UTC

ProductFunctions::validateOrderAndDirection() A

↳ Parent: ProductFunctions

Complexity

Conditions	5
Paths	5

Size

Total Lines	29
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	17
c	1
b	0
f	0
dl	0
loc	29
rs	9.3888
cc	5
nc	5
nop	1

<?php

namespace Source\Controllers;

use stdClass;
use Source\Core\Request;
use Source\Core\Response;
use Source\Models\Product;
use Source\Models\ProductImage;
use Source\Models\Category;

trait ProductFunctions
{
    private function validateSingleProductId($data)
    {
        if (empty($data['id'])) {
            $this->Message->message = 'ID do produto inválido';

            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }
    
        $id = filter_var($data['id'], FILTER_VALIDATE_INT);

        if (!$id) {
            $this->Message->message = 'parâmetro inválido';
            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }

        return $id;
    }

    private function validateProductId($data)
    {
        if (!isset($data['id'])) {
            $this->Message->message = 'Id do produto inválido!';

            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }

        $id = filter_var($data["id"], FILTER_VALIDATE_INT);

        if (!$id) {
            $this->Message->message = 'Id do produto inválido!';
            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }

        $Product = new Product();
        $Product = $Product->findById($id, 'id');
        
        if (is_null($Product)) {
            $this->Message->message = 'Produto não encontrado!';
            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }

        return $Product;
    }

    private function allProductsWithoutFilters($data)
    {
        if (!empty($data)) {
            return; 
        }

        if (is_null(($products = $Product->findAll()))) {

            (new Response())->setStatusCode(HTTP_NO_CONTENT)->send($this->Message);

        }

        $this->Message->message = $products;
        (new Response())->setStatusCode(HTTP_OK)->send($this->Message);
    }

    private function validatePagination($data)
    {
        if (!isset($data['page']) || !isset($data['limit'])) {
            $this->Message->message = [

                'message' => 'Missing page or limit argument'
            ];

            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }
    }

    private function validateOrderAndDirection($data)
    {
        if (!isset($data['order']) || !isset($data['direction'])) {
            return;
        }

        $page = filter_var($data['page'], FILTER_VALIDATE_INT);
        $limit = filter_var($data['limit'], FILTER_VALIDATE_INT);

        $find = $this->validateSearchFilters($data);

        $find = $find->order($data['order'] . ' ' . $data['direction']);
        $find = $find->limit($limit);
        $find = $find->offset(($page * $limit) - $limit);
        $products = $find->fetch(true);

        if (empty($products)) {
            (new Response())->setStatusCode(HTTP_NO_CONTENT)->send($this->Message);

        }

        foreach ($products as $key => $value) {
            $products[$key] = $value->data();

            $products[$key]->category = (new Category())->findById((int) $products[$key]->product_type_id)->data();
            $products[$key]->ProductImage = (new ProductImage())->findAllByProductId((int) $products[$key]->id);
        }

        $this->Message->message = $products;
        (new Response())->setStatusCode(HTTP_OK)->send($this->Message);
    }

    private function validateSearchFilters($data)
    {
        $Product = new Product();

        if (empty($data['filterColumn'])) {
            return $Product->find();
        }
        
        if (empty($data['selfId'])) {
            return $Product->find("{$data['filterColumn']} = {$data['filterValue']}");
        }

        return $Product->find("{$data['filterColumn']} = {$data['filterValue']} AND id != {$data['selfId']}");
    }

    private function validateImageUpload($data)
    {
        if (empty($data['image'])) {
            $this->Message->message = 'imagem nao encontrada';

            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }

        $base64Image = $data['image'];

        try {
            $base64 = getimagesizefromstring(base64_decode(explode(',', $base64Image)[1]));
        } catch (\Exception $e) {
            $this->Message->message = 'imagem invalida';
            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }

        if (!$base64) {

            $this->Message->message = 'imagem invalida';
            (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
        }

        if (!empty($base64[0]) && !empty($base64[0]) && !empty($base64['mime'])) {
            if (!in_array($base64['mime'], $this->validExtensions)) {
                $this->Message->message = 'tipo de imagem invalida';
                (new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
            }
        }

        return $base64Image;
    }
}


1			<?php
2
3			namespace Source\Controllers;
4
5			use stdClass;
6			use Source\Core\Request;
7			use Source\Core\Response;
8			use Source\Models\Product;
9			use Source\Models\ProductImage;
10			use Source\Models\Category;
11
12			trait ProductFunctions
13			{
14			private function validateSingleProductId($data)
15			{
16			if (empty($data['id'])) {
17			$this->Message->message = 'ID do produto inválido';
			0 ignored issues – show Bug introduced 2021-12-19 18:31 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `Source\Controllers\ProductFunctions`. Did you mean `message`? Loading history...
18			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
19			}
20
21			$id = filter_var($data['id'], FILTER_VALIDATE_INT);
22
23			if (!$id) {
24			$this->Message->message = 'parâmetro inválido';
25			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
26			}
27
28			return $id;
29			}
30
31			private function validateProductId($data)
32			{
33			if (!isset($data['id'])) {
34			$this->Message->message = 'Id do produto inválido!';
			0 ignored issues – show Bug introduced 2021-12-19 18:31 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `Source\Controllers\ProductFunctions`. Did you mean `message`? Loading history...
35			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
36			}
37
38			$id = filter_var($data["id"], FILTER_VALIDATE_INT);
39
40			if (!$id) {
41			$this->Message->message = 'Id do produto inválido!';
42			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
43			}
44
45			$Product = new Product();
46			$Product = $Product->findById($id, 'id');
47
48			if (is_null($Product)) {
49			$this->Message->message = 'Produto não encontrado!';
50			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
51			}
52
53			return $Product;
54			}
55
56			private function allProductsWithoutFilters($data)
57			{
58			if (!empty($data)) {
59			return;
60			}
61
62			if (is_null(($products = $Product->findAll()))) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-12-19 18:24 UTC by Report Bug Copy Issue Report The variable `$Product` seems to be never defined. Loading history...
63			(new Response())->setStatusCode(HTTP_NO_CONTENT)->send($this->Message);
			0 ignored issues – show Bug introduced 2021-12-19 18:31 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `Source\Controllers\ProductFunctions`. Did you mean `message`? Loading history...
64			}
65
66			$this->Message->message = $products;
67			(new Response())->setStatusCode(HTTP_OK)->send($this->Message);
68			}
69
70			private function validatePagination($data)
71			{
72			if (!isset($data['page']) \|\| !isset($data['limit'])) {
73			$this->Message->message = [
			0 ignored issues – show Bug introduced 2021-12-19 18:31 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `Source\Controllers\ProductFunctions`. Did you mean `message`? Loading history...
74			'message' => 'Missing page or limit argument'
75			];
76
77			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
78			}
79			}
80
81			private function validateOrderAndDirection($data)
82			{
83			if (!isset($data['order']) \|\| !isset($data['direction'])) {
84			return;
85			}
86
87			$page = filter_var($data['page'], FILTER_VALIDATE_INT);
88			$limit = filter_var($data['limit'], FILTER_VALIDATE_INT);
89
90			$find = $this->validateSearchFilters($data);
91
92			$find = $find->order($data['order'] . ' ' . $data['direction']);
93			$find = $find->limit($limit);
94			$find = $find->offset(($page * $limit) - $limit);
95			$products = $find->fetch(true);
96
97			if (empty($products)) {
98			(new Response())->setStatusCode(HTTP_NO_CONTENT)->send($this->Message);
			0 ignored issues – show Bug introduced 2021-12-19 18:31 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `Source\Controllers\ProductFunctions`. Did you mean `message`? Loading history...
99			}
100
101			foreach ($products as $key => $value) {
102			$products[$key] = $value->data();
103
104			$products[$key]->category = (new Category())->findById((int) $products[$key]->product_type_id)->data();
105			$products[$key]->ProductImage = (new ProductImage())->findAllByProductId((int) $products[$key]->id);
106			}
107
108			$this->Message->message = $products;
109			(new Response())->setStatusCode(HTTP_OK)->send($this->Message);
110			}
111
112			private function validateSearchFilters($data)
113			{
114			$Product = new Product();
115
116			if (empty($data['filterColumn'])) {
117			return $Product->find();
118			}
119
120			if (empty($data['selfId'])) {
121			return $Product->find("{$data['filterColumn']} = {$data['filterValue']}");
122			}
123
124			return $Product->find("{$data['filterColumn']} = {$data['filterValue']} AND id != {$data['selfId']}");
125			}
126
127			private function validateImageUpload($data)
128			{
129			if (empty($data['image'])) {
130			$this->Message->message = 'imagem nao encontrada';
			0 ignored issues – show Bug introduced 2021-12-19 18:31 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `Source\Controllers\ProductFunctions`. Did you mean `message`? Loading history...
131			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
132			}
133
134			$base64Image = $data['image'];
135
136			try {
137			$base64 = getimagesizefromstring(base64_decode(explode(',', $base64Image)[1]));
138			} catch (\Exception $e) {
139			$this->Message->message = 'imagem invalida';
140			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
141			}
142
143			if (!$base64) {
			0 ignored issues – show Bug Best Practice introduced 2021-12-19 18:24 UTC by Report Bug Copy Issue Report The expression `$base64` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
144			$this->Message->message = 'imagem invalida';
145			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
146			}
147
148			if (!empty($base64[0]) && !empty($base64[0]) && !empty($base64['mime'])) {
149			if (!in_array($base64['mime'], $this->validExtensions)) {
150			$this->Message->message = 'tipo de imagem invalida';
151			(new Response())->setStatusCode(HTTP_BAD_REQUEST)->send($this->Message);
152			}
153			}
154
155			return $base64Image;
156			}
157			}
158

MuriloChianfa / Redstore-Microservice-Based

Push — master ( 073ade...83c67c )

ProductFunctions::validateOrderAndDirection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like