PhoneController::updatePhone() - Code Metrics - Inspection of "Extracting methods from user controller" - MuriloChianfa/Redstore-Microservice-Based - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b616ab...e5c15e )

by Murilo

created 2021-12-03 01:21 UTC

PhoneController::updatePhone() B

↳ Parent: PhoneController

Complexity

Conditions	8
Paths	7

Size

Total Lines	53
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	34
c	1
b	0
f	0
dl	0
loc	53
rs	8.1315
cc	8
nc	7
nop	1

How to fix Long Method

<?php

namespace Source\Controllers;

use \stdClass;

use Source\Core\Request;
use Source\Core\Response;

use Source\Models\User;
use Source\Models\Phone;
use Source\Models\Gender;
use Source\Models\AccessLevel;
use Source\Models\Address\Address;
use Source\Models\Address\City;

use Source\Controllers\Auth;

final class PhoneController
{
    private $Message;

    private $Request;

    private $token;

    public function __construct()
    {
        $this->Message = new stdClass();
        $this->Request = new Request();

        $this->token = (new Auth())->validateLogin();
    }

    public function addPhone($data)
    {
        $data = filter_var_array($data, FILTER_SANITIZE_STRIPPED);

        if (empty($data)) {
            $this->Message->message = 'Campos inválidos!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
            return;
        }

        $User = new User();
        /** @var Source\Models\User $User */
        $User = $User->findById($this->token['id'], 'id');

        if (!$User || $User == null) {
            $this->Message->message = 'Usuário não encontrado!';
            (new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
            return;
        }

        if (empty($data['number'])) {
            $this->Message->message = 'Número de telefone inválido!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
            return;
        }

        /** @var Source\Models\Phone $Phone */
        $Phone = new Phone();
        $Phone->user_id = $User->id;
        $Phone->phone_type_id = 1;
        $Phone->number = $data['number'];

        if (!$Phone->save()) {
            $this->Message->message = $User->message();
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
            return;
        }

        $this->Message->message = 'Alteração realizada com sucesso!';
        (new Response())->setStatusCode(HTTP_OK)->send($this->Message);
        return;
    }
    
    public function updatePhone($data)
    {
        $data = filter_var_array($data, FILTER_SANITIZE_STRIPPED);

        if (empty($data)) {
            $this->Message->message = 'Campos inválidos!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
            return;
        }

        $User = new User();
        $User = $User->findById($this->token['id'], 'id');

        if (!$User || $User == null) {
            $this->Message->message = 'Usuário não encontrado!';
            (new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
            return;
        }

        if (!filter_var($data['id'], FILTER_VALIDATE_INT)) {
            $this->Message->message = 'Número de telefone inválido!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
            return;
        }

        $Phone = new Phone();
        /** @var Source\Models\Phone $Phone */
        $Phone = $Phone->findById($data['id'], 'id, user_id');

        if ($User->id != $Phone->user_id) {

            $this->Message->message = 'Você não possui permisão para alterar este telefone!';
            (new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
            return;
        }

        if (empty($data['number'])) {
            $this->Message->message = 'Número de telefone inválido!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
            return;
        }

        $Phone->phone_type_id = 1;
        $Phone->number = $data['number'];

        if (!$Phone->save()) {
            $this->Message->message = $Phone->message();
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
            return;
        }

        $this->Message->message = 'Alteração realizada com sucesso!';
        (new Response())->setStatusCode(HTTP_OK)->send($this->Message);
        return;
    }
}


1			<?php
2
3			namespace Source\Controllers;
4
5			use \stdClass;
6
7			use Source\Core\Request;
8			use Source\Core\Response;
9
10			use Source\Models\User;
11			use Source\Models\Phone;
12			use Source\Models\Gender;
13			use Source\Models\AccessLevel;
14			use Source\Models\Address\Address;
15			use Source\Models\Address\City;
16
17			use Source\Controllers\Auth;
18
19			final class PhoneController
20			{
21			private $Message;
22
23			private $Request;
24
25			private $token;
26
27			public function __construct()
28			{
29			$this->Message = new stdClass();
30			$this->Request = new Request();
31
32			$this->token = (new Auth())->validateLogin();
33			}
34
35			public function addPhone($data)
36			{
37			$data = filter_var_array($data, FILTER_SANITIZE_STRIPPED);
38
39			if (empty($data)) {
40			$this->Message->message = 'Campos inválidos!';
41			(new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
42			return;
43			}
44
45			$User = new User();
46			/** @var Source\Models\User $User */
47			$User = $User->findById($this->token['id'], 'id');
48
49			if (!$User \|\| $User == null) {
50			$this->Message->message = 'Usuário não encontrado!';
51			(new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
52			return;
53			}
54
55			if (empty($data['number'])) {
56			$this->Message->message = 'Número de telefone inválido!';
57			(new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
58			return;
59			}
60
61			/** @var Source\Models\Phone $Phone */
62			$Phone = new Phone();
63			$Phone->user_id = $User->id;
64			$Phone->phone_type_id = 1;
65			$Phone->number = $data['number'];
66
67			if (!$Phone->save()) {
68			$this->Message->message = $User->message();
69			(new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
70			return;
71			}
72
73			$this->Message->message = 'Alteração realizada com sucesso!';
74			(new Response())->setStatusCode(HTTP_OK)->send($this->Message);
75			return;
76			}
77
78			public function updatePhone($data)
79			{
80			$data = filter_var_array($data, FILTER_SANITIZE_STRIPPED);
81
82			if (empty($data)) {
83			$this->Message->message = 'Campos inválidos!';
84			(new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
85			return;
86			}
87
88			$User = new User();
89			$User = $User->findById($this->token['id'], 'id');
90
91			if (!$User \|\| $User == null) {
92			$this->Message->message = 'Usuário não encontrado!';
93			(new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
94			return;
95			}
96
97			if (!filter_var($data['id'], FILTER_VALIDATE_INT)) {
98			$this->Message->message = 'Número de telefone inválido!';
99			(new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
100			return;
101			}
102
103			$Phone = new Phone();
104			/** @var Source\Models\Phone $Phone */
105			$Phone = $Phone->findById($data['id'], 'id, user_id');
106
107			if ($User->id != $Phone->user_id) {
			0 ignored issues – show Bug Best Practice introduced 2021-09-13 19:00 UTC by Report Bug Copy Issue Report The property `id` does not exist on `Source\Core\Model`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
108			$this->Message->message = 'Você não possui permisão para alterar este telefone!';
109			(new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
110			return;
111			}
112
113			if (empty($data['number'])) {
114			$this->Message->message = 'Número de telefone inválido!';
115			(new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
116			return;
117			}
118
119			$Phone->phone_type_id = 1;
120			$Phone->number = $data['number'];
121
122			if (!$Phone->save()) {
123			$this->Message->message = $Phone->message();
124			(new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
125			return;
126			}
127
128			$this->Message->message = 'Alteração realizada com sucesso!';
129			(new Response())->setStatusCode(HTTP_OK)->send($this->Message);
130			return;
131			}
132			}
133

MuriloChianfa / Redstore-Microservice-Based

Push — master ( b616ab...e5c15e )

PhoneController::updatePhone() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like