AddressController::addAddress() - Code Metrics - Inspection of "Improving comploxity of readability in some functi..." - MuriloChianfa/Redstore-Microservice-Based - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b58a23...eebb3c )

by Murilo

created 2021-12-19 17:19 UTC

AddressController::addAddress() B

↳ Parent: AddressController

Complexity

Conditions	10
Paths	32

Size

Total Lines	50
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	31
c	1
b	0
f	0
dl	0
loc	50
rs	7.6666
cc	10
nc	32
nop	1

How to fix Complexity

<?php

namespace Source\Controllers;

use stdClass;
use Source\Core\Request;
use Source\Core\Response;
use Source\Models\User;
use Source\Models\Phone;
use Source\Models\Gender;
use Source\Models\AccessLevel;
use Source\Models\Address\Address;
use Source\Models\Address\City;
use Source\Controllers\Auth;

final class AddressController
{
    private $Message;

    private $Request;

    private $token;

    public function __construct()
    {
        $this->Message = new stdClass();
        $this->Request = new Request();

        $this->token = (new Auth())->validateLogin();
    }

    public function addAddress($data)
    {
        $data = filter_var_array($data, FILTER_SANITIZE_STRIPPED);

        if (empty($data)) {
            $this->Message->message = 'Campos inválidos!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        $User = new User();
        /** @var Source\Models\User $User */
        $User = $User->findById($this->token['id'], 'id');

        if (!$User || $User == null) {
            $this->Message->message = 'Usuário não encontrado!';
            (new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
        }

        $city_id = filter_var($data['city_id'], FILTER_DEFAULT);
        $street = filter_var($data['street'], FILTER_DEFAULT);
        $complement = filter_var($data['complement'], FILTER_DEFAULT);
        $cep = filter_var($data['cep'], FILTER_DEFAULT);
        $number = filter_var($data['number'], FILTER_DEFAULT);

        if (!$city_id || !$street || !$cep || !$number) {
            $this->Message->message = 'Endereço inválido!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        /** @var Source\Models\Address $Address */
        $Address = new Address();

        $Address->city_id = $city_id;
        $Address->street = $street;
        $Address->complement = $complement;
        $Address->cep = $cep;
        $Address->number = $number;

        if (!$Address->save()) {
            $this->Message->message = $Address->message();
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        if (!Address::bindAddress($User->id, $Address->id)) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
            $this->Message->message = 'Ocorreu algum erro ao cadastrar o endereço!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        $this->Message->message = 'Endereço salvo com sucesso!';
        (new Response())->setStatusCode(HTTP_OK)->send($this->Message);
    }

    public function updateAddress($data)
    {
        $data = filter_var_array($data, FILTER_SANITIZE_STRIPPED);

        if (empty($data) || !isset($data['id']) || !filter_var($data['id'], FILTER_VALIDATE_INT)) {
            $this->Message->message = 'Campos inválidos!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        $User = new User();
        $User = $User->findById($this->token['id'], 'id');

        if (!$User || $User == null) {
            $this->Message->message = 'Usuário não encontrado!';
            (new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
        }

        if (!Address::getBindedAddress($User->id, $data['id'])) {
        if (!Address::getBindedAddress(/** @scrutinizer ignore-type */ $User->id, $data['id'])) {
            $this->Message->message = 'Você não possui permissão para editar este endereço!';
            (new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
        }

        $this->verifyAddressData();
               verifyAddressData();

        /** @var Source\Models\Address $Address */
        $Address = new Address();
        $Address->city_id = $data['city_id'];
        $Address->street = $data['street'];
        $Address->cep = $data['cep'];
        $Address->number = $data['number'];

        if (!$Address->save()) {
            $this->Message->message = $Address->message();
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        $this->Message->message = 'Endereço salvo com sucesso!';
        (new Response())->setStatusCode(HTTP_OK)->send($this->Message);
    }

    private function verifyAddressData($data)
    {
        if (empty($data['city_id'])) {
            $this->Message->message = 'Cidade inválida!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        $City = new City();

        if (!$City->findById($data['city_id'])) {
            $this->Message->message = 'Cidade inválida!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        if (empty($data['street'])) {
            $this->Message->message = 'Nome da rua inválida!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        if (empty($data['cep'])) {
            $this->Message->message = 'CEP inválido!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        if (empty($data['number'])) {
            $this->Message->message = 'Número da casa inválido!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }
    }

    public function address($data)
    {
        $data = filter_var_array($data, FILTER_SANITIZE_STRIPPED);

        if (empty($data) || !isset($data['id']) || !filter_var($data['id'], FILTER_VALIDATE_INT)) {
            $this->Message->message = 'Campos inválidos!';
            (new Response())->setStatusCode(HTTP_PARTIAL_CONTENT)->send($this->Message);
        }

        /** @var Source\Models\Address $Address */
        $Address = new Address();
        $result = $Address->findById($data['id'], "*");

        if (!$result || $result == null) {
            $this->Message->message = 'Endereço não encontrado!';
            (new Response())->setStatusCode(HTTP_NOT_FOUND)->send($this->Message);
        }

        $result = $result->data();
        $this->Message->message = $result;

        (new Response())->setStatusCode(HTTP_OK)->send($this->Message);
    }
}


MuriloChianfa / Redstore-Microservice-Based

Push — master ( b58a23...eebb3c )

AddressController::addAddress() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like