| Conditions | 12 |
| Paths | 12 |
| Total Lines | 104 |
| Code Lines | 22 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 192 | function starRate(float $rate): string |
||
| 193 | { |
||
| 194 | if ($rate <= 0.4) { |
||
| 195 | return ' |
||
| 196 | <i class="fa fa-star-o"></i> |
||
| 197 | <i class="fa fa-star-o"></i> |
||
| 198 | <i class="fa fa-star-o"></i> |
||
| 199 | <i class="fa fa-star-o"></i> |
||
| 200 | <i class="fa fa-star-o"></i> |
||
| 201 | '; |
||
| 202 | } |
||
| 203 | |||
| 204 | if ($rate <= 0.9) { |
||
| 205 | return ' |
||
| 206 | <i class="fa fa-star-half-o"></i> |
||
| 207 | <i class="fa fa-star-o"></i> |
||
| 208 | <i class="fa fa-star-o"></i> |
||
| 209 | <i class="fa fa-star-o"></i> |
||
| 210 | <i class="fa fa-star-o"></i> |
||
| 211 | '; |
||
| 212 | } |
||
| 213 | |||
| 214 | if ($rate <= 1.4) { |
||
| 215 | return ' |
||
| 216 | <i class="fa fa-star"></i> |
||
| 217 | <i class="fa fa-star-o"></i> |
||
| 218 | <i class="fa fa-star-o"></i> |
||
| 219 | <i class="fa fa-star-o"></i> |
||
| 220 | <i class="fa fa-star-o"></i> |
||
| 221 | '; |
||
| 222 | } |
||
| 223 | |||
| 224 | if ($rate <= 1.9) { |
||
| 225 | return ' |
||
| 226 | <i class="fa fa-star"></i> |
||
| 227 | <i class="fa fa-star-half-o"></i> |
||
| 228 | <i class="fa fa-star-o"></i> |
||
| 229 | <i class="fa fa-star-o"></i> |
||
| 230 | <i class="fa fa-star-o"></i> |
||
| 231 | '; |
||
| 232 | } |
||
| 233 | |||
| 234 | if ($rate <= 2.4) { |
||
| 235 | return ' |
||
| 236 | <i class="fa fa-star"></i> |
||
| 237 | <i class="fa fa-star"></i> |
||
| 238 | <i class="fa fa-star-o"></i> |
||
| 239 | <i class="fa fa-star-o"></i> |
||
| 240 | <i class="fa fa-star-o"></i> |
||
| 241 | '; |
||
| 242 | } |
||
| 243 | |||
| 244 | if ($rate <= 2.9) { |
||
| 245 | return ' |
||
| 246 | <i class="fa fa-star"></i> |
||
| 247 | <i class="fa fa-star"></i> |
||
| 248 | <i class="fa fa-star-half-o"></i> |
||
| 249 | <i class="fa fa-star-o"></i> |
||
| 250 | <i class="fa fa-star-o"></i> |
||
| 251 | '; |
||
| 252 | } |
||
| 253 | |||
| 254 | if ($rate <= 3.4) { |
||
| 255 | return ' |
||
| 256 | <i class="fa fa-star"></i> |
||
| 257 | <i class="fa fa-star"></i> |
||
| 258 | <i class="fa fa-star"></i> |
||
| 259 | <i class="fa fa-star-o"></i> |
||
| 260 | <i class="fa fa-star-o"></i> |
||
| 261 | '; |
||
| 262 | } |
||
| 263 | |||
| 264 | if ($rate <= 3.9) { |
||
| 265 | return ' |
||
| 266 | <i class="fa fa-star"></i> |
||
| 267 | <i class="fa fa-star"></i> |
||
| 268 | <i class="fa fa-star"></i> |
||
| 269 | <i class="fa fa-star-half-o"></i> |
||
| 270 | <i class="fa fa-star-o"></i> |
||
| 271 | '; |
||
| 272 | } |
||
| 273 | |||
| 274 | if ($rate <= 4.4) { |
||
| 275 | return ' |
||
| 276 | <i class="fa fa-star"></i> |
||
| 277 | <i class="fa fa-star"></i> |
||
| 278 | <i class="fa fa-star"></i> |
||
| 279 | <i class="fa fa-star"></i> |
||
| 280 | <i class="fa fa-star-o"></i> |
||
| 281 | '; |
||
| 282 | } |
||
| 283 | |||
| 284 | if ($rate <= 4.9) { |
||
| 285 | return ' |
||
| 286 | <i class="fa fa-star"></i> |
||
| 287 | <i class="fa fa-star"></i> |
||
| 288 | <i class="fa fa-star"></i> |
||
| 289 | <i class="fa fa-star"></i> |
||
| 290 | <i class="fa fa-star-half-o"></i> |
||
| 291 | '; |
||
| 292 | } |
||
| 293 | |||
| 294 | if ($rate > 4.9) { |
||
| 295 | return ' |
||
| 296 | <i class="fa fa-star"></i> |
||
| 304 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.