Source\Models\Phone

Complexity

Total Complexity

11

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	save()	0	29	6
A	bootstrap()	0	6	1
A	findByUserId()	0	15	3

<?php

namespace Source\Models;

use Source\Core\Model;
use Source\Core\Connect;

/**
 * @package Source\Models
 */
class Phone extends Model
{
    /**
     * Phone constructor.
     */
    public function __construct()
    {
        parent::__construct("phone", ["id"], ["user_id", "phone_type_id", "number"]);
    }

    /**
     * @param int $user_id
     * @param int $phone_type_id
     * @param int $phone_type_id
     * @return Phone
     */
    public function bootstrap(int $user_id, int $phone_type_id, int $number): Phone
    {
        $this->user_id = $user_id;

The property user_id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->phone_type_id = $phone_type_id;

The property phone_type_id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->number = $number;

The property number does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * @param string $userId
     * @return null|Phone
     */
    public function findByUserId(string $userId)
    {
        try {
            $stmt = Connect::getInstance()->prepare("SELECT phone.id, phone.number, phone_type.name FROM redstore.phone INNER JOIN redstore.phone_type ON phone_type.id = phone.phone_type_id WHERE phone.user_id = :userId;");
            $stmt->bindValue(":userId", $userId, \PDO::PARAM_INT);
            $stmt->execute();

            if (!$stmt->rowCount()) {
                return null;
            }

            return $stmt->fetchAll();
        } catch (\PDOException $exception) {
            $this->fail = $exception;
            return null;
        }
    }

    /**
     * @return bool
     */
    public function save(): bool
    {
        if (!$this->required()) {
            $this->error = "Faltam campos obrigatórios!";
            return false;
        }

        /** Phone Update */
        if (!empty($this->id)) {

The property id does not exist on Source\Models\Phone. Since you implemented __get, consider adding a @property annotation.

            $phoneId = $this->id;

            $this->update($this->safe(), "id = :id", "id={$phoneId}");
            if ($this->fail()) {
                $this->error = "Erro ao atualizar, verifique os dados";
                return false;
            }
        }

        /** Phone Create */
        if (empty($this->id)) {
            $phoneId = $this->create($this->safe());
            if ($this->fail()) {
                $this->error = "Erro ao cadastrar, verifique os dados";
                return false;
            }
        }

        $this->data = ($this->findById($phoneId))->data();

The variable $phoneId does not seem to be defined for all execution paths leading up to this point.

        return true;
    }
}