Source\Models\Address\State

Complexity

Total Complexity

11

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	findByName()	0	5	1
A	bootstrap()	0	5	1
A	__construct()	0	3	1
B	save()	0	39	8

<?php

namespace Source\Models\Address;

use Source\Core\Model;

/**
 * @package Source\Models
 */
class State extends Model
{
    /**
     * State constructor.
     */
    public function __construct()
    {
        parent::__construct("state", ["id"], ["name", "acronym"]);
    }

    /**
     * @param string $name
     * @param string $acronym
     * @return State
     */
    public function bootstrap(string $name, string $acronym): State
    {
        $this->name = $name;

The property name does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->acronym = $acronym;

The property acronym does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * @param string $name
     * @param string $columns
     * @return null|State
     */
    public function findByName(string $name, string $columns = "*"): ?State
    {
        $find = $this->find("name = :name", "name={$name}", $columns);

        return $find->fetch();
    }

    /**
     * @return bool
     */
    public function save(): bool
    {
        if (!$this->required()) {
            $this->error = "Faltam campos obrigatórios!";
            return false;
        }

        /** State Update */
        if (!empty($this->id)) {

The property id does not exist on Source\Models\Address\State. Since you implemented __get, consider adding a @property annotation.

            $stateId = $this->id;

            if ($this->find("name = :e AND id != :i", "e={$this->name}&i={$stateId}", "id")->fetch()) {
                $this->error = "O estado informado já está cadastrado!";
                return false;
            }

            $this->update($this->safe(), "id = :id", "id={$stateId}");
            if ($this->fail()) {
                $this->error = "Erro ao atualizar, verifique os dados";
                return false;
            }
        }

        /** State Create */
        if (empty($this->id)) {
            if ($this->find("name = :e AND id != :i", "e={$this->name}&i={$this->id}", "id")->fetch()) {
                $this->error = "O estado informado já está cadastrado!";
                return false;
            }

            $stateId = $this->create($this->safe());
            if ($this->fail()) {
                $this->error = "Erro ao cadastrar, verifique os dados";
                return false;
            }
        }

        $this->data = ($this->findById($stateId))->data();

The variable $stateId does not seem to be defined for all execution paths leading up to this point.

        return true;
    }
}