MovingImage\Bundle\VMProApiBundle\EventListener\BypassCacheListener

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	onKernelRequest()	0	15	3
A	getSubscribedEvents()	0	6	1

<?php

namespace MovingImage\Bundle\VMProApiBundle\EventListener;

use MovingImage\Bundle\VMProApiBundle\Decorator\BlackholeCacheItemPoolDecorator;
use MovingImage\Client\VMPro\ApiClient\AbstractApiClient;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * This listener kicks in only if the `cache_bypass_argument` bundle config option is set.
 * If the request contains an argument matching the value configured in the aforementioned config option
 * and the value of that argument evaluates to true, this listener will modify the cache pool implementation
 * used by the VMPro API client, by decorating it with a blackhole cache implementation:
 * one that stores responses to cache, but never returns a hit.
 */
class BypassCacheListener implements EventSubscriberInterface
{
    /**
     * @var ContainerInterface
     */
    private $container;

    /**
     * @var string|null
     */
    private $cacheBypassArgument;

    /**
     * @param ContainerInterface $container
     * @param string             $cacheBypassArgument
     */
    public function __construct(ContainerInterface $container, $cacheBypassArgument = null)
    {
        $this->container = $container;
        $this->cacheBypassArgument = $cacheBypassArgument;
    }

    /**
     * @param GetResponseEvent $event
     */
    public function onKernelRequest(GetResponseEvent $event)
    {
        if (!$this->cacheBypassArgument) {

The expression $this->cacheBypassArgument of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            return;
        }

        $request = $event->getRequest();

        if ($request->get($this->cacheBypassArgument)) {
            /** @var AbstractApiClient $apiClient */
            $apiClient = $this->container->get('vmpro_api.client');
            $cachePool = new BlackholeCacheItemPoolDecorator($apiClient->getCacheItemPool());

The method getCacheItemPool() does not seem to exist on object<MovingImage\Client\VMPro\ApiClient\AbstractApiClient>.

            $apiClient->setCacheItemPool($cachePool);

The method setCacheItemPool() does not seem to exist on object<MovingImage\Client\VMPro\ApiClient\AbstractApiClient>.

        }
    }

    /**
     * @return array
     */
    public static function getSubscribedEvents()
    {
        return [
            KernelEvents::REQUEST => 'onKernelRequest',
        ];
    }
}