ParsedConstantsBuilder::determineType() - Code Metrics - Inspection of "Merge pull request #26 from MontealegreLuis/enums" - MontealegreLuis/phuml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1ba30a...8ac47c )

by Luis

created 2022-06-20 17:05 UTC

ParsedConstantsBuilder::determineType() A

↳ Parent: ParsedConstantsBuilder

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	9
ccs	6
cts	6
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);
/**
 * This source file is subject to the license that is bundled with this package in the file LICENSE.
 */

namespace PhUml\Parser\Code\Builders\Members;

use PhpParser\Node\Const_;
filter:
    dependency_paths: ["lib/*"]
use PhpParser\Node\Expr\ConstFetch;
filter:
    dependency_paths: ["lib/*"]
use PhpParser\Node\Stmt\ClassConst;
filter:
    dependency_paths: ["lib/*"]
use PhUml\Code\Properties\Constant;
use PhUml\Code\Variables\TypeDeclaration;

/**
 * It builds an array of `Constants` for either a `ClassDefinition` or an `InterfaceDefinition`
 */
final class ParsedConstantsBuilder implements ConstantsBuilder
{
    /** @var string[] */
    private const TYPES = [
        'integer' => 'int',
        'double' => 'float',
        'string' => 'string',
    ];

    public function __construct(private readonly VisibilityBuilder $visibilityBuilder)
    {
    }

    /**
     * @param ClassConst[] $classConstants
     * @return Constant[]
     */
    public function build(array $classConstants): array
    {
        return array_map(fn (ClassConst $constant): Constant => new Constant(
            (string) $constant->consts[0]->name,
            TypeDeclaration::from($this->determineType($constant->consts[0])),
            $this->visibilityBuilder->build($constant)
        ), $classConstants);
    }

    private function determineType(Const_ $constant): ?string
    {
        if (property_exists($constant->value, 'value')) {
            return self::TYPES[\gettype($constant->value->value)];
        }
        if (! $constant->value instanceof ConstFetch) {
            return null;
        }
        return 'bool';
    }
}


1		<?php declare(strict_types=1);
2		/**
3		* This source file is subject to the license that is bundled with this package in the file LICENSE.
4		*/
5
6		namespace PhUml\Parser\Code\Builders\Members;
7
8		use PhpParser\Node\Const_;
		0 ignored issues – show Bug introduced 2021-05-30 23:58 UTC by Report Bug Copy Issue Report The type `PhpParser\Node\Const_` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9		use PhpParser\Node\Expr\ConstFetch;
		0 ignored issues – show Bug introduced 2021-05-30 23:58 UTC by Report Bug Copy Issue Report The type `PhpParser\Node\Expr\ConstFetch` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
10		use PhpParser\Node\Stmt\ClassConst;
		0 ignored issues – show Bug introduced 2021-08-15 15:50 UTC by Report Bug Copy Issue Report The type `PhpParser\Node\Stmt\ClassConst` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11		use PhUml\Code\Properties\Constant;
12		use PhUml\Code\Variables\TypeDeclaration;
13
14		/**
15		* It builds an array of `Constants` for either a `ClassDefinition` or an `InterfaceDefinition`
16		*/
17		final class ParsedConstantsBuilder implements ConstantsBuilder
18		{
19		/** @var string[] */
20		private const TYPES = [
21		'integer' => 'int',
22		'double' => 'float',
23		'string' => 'string',
24		];
25
26	45	public function __construct(private readonly VisibilityBuilder $visibilityBuilder)
27		{
28		}
29
30		/**
31		* @param ClassConst[] $classConstants
32		* @return Constant[]
33		*/
34	30	public function build(array $classConstants): array
35		{
36	30	return array_map(fn (ClassConst $constant): Constant => new Constant(
37	17	(string) $constant->consts[0]->name,
38	17	TypeDeclaration::from($this->determineType($constant->consts[0])),
39	17	$this->visibilityBuilder->build($constant)
40		), $classConstants);
41		}
42
43	17	private function determineType(Const_ $constant): ?string
44		{
45	17	if (property_exists($constant->value, 'value')) {
46	16	return self::TYPES[\gettype($constant->value->value)];
47		}
48	13	if (! $constant->value instanceof ConstFetch) {
49	1	return null;
50		}
51	12	return 'bool';
52		}
53		}
54

MontealegreLuis / phuml

Push — master ( 1ba30a...8ac47c )

ParsedConstantsBuilder::determineType() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like