ParsedConstantsBuilder::determineType() - Code Metrics - Inspection of "Improve Type Resolution" - MontealegreLuis/phuml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 5.0 (#10)

by Luis

created 2021-08-17 03:36 UTC

ParsedConstantsBuilder::determineType() A

↳ Parent: ParsedConstantsBuilder

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	9
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);
/**
 * PHP version 8.0
 *
 * This source file is subject to the license that is bundled with this package in the file LICENSE.
 */

namespace PhUml\Parser\Code\Builders\Members;

use PhpParser\Node\Const_;
filter:
    dependency_paths: ["lib/*"]
use PhpParser\Node\Expr\ConstFetch;
filter:
    dependency_paths: ["lib/*"]
use PhpParser\Node\Stmt\ClassConst;
filter:
    dependency_paths: ["lib/*"]
use PhUml\Code\Attributes\Constant;
use PhUml\Code\Variables\TypeDeclaration;

/**
 * It builds an array of `Constants` for either a `ClassDefinition` or an `InterfaceDefinition`
 */
final class ParsedConstantsBuilder implements ConstantsBuilder
{
    /** @var string[] */
    private const TYPES = [
        'integer' => 'int',
        'double' => 'float',
        'string' => 'string',
    ];

    public function __construct(private VisibilityBuilder $visibilityBuilder)
    {
    }

    /**
     * @param ClassConst[] $classConstants
     * @return Constant[]
     */
    public function build(array $classConstants): array
    {
        return array_map(fn (ClassConst $constant): Constant => new Constant(
            (string) $constant->consts[0]->name,
            TypeDeclaration::from($this->determineType($constant->consts[0])),
            $this->visibilityBuilder->build($constant)
        ), $classConstants);
    }

    private function determineType(Const_ $constant): ?string
    {
        if (property_exists($constant->value, 'value')) {
            return self::TYPES[\gettype($constant->value->value)];
        }
        if (! $constant->value instanceof ConstFetch) {
            return null;
        }
        return 'bool';
    }
}


1			<?php declare(strict_types=1);
2			/**
3			* PHP version 8.0
4			*
5			* This source file is subject to the license that is bundled with this package in the file LICENSE.
6			*/
7
8			namespace PhUml\Parser\Code\Builders\Members;
9
10			use PhpParser\Node\Const_;
			0 ignored issues – show Bug introduced 2021-05-30 23:58 UTC by Report Bug Copy Issue Report The type `PhpParser\Node\Const_` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use PhpParser\Node\Expr\ConstFetch;
			0 ignored issues – show Bug introduced 2021-05-30 23:58 UTC by Report Bug Copy Issue Report The type `PhpParser\Node\Expr\ConstFetch` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12			use PhpParser\Node\Stmt\ClassConst;
			0 ignored issues – show Bug introduced 2021-08-15 15:50 UTC by Report Bug Copy Issue Report The type `PhpParser\Node\Stmt\ClassConst` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
13			use PhUml\Code\Attributes\Constant;
14			use PhUml\Code\Variables\TypeDeclaration;
15
16			/**
17			* It builds an array of `Constants` for either a `ClassDefinition` or an `InterfaceDefinition`
18			*/
19			final class ParsedConstantsBuilder implements ConstantsBuilder
20			{
21			/** @var string[] */
22			private const TYPES = [
23			'integer' => 'int',
24			'double' => 'float',
25			'string' => 'string',
26			];
27
28			public function __construct(private VisibilityBuilder $visibilityBuilder)
29			{
30			}
31
32			/**
33			* @param ClassConst[] $classConstants
34			* @return Constant[]
35			*/
36			public function build(array $classConstants): array
37			{
38			return array_map(fn (ClassConst $constant): Constant => new Constant(
39			(string) $constant->consts[0]->name,
40			TypeDeclaration::from($this->determineType($constant->consts[0])),
41			$this->visibilityBuilder->build($constant)
42			), $classConstants);
43			}
44
45			private function determineType(Const_ $constant): ?string
46			{
47			if (property_exists($constant->value, 'value')) {
48			return self::TYPES[\gettype($constant->value->value)];
49			}
50			if (! $constant->value instanceof ConstFetch) {
51			return null;
52			}
53			return 'bool';
54			}
55			}
56

MontealegreLuis / phuml

Pull Request — 5.0 (#10)

ParsedConstantsBuilder::determineType() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like