Total Complexity | 42 |
Total Lines | 324 |
Duplicated Lines | 0 % |
Changes | 0 |
Complex classes like LdapAuthIntegration often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LdapAuthIntegration, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
21 | class LdapAuthIntegration extends AbstractSsoFormIntegration |
||
22 | { |
||
23 | /** |
||
24 | * @return string |
||
25 | */ |
||
26 | public function getName() |
||
27 | { |
||
28 | return 'LdapAuth'; |
||
29 | } |
||
30 | |||
31 | /** |
||
32 | * @return string |
||
33 | */ |
||
34 | public function getDisplayName() |
||
35 | { |
||
36 | return 'LDAP Authentication'; |
||
37 | } |
||
38 | |||
39 | /** |
||
40 | * @return string |
||
41 | */ |
||
42 | public function getAuthenticationType() |
||
43 | { |
||
44 | return 'none'; |
||
45 | } |
||
46 | |||
47 | /** |
||
48 | * {@inheritdoc} |
||
49 | * |
||
50 | * @return array |
||
51 | */ |
||
52 | public function getRequiredKeyFields() |
||
53 | { |
||
54 | return [ |
||
55 | ]; |
||
56 | } |
||
57 | |||
58 | /** |
||
59 | * {@inheritdoc} |
||
60 | * |
||
61 | * @return array |
||
62 | */ |
||
63 | public function getSecretKeys() |
||
64 | { |
||
65 | return [ |
||
66 | ]; |
||
67 | } |
||
68 | |||
69 | /** |
||
70 | * {@inheritdoc} |
||
71 | * |
||
72 | * @return string |
||
73 | */ |
||
74 | public function getAuthTokenKey() |
||
77 | } |
||
78 | |||
79 | /** |
||
80 | * {@inheritdoc} |
||
81 | * |
||
82 | * @param array $settings |
||
83 | * @param array $parameters |
||
84 | * |
||
85 | * @return bool|array false if no error; otherwise the error string |
||
86 | * |
||
87 | * @throws \Symfony\Component\Security\Core\Exception\AuthenticationException |
||
88 | */ |
||
89 | public function authCallback($settings = [], $parameters = []) |
||
90 | { |
||
91 | $hostname = $settings['hostname']; |
||
92 | $port = (int) $settings['port']; |
||
93 | $ssl = (bool) $settings['ssl']; |
||
94 | $startTls = (bool) $settings['starttls']; |
||
95 | $ldapVersion = !empty($settings['version']) ? (int) $settings['version'] : 3; |
||
96 | |||
97 | if (substr($hostname, 0, 7) === 'ldap://') { |
||
98 | $hostname = str_replace('ldap://', '', $hostname); |
||
99 | } elseif (substr($hostname, 0, 8) === 'ldaps://') { |
||
100 | $ssl = true; |
||
101 | $startTls = false; |
||
102 | $hostname = str_replace('ldaps://', '', $hostname); |
||
103 | } |
||
104 | |||
105 | if (empty($port)) { |
||
106 | if ($ssl) { |
||
107 | $port = 636; |
||
108 | } else { |
||
109 | $port = 389; |
||
110 | } |
||
111 | } |
||
112 | |||
113 | if (!empty($hostname) && !empty($parameters['login'])) { |
||
114 | $ldap = new LdapClient($hostname, $port, $ldapVersion, $ssl, $startTls); |
||
115 | |||
116 | $response = $this->ldapUserLookup($ldap, $settings, $parameters); |
||
117 | |||
118 | return $this->extractAuthKeys($response); |
||
119 | } |
||
120 | |||
121 | return false; |
||
122 | } |
||
123 | |||
124 | /** |
||
125 | * LDAP authentication and lookup user information. |
||
126 | * |
||
127 | * @param \Symfony\Component\Ldap\LdapClient $ldap |
||
128 | * @param array $settings |
||
129 | * @param array $parameters |
||
130 | * |
||
131 | * @return array array containing the LDAP lookup results or error message(s). |
||
132 | * |
||
133 | * @throws \Symfony\Component\Security\Core\Exception\AuthenticationException |
||
134 | */ |
||
135 | private function ldapUserLookup($ldap, $settings = [], $parameters = []) |
||
136 | { |
||
137 | $base_dn = $settings['base_dn']; |
||
138 | $userKey = $settings['user_key']; |
||
139 | $query = $settings['user_query']; |
||
140 | $is_ad = $settings['is_ad']; |
||
141 | $ad_domain = $settings['ad_domain']; |
||
142 | |||
143 | $login = $parameters['login']; |
||
144 | $password = $parameters['password']; |
||
145 | |||
146 | try { |
||
147 | if ($is_ad) { |
||
148 | $dn = "$login@$ad_domain"; |
||
149 | } else { |
||
150 | $dn = "$userKey=$login,$base_dn"; |
||
151 | } |
||
152 | |||
153 | $userquery = "$userKey=$login"; |
||
154 | $query = "(&($userquery)$query)"; // original $query already has brackets! |
||
155 | |||
156 | $ldap->bind($dn, $password); |
||
157 | $response = $ldap->find($base_dn, $query); |
||
158 | // If we reach this far, we expect to have found something |
||
159 | // and join the settings to the response to retrieve user fields |
||
160 | if (is_array($response)) { |
||
161 | $response['settings'] = $settings; |
||
162 | } |
||
163 | } catch (\Exception $e) { |
||
164 | $response = array( |
||
165 | 'errors' => array( |
||
166 | $this->factory->getTranslator()->trans( |
||
167 | 'mautic.integration.sso.ldapauth.error.authentication_issue', |
||
168 | [], |
||
169 | 'flashes' |
||
170 | ), |
||
171 | $e->getMessage() |
||
172 | ) |
||
173 | ); |
||
174 | } |
||
175 | |||
176 | return $response; |
||
177 | } |
||
178 | |||
179 | /** |
||
180 | * {@inheritdoc} |
||
181 | * |
||
182 | * @param $data |
||
183 | * @param $tokenOverride |
||
184 | * |
||
185 | * @return bool|array false if no error; otherwise the error string |
||
186 | * |
||
187 | * @throws \Symfony\Component\Security\Core\Exception\AuthenticationException |
||
188 | */ |
||
189 | public function extractAuthKeys($data, $tokenOverride = null) |
||
216 | } |
||
217 | } |
||
218 | |||
219 | /** |
||
220 | * {@inheritdoc} |
||
221 | * |
||
222 | * @param mixed $response |
||
223 | * |
||
224 | * @return mixed |
||
225 | * |
||
226 | * @throws \Doctrine\ORM\ORMException |
||
227 | */ |
||
228 | public function getUser($response) |
||
229 | { |
||
230 | if (is_array($response) && isset($response['settings']) && isset($response['data'])) { |
||
231 | $settings = $response['settings']; |
||
232 | $userKey = $settings['user_key']; |
||
233 | $userEmail = $settings['user_email']; |
||
234 | $userFirstname = $settings['user_firstname']; |
||
235 | $userLastname = $settings['user_lastname']; |
||
236 | $userFullname = $settings['user_fullname']; |
||
237 | |||
238 | $data = $response['data']; |
||
239 | $login = self::arrayGet($data, $userKey, [null])[0]; |
||
240 | $email = self::arrayGet($data, $userEmail, [null])[0]; |
||
241 | |||
242 | if (empty($login) || empty($email)) { |
||
243 | // Login or email could not be found so bail |
||
244 | return false; |
||
245 | } |
||
246 | |||
247 | $firstname = self::arrayGet($data, $userFirstname, [null])[0]; |
||
248 | $lastname = self::arrayGet($data, $userLastname, [null])[0]; |
||
249 | |||
250 | if ((empty($firstname) || empty($lastname)) && isset($data[$userFullname])) { |
||
251 | $names = explode(' ', $data[$userFullname][0]); |
||
252 | if (count($names) > 1) { |
||
253 | $firstname = $names[0]; |
||
254 | unset($names[0]); |
||
255 | $lastname = implode(' ', $names); |
||
256 | } else { |
||
257 | $firstname = $lastname = $names[0]; |
||
258 | } |
||
259 | } |
||
260 | |||
261 | $user = new User(); |
||
262 | $user->setUsername($login) |
||
263 | ->setEmail($email) |
||
264 | ->setFirstName($firstname) |
||
265 | ->setLastName($lastname) |
||
266 | ->setRole( |
||
267 | $this->getUserRole() |
||
268 | ); |
||
269 | |||
270 | return $user; |
||
271 | } |
||
272 | |||
273 | return false; |
||
274 | } |
||
275 | |||
276 | /** |
||
277 | * Get a value from an array or return default value if not set. |
||
278 | * |
||
279 | * @param array $array source array |
||
280 | * @param string $key key to get from array |
||
281 | * @param mixed $default default value if key not set in array |
||
282 | * |
||
283 | * @return mixed a value from array or default value. |
||
284 | */ |
||
285 | private function arrayGet($array, $key, $default = null) |
||
286 | { |
||
287 | return isset($array[$key]) ? $array[$key] : $default; |
||
288 | } |
||
289 | |||
290 | /** |
||
291 | * Returns if failed LDAP authentication should fallback to local authentication. |
||
292 | * |
||
293 | * @return bool |
||
294 | */ |
||
295 | public function shouldFallbackToLocalAuth() |
||
300 | } |
||
301 | |||
302 | /** |
||
303 | * {@inheritdoc} |
||
304 | * |
||
305 | * @param Form|\Symfony\Component\Form\FormBuilder $builder |
||
306 | * @param array $data |
||
307 | * @param string $formArea |
||
308 | */ |
||
309 | public function appendToForm(&$builder, $data, $formArea) |
||
345 | ], |
||
346 | ] |
||
351 |